Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFF16C43381 for ; Wed, 27 Mar 2019 21:00:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 745612075E for ; Wed, 27 Mar 2019 21:00:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dW9XrtSu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728016AbfC0VAt (ORCPT ); Wed, 27 Mar 2019 17:00:49 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:35266 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726136AbfC0VAr (ORCPT ); Wed, 27 Mar 2019 17:00:47 -0400 Received: by mail-wr1-f66.google.com with SMTP id w1so20287090wrp.2 for ; Wed, 27 Mar 2019 14:00:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=8+UVOABIYKYtsDA8UnDzDZebIJDvDt5IX5Vmlfa+3HI=; b=dW9XrtSuIEss4tO1/lMJW2Iz8UEeB+qnkmoR+aVgYVLbUnUv0zr4jDIi5W5L2yT1/C NkIq3INprE47cc4jx7tFyTxe/PNgajERAUnr5Q1hTtoj9Z/cABe6ZMRcauvn5jzstPJo 4P8ob5Spj4ToRfaR8+UFOJ0BjS70UXBR9y6KXq7vHeMOhbPhOfdrZzCLPdmW71Rgp9AK GxA1aIPdfT5a5UqTmdQA4dbmwcTwyHWG+BlTVtju3grFiwS6gi0c2pp8tD0OkLST3+vP t3L67wXY2lO2C5kJjmwr7VcFdbC7id/DT8Ipcnhy0/5sQ8IgT1DyWXqhXAnjvb/XZZ9S ShoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8+UVOABIYKYtsDA8UnDzDZebIJDvDt5IX5Vmlfa+3HI=; b=VFfwKxhXbRdiuK40BmlGlrccptH1HqJ+SLWmX8XXq9FqC3Bue0eAhAqnd0L1XztJvV FmdH7D5/2X74+SqszrWZmFnB4r0yE10R3z4uFq/GCxR5hq4/86OB/bbn4WPpO6SyCpsL DG5ZA+aG6bV9NmlDFD/kOEgPeyeMZ5Ul7ej3XdmLTN7pCpUUSdopJCZr1wFq5cLzFbFL sRrNdRdBYz05q80oEbg/43t3ievU+iu7kc4AmWa3/ntRAoJ+Mj9ge5U5C3XG1pSXX/yQ p8vo0inJrqszaOBuXB9sgu+xBH0OclJeu+1X2SGO0MlxvtDUH/Qj7M/21xhaigvdUCQH 4+JA== X-Gm-Message-State: APjAAAUHPdoqW8YWSTfJhmwFvjcLClfTTnuGDAEHcTVvEzuLMxd1GPHc 2eul5jOGIcqPIqnp8xLjQibNb/X2 X-Google-Smtp-Source: APXvYqxLjOIFuGxNn+N0LOQ3vUrgQpyNo0K4GFXZpW9gbtw/Hgj35Y/UmAu3XmBzLnDGvE6VSVaDjg== X-Received: by 2002:adf:ea0b:: with SMTP id q11mr1539078wrm.233.1553720446053; Wed, 27 Mar 2019 14:00:46 -0700 (PDT) Received: from ?IPv6:2003:ea:8bc4:dc00:ccf1:55bc:aa83:b190? (p200300EA8BC4DC00CCF155BCAA83B190.dip0.t-ipconnect.de. [2003:ea:8bc4:dc00:ccf1:55bc:aa83:b190]) by smtp.googlemail.com with ESMTPSA id w11sm15255251wre.15.2019.03.27.14.00.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Mar 2019 14:00:45 -0700 (PDT) Subject: [PATCH net-next 2/3] net: phy: use genphy_read_abilities in genphy driver From: Heiner Kallweit To: Andrew Lunn , Florian Fainelli , David Miller Cc: "netdev@vger.kernel.org" References: <3d087449-a68f-8233-e97f-29038f8de29a@gmail.com> Message-ID: <6706384d-babf-1f97-a0dd-240e4cd20203@gmail.com> Date: Wed, 27 Mar 2019 21:59:33 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <3d087449-a68f-8233-e97f-29038f8de29a@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Currently the genphy driver populates phydev->supported like this: First all possible feature bits are set, then genphy_config_init() reads the available features from the chip and remove all unsupported features from phydev->supported. This can be simplified by using genphy_read_abilities(). Signed-off-by: Heiner Kallweit --- drivers/net/phy/phy_device.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index 0107366bb..0c4cc9b54 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c @@ -2291,8 +2291,7 @@ static struct phy_driver genphy_driver = { .phy_id_mask = 0xffffffff, .name = "Generic PHY", .soft_reset = genphy_no_soft_reset, - .config_init = genphy_config_init, - .features = PHY_GBIT_ALL_PORTS_FEATURES, + .get_features = genphy_read_abilities, .aneg_done = genphy_aneg_done, .suspend = genphy_suspend, .resume = genphy_resume, -- 2.21.0