From: Chaitanya Kulkarni Date: Fri, 15 Apr 2022 05:36:12 +0000 Subject: [Cluster-devel] [PATCH 01/27] target: remove an incorrect unmap zeroes data deduction In-Reply-To: <20220415045258.199825-2-hch@lst.de> References: <20220415045258.199825-1-hch@lst.de> <20220415045258.199825-2-hch@lst.de> Message-ID: <673afa25-cf3f-616c-6bcd-16de35b307b2@nvidia.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On 4/14/22 21:52, Christoph Hellwig wrote: > For block devices, the SCSI target drivers implements UNMAP as calls to > blkdev_issue_discard, which does not guarantee zeroing just because > Write Zeroes is supported. > > Note that this does not affect the file backed path which uses > fallocate to punch holes. > > Fixes: 2237498f0b5c ("target/iblock: Convert WRITE_SAME to blkdev_issue_zeroout") > Signed-off-by: Christoph Hellwig > Reviewed-by: Martin K. Petersen Not a good assumption to have for sure. Looks good. Reviewed-by: Chaitanya Kulkarni -ck