Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 165EFC0015E for ; Wed, 5 Jul 2023 12:09:25 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E2A1785D4E; Wed, 5 Jul 2023 14:09:23 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=foss.st.com header.i=@foss.st.com header.b="SwCVfitB"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0F4DE8611E; Wed, 5 Jul 2023 14:09:23 +0200 (CEST) Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 803F685202 for ; Wed, 5 Jul 2023 14:09:20 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=prvs=5550e5eb6a=patrick.delaunay@foss.st.com Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 365Big3c011990; Wed, 5 Jul 2023 14:09:18 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=w233sGZh5r/KkikXcg+Z1n5cUdlMxB1vkN9r5KIcKDs=; b=SwCVfitBEWg0p7qAS1K+AfUKurC9c75l8KVE0dhPmnmIm57cfuWVBuNDmWhia7cLH6Ij vDY5kKewjr6RXQM6msx7VeAgV47Ybs3Fovm5KfBfTSLKwtBqWTBa/G/4/C850ZXthOCc dW4nqessPzBHcexC0wtmByd4zlebaBmgqPBlRFI89C0UrHyDWhvnlOjxMe4jSoT5GzAe kleFui49MdTiRzbkUYX34mpHXQav3EU0N/i7wzEeKDhv3V/niwpInv2yYQ7hCzERRPjM cKlpky3nZM9KBCvdcxknGRNXk8B3wZdFA6PINyeKbd/xPTGZhCAmtaZiPTKMzAlTAdF5 UQ== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3rn7wp053h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 05 Jul 2023 14:09:18 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 35746100057; Wed, 5 Jul 2023 14:09:17 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node3.st.com [10.75.129.71]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 27C822248D9; Wed, 5 Jul 2023 14:09:17 +0200 (CEST) Received: from [10.48.1.0] (10.48.1.0) by SHFDAG1NODE3.st.com (10.75.129.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Wed, 5 Jul 2023 14:09:16 +0200 Message-ID: <6798832b-2e55-2d40-e017-bb7c308aaf9f@foss.st.com> Date: Wed, 5 Jul 2023 14:09:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2] board: stm32mp1: add splash screen on dk2 Content-Language: en-US To: Dario Binacchi , CC: Grzegorz Szymaszek , Patrice Chotard , References: <20230704173121.589620-1-dario.binacchi@amarulasolutions.com> From: Patrick DELAUNAY In-Reply-To: <20230704173121.589620-1-dario.binacchi@amarulasolutions.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.48.1.0] X-ClientProxiedBy: SHFCAS1NODE1.st.com (10.75.129.72) To SHFDAG1NODE3.st.com (10.75.129.71) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-05_04,2023-07-05_01,2023-05-22_02 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Dario, On 7/4/23 19:31, Dario Binacchi wrote: > Display the STMicroelectronics logo. > > Signed-off-by: Dario Binacchi > > > --- > > Changes in v2: > - move "splash.h" and "st_logo_data.h" headers before "syscon.h" in order > to keep includes sorted alphabetically. > - remove "logo" variable and pass "(ulong)stmicroelectronics_uboot_logo_8bit_rle" > directly to the bmp_display() function. > > board/st/stm32mp1/stm32mp1.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/board/st/stm32mp1/stm32mp1.c b/board/st/stm32mp1/stm32mp1.c > index 1a1b1844c8c0..ebd3948d519c 100644 > --- a/board/st/stm32mp1/stm32mp1.c > +++ b/board/st/stm32mp1/stm32mp1.c > @@ -31,8 +31,11 @@ > #include > #include > #include > +#include > +#include > #include > #include > +#include > #include > #include > #include > @@ -684,6 +687,14 @@ int board_init(void) > fw_images[0].fw_name = u"STM32MP-FIP"; > fw_images[0].image_index = 1; > #endif > + > + if (IS_ENABLED(CONFIG_CMD_BMP)) { > + if (board_is_stm32mp15x_dk2()) { > + bmp_display((ulong)stmicroelectronics_uboot_logo_8bit_rle, > + BMP_ALIGN_CENTER, BMP_ALIGN_CENTER); > + } > + } > + > return 0; > } > I think "include/st_logo_data.h" should be not directly used for STM32 MPU it is a obsolete way to have splash screen, used by STM32 MCU as STM32F7. And direct management for splash it is not really needed in board code, as it is already managed in VIDEO framework with CONFIG_VIDEO_LOGO enabled by default since commit 845d71ce999936ab5ae2cef4542b221851cde199 ("video: Show the U-Boot logo by default") and with CONFIG_SPLASH_SCREEN see stdio_init_tables()   => splash_display(); position is managed with: - CONFIG_SPLASH_SCREEN_ALIGN - variable: "splashpos=m,m" But by default the U-Boot logo (yellow submarine) is used for VIDEO LOGO (SPLASH_DECL(u_boot_logo) in video uclass or denx for SPLASH is used in tools/Makefile # Generic logo ifeq ($(LOGO_BMP),) LOGO_BMP= $(srctree)/$(src)/logos/denx.bmp # Use board logo and fallback to vendor ifneq ($(wildcard $(srctree)/$(src)/logos/$(BOARD).bmp),) LOGO_BMP= $(srctree)/$(src)/logos/$(BOARD).bmp else ifneq ($(wildcard $(srctree)/$(src)/logos/$(VENDOR).bmp),) LOGO_BMP= $(srctree)/$(src)/logos/$(VENDOR).bmp endif endif The STMicroelectronics logo image can be integrated in this directory with          VENDOR="st"          BOARD="stm32mp1" We need to add it ./tools/logos/st.bmp I can propose something, for all ST board STM32MP1x, not only DK2 Patrick