X-GM-THRID: 6400174624352501760 X-Received: by 10.223.182.139 with SMTP id j11mr120591wre.22.1490550983006; Sun, 26 Mar 2017 10:56:23 -0700 (PDT) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 10.28.193.199 with SMTP id r190ls963226wmf.23.canary-gmail; Sun, 26 Mar 2017 10:56:22 -0700 (PDT) X-Received: by 10.223.152.100 with SMTP id v91mr862580wrb.12.1490550982101; Sun, 26 Mar 2017 10:56:22 -0700 (PDT) Return-Path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com. [185.26.127.97]) by gmr-mx.google.com with ESMTPS id x188si472590wmx.0.2017.03.26.10.56.22 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 26 Mar 2017 10:56:22 -0700 (PDT) Received-SPF: pass (google.com: domain of laurent.pinchart@ideasonboard.com designates 185.26.127.97 as permitted sender) client-ip=185.26.127.97; Authentication-Results: gmr-mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com; spf=pass (google.com: domain of laurent.pinchart@ideasonboard.com designates 185.26.127.97 as permitted sender) smtp.mailfrom=laurent.pinchart@ideasonboard.com Received: from avalon.localnet (178-44-190-109.dsl.ovh.fr [109.190.44.178]) by galahad.ideasonboard.com (Postfix) with ESMTPSA id 023B6201C5; Sun, 26 Mar 2017 19:56:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1490550965; bh=ppwqTdcICBH2pHdzrxelxNsA+3gAt2McW3d9CRzlPto=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RxDhc2SO3hQnxz+6oZxZhFtOtKHkAl/7X9LV6qQd2I5R+TiaG8V3RCqfiZKV7PsHW nCwVWmptpmk/B7ROVwJlS78qRu7Q0SYXXJ4r20lyySgP3m7FP8L351OYM97JleprHz RzwkbJBs8MS0C/3YCdaGLLsJ+44IIEbg3BdhDczk= From: Laurent Pinchart To: Arushi Singhal Cc: outreachy-kernel@googlegroups.com, Mauro Carvalho Chehab , Greg Kroah-Hartman , linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: media: omap4iss: Replace a bit shift by a use of BIT. Date: Sun, 26 Mar 2017 20:57:02 +0300 Message-ID: <6872312.k89i7RhcDr@avalon> User-Agent: KMail/4.14.10 (Linux/4.9.6-gentoo-r1; KDE/4.14.29; x86_64; ; ) In-Reply-To: <20170324160145.GA13421@arushi-HP-Pavilion-Notebook> References: <20170324160145.GA13421@arushi-HP-Pavilion-Notebook> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Hi Arushi, Thank you for the patch. On Friday 24 Mar 2017 21:31:45 Arushi Singhal wrote: > This patch replaces bit shifting on 1 with the BIT(x) macro. > This was done with coccinelle: > @@ > constant c; > @@ > > -1 << c > +BIT(c) > > Signed-off-by: Arushi Singhal Acked-by: Laurent Pinchart Greg, as this is a staging driver, do you want to merge the patch through your tree ? > --- > changes in v2 > -Remove unnecessary parenthesis > > drivers/staging/media/omap4iss/iss_csi2.c | 2 +- > drivers/staging/media/omap4iss/iss_ipipe.c | 2 +- > drivers/staging/media/omap4iss/iss_ipipeif.c | 2 +- > drivers/staging/media/omap4iss/iss_resizer.c | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/media/omap4iss/iss_csi2.c > b/drivers/staging/media/omap4iss/iss_csi2.c index > f71d5f2f179f..f6acc541e8a2 100644 > --- a/drivers/staging/media/omap4iss/iss_csi2.c > +++ b/drivers/staging/media/omap4iss/iss_csi2.c > @@ -1268,7 +1268,7 @@ static int csi2_init_entities(struct iss_csi2_device > *csi2, const char *subname) snprintf(name, sizeof(name), "CSI2%s", > subname); > snprintf(sd->name, sizeof(sd->name), "OMAP4 ISS %s", name); > > - sd->grp_id = 1 << 16; /* group ID for iss subdevs */ > + sd->grp_id = BIT(16); /* group ID for iss subdevs */ > v4l2_set_subdevdata(sd, csi2); > sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE; > > diff --git a/drivers/staging/media/omap4iss/iss_ipipe.c > b/drivers/staging/media/omap4iss/iss_ipipe.c index > d38782e8e84c..d86ef8a031f2 100644 > --- a/drivers/staging/media/omap4iss/iss_ipipe.c > +++ b/drivers/staging/media/omap4iss/iss_ipipe.c > @@ -508,7 +508,7 @@ static int ipipe_init_entities(struct iss_ipipe_device > *ipipe) v4l2_subdev_init(sd, &ipipe_v4l2_ops); > sd->internal_ops = &ipipe_v4l2_internal_ops; > strlcpy(sd->name, "OMAP4 ISS ISP IPIPE", sizeof(sd->name)); > - sd->grp_id = 1 << 16; /* group ID for iss subdevs */ > + sd->grp_id = BIT(16); /* group ID for iss subdevs */ > v4l2_set_subdevdata(sd, ipipe); > sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE; > > diff --git a/drivers/staging/media/omap4iss/iss_ipipeif.c > b/drivers/staging/media/omap4iss/iss_ipipeif.c index > 23de8330731d..cb88b2bd0d82 100644 > --- a/drivers/staging/media/omap4iss/iss_ipipeif.c > +++ b/drivers/staging/media/omap4iss/iss_ipipeif.c > @@ -739,7 +739,7 @@ static int ipipeif_init_entities(struct > iss_ipipeif_device *ipipeif) v4l2_subdev_init(sd, &ipipeif_v4l2_ops); > sd->internal_ops = &ipipeif_v4l2_internal_ops; > strlcpy(sd->name, "OMAP4 ISS ISP IPIPEIF", sizeof(sd->name)); > - sd->grp_id = 1 << 16; /* group ID for iss subdevs */ > + sd->grp_id = BIT(16); /* group ID for iss subdevs */ > v4l2_set_subdevdata(sd, ipipeif); > sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE; > > diff --git a/drivers/staging/media/omap4iss/iss_resizer.c > b/drivers/staging/media/omap4iss/iss_resizer.c index > f1d352c711d5..4bbfa20b3c38 100644 > --- a/drivers/staging/media/omap4iss/iss_resizer.c > +++ b/drivers/staging/media/omap4iss/iss_resizer.c > @@ -782,7 +782,7 @@ static int resizer_init_entities(struct > iss_resizer_device *resizer) v4l2_subdev_init(sd, &resizer_v4l2_ops); > sd->internal_ops = &resizer_v4l2_internal_ops; > strlcpy(sd->name, "OMAP4 ISS ISP resizer", sizeof(sd->name)); > - sd->grp_id = 1 << 16; /* group ID for iss subdevs */ > + sd->grp_id = BIT(16); /* group ID for iss subdevs */ > v4l2_set_subdevdata(sd, resizer); > sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE; -- Regards, Laurent Pinchart