From: Timur Tabi (timur@kernel.org) Date: Wed, 11 Dec 2019 18:51:38 -0600 Subject: [PATCH 08/35] common: Move relocate_code() to init.h In-Reply-To: <20191211174637.8.Ia1254c208d18fe2e6e740eb8429e5943891cbfe7@changeid> References: <20191212004755.11091-2-sjg@chromium.org> <20191211174637.8.Ia1254c208d18fe2e6e740eb8429e5943891cbfe7@changeid> Message-ID: <68eda3c0-7143-f424-9d93-2efe4d456aea@kernel.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 12/11/19 6:47 PM, Simon Glass wrote: > - * void relocate_code (addr_moni) > + * void relocate_code(addr_moni) Is this really necessary? I think you're bloating your patch with these comment changes. Your patch would be half the size without these changes, so I don't think this really qualifies as "while we are here".