From: "Souza, Jose" Subject: Re: [PATCH v3 4/7] drm/i915/psr: Begin to handle PSR/PSR2 errors set by sink Date: Wed, 13 Jun 2018 20:02:23 +0000 Message-ID: <68f6ecf94bc3afafee5c5fe632e8dcc397ff5b62.camel@intel.com> References: <20180517222118.14246-1-jose.souza@intel.com> <20180517222118.14246-4-jose.souza@intel.com> <1527033515.2226.26.camel@intel.com> <1528921020.31662.43.camel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1C0506E174 for ; Wed, 13 Jun 2018 20:02:26 +0000 (UTC) In-Reply-To: <1528921020.31662.43.camel@intel.com> Content-Language: en-US Content-ID: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "intel-gfx@lists.freedesktop.org" , "Pandiyan, Dhinakaran" Cc: "Vivi, Rodrigo" List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCAyMDE4LTA2LTEzIGF0IDEzOjE3IC0wNzAwLCBEaGluYWthcmFuIFBhbmRpeWFuIHdy b3RlOg0KPiBPbiBUdWUsIDIwMTgtMDYtMDUgYXQgMjI6NDUgKzAwMDAsIFNvdXphLCBKb3NlIHdy b3RlOg0KPiA+IE9uIFR1ZSwgMjAxOC0wNS0yMiBhdCAxNjo1OCAtMDcwMCwgRGhpbmFrYXJhbiBQ YW5kaXlhbiB3cm90ZToNCj4gPiA+IA0KPiA+ID4gT24gVGh1LCAyMDE4LTA1LTE3IGF0IDE1OjIx IC0wNzAwLCBKb3PDqSBSb2JlcnRvIGRlIFNvdXphIHdyb3RlOg0KPiA+ID4gPiANCj4gPiA+ID4g ZURQIHNwZWMgc3RhdGVzIHRoYXQgc2luayBkZXZpY2Ugd2lsbCBkbyBhIHNob3J0IHB1bHNlIGlu IEhQRA0KPiA+ID4gPiBsaW5lIHdoZW4gdGhlcmUgaXMgYSBQU1IvUFNSMiBlcnJvciB0aGF0IG5l ZWRzIHRvIGJlIGhhbmRsZWQgYnkNCj4gPiA+ID4gc291cmNlLCB0aGlzIGlzIGhhbmRsaW5nIHRo ZSBmaXJzdCBhbmQgbW9zdCBzaW1wbGVzIGVycm9yOg0KPiA+ID4gPiBEUF9QU1JfU0lOS19JTlRF Uk5BTF9FUlJPUi4NCj4gPiA+ID4gDQo+ID4gPiA+IEhlcmUgdGFraW5nIHRoZSBzYWZlc3QgYXBw cm9hY2ggYW5kIGRpc2FibGluZyBQU1IoYXQgbGVhc3QNCj4gPiA+ID4gdW50aWwNCj4gPiA+ID4g dGhlIG5leHQgbW9kZXNldCksIHRvIGF2b2lkIG11bHRpcGxlIHJlbmRlcmluZyBpc3N1ZXMgZHVl IHRvDQo+ID4gPiA+IGJhZCBwYW5uZWxzLg0KPiA+ID4gPiANCj4gPiA+ID4gdjM6DQo+ID4gPiA+ IGRpc2FibGluZyBQU1IgaW5zdGVhZCBvZiBleGl0aW5nIG9uIGVycm9yDQo+ID4gPiA+IA0KPiA+ ID4gPiBDYzogRGhpbmFrYXJhbiBQYW5kaXlhbiA8ZGhpbmFrYXJhbi5wYW5kaXlhbkBpbnRlbC5j b20+DQo+ID4gPiA+IENjOiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2aUBpbnRlbC5jb20+DQo+ ID4gPiA+IFNpZ25lZC1vZmYtYnk6IEpvc8OpIFJvYmVydG8gZGUgU291emEgPGpvc2Uuc291emFA aW50ZWwuY29tPg0KPiA+ID4gPiAtLS0NCj4gPiA+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2RwLmMgIHwgIDIgKysNCj4gPiA+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Ry di5oIHwgIDEgKw0KPiA+ID4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMgfCA2 Mg0KPiA+ID4gPiArKysrKysrKysrKysrKysrKysrKysrKysrLQ0KPiA+ID4gPiAtLQ0KPiA+ID4g PiAtLQ0KPiA+ID4gPiAtLQ0KPiA+ID4gPiAgMyBmaWxlcyBjaGFuZ2VkLCA1MiBpbnNlcnRpb25z KCspLCAxMyBkZWxldGlvbnMoLSkNCj4gPiA+ID4gDQo+ID4gPiA+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jDQo+ID4gPiA+IGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZHAuYw0KPiA+ID4gPiBpbmRleCBiODZkYTQ4ZmQzOGUuLmZhMjg1MWQ0ZmIzNiAx MDA2NDQNCj4gPiA+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYw0KPiA+ ID4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jDQo+ID4gPiA+IEBAIC00 NDc5LDYgKzQ0NzksOCBAQCBpbnRlbF9kcF9zaG9ydF9wdWxzZShzdHJ1Y3QgaW50ZWxfZHANCj4g PiA+ID4gKmludGVsX2RwKQ0KPiA+ID4gPiAgCWlmIChpbnRlbF9kcF9uZWVkc19saW5rX3JldHJh aW4oaW50ZWxfZHApKQ0KPiA+ID4gPiAgCQlyZXR1cm4gZmFsc2U7DQo+ID4gPiA+ICANCj4gPiA+ ID4gKwlpbnRlbF9wc3Jfc2hvcnRfcHVsc2UoaW50ZWxfZHApOw0KPiA+ID4gPiArDQo+ID4gPiA+ ICAJaWYgKGludGVsX2RwLT5jb21wbGlhbmNlLnRlc3RfdHlwZSA9PQ0KPiA+ID4gPiBEUF9URVNU X0xJTktfVFJBSU5JTkcpDQo+ID4gPiA+IHsNCj4gPiA+ID4gIAkJRFJNX0RFQlVHX0tNUygiTGlu ayBUcmFpbmluZyBDb21wbGlhbmNlIFRlc3QNCj4gPiA+ID4gcmVxdWVzdGVkXG4iKTsNCj4gPiA+ ID4gIAkJLyogU2VuZCBhIEhvdHBsdWcgVWV2ZW50IHRvIHVzZXJzcGFjZSB0byBzdGFydA0KPiA+ ID4gPiBtb2Rlc2V0ICovDQo+ID4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9kcnYuaA0KPiA+ID4gPiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5o DQo+ID4gPiA+IGluZGV4IDQ1MDhiZTYyODQ1MC4uODkyZGE2NTM1OGU5IDEwMDY0NA0KPiA+ID4g PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaA0KPiA+ID4gPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaA0KPiA+ID4gPiBAQCAtMTkyMSw2ICsxOTIx LDcgQEAgdm9pZCBpbnRlbF9wc3JfY29tcHV0ZV9jb25maWcoc3RydWN0DQo+ID4gPiA+IGludGVs X2RwDQo+ID4gPiA+ICppbnRlbF9kcCwNCj4gPiA+ID4gIAkJCSAgICAgIHN0cnVjdCBpbnRlbF9j cnRjX3N0YXRlDQo+ID4gPiA+ICpjcnRjX3N0YXRlKTsNCj4gPiA+ID4gIHZvaWQgaW50ZWxfcHNy X2lycV9jb250cm9sKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwNCj4gPiA+ID4g Ym9vbA0KPiA+ID4gPiBkZWJ1Zyk7DQo+ID4gPiA+ICB2b2lkIGludGVsX3Bzcl9pcnFfaGFuZGxl cihzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsDQo+ID4gPiA+IHUzMg0KPiA+ID4g PiBwc3JfaWlyKTsNCj4gPiA+ID4gK3ZvaWQgaW50ZWxfcHNyX3Nob3J0X3B1bHNlKHN0cnVjdCBp bnRlbF9kcCAqaW50ZWxfZHApOw0KPiA+ID4gPiAgDQo+ID4gPiA+ICAvKiBpbnRlbF9ydW50aW1l X3BtLmMgKi8NCj4gPiA+ID4gIGludCBpbnRlbF9wb3dlcl9kb21haW5zX2luaXQoc3RydWN0IGRy bV9pOTE1X3ByaXZhdGUgKik7DQo+ID4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9wc3IuYw0KPiA+ID4gPiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bz ci5jDQo+ID4gPiA+IGluZGV4IGQ4ODc5OTQ4Mjg3NS4uNjA3OTdjOGY5ZjBlIDEwMDY0NA0KPiA+ ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYw0KPiA+ID4gPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYw0KPiA+ID4gPiBAQCAtNzQxLDYgKzc0 MSwyMyBAQCBzdGF0aWMgdm9pZCBoc3dfcHNyX2Rpc2FibGUoc3RydWN0DQo+ID4gPiA+IGludGVs X2RwDQo+ID4gPiA+ICppbnRlbF9kcCkNCj4gPiA+ID4gIAlwc3JfYXV4X2lvX3Bvd2VyX3B1dChp bnRlbF9kcCk7DQo+ID4gPiA+ICB9DQo+ID4gPiA+ICANCj4gPiA+ID4gK3N0YXRpYyB2b2lkIHBz cl9kaXNhYmxlKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHApDQo+IA0KPiBuaXQ6IEhvdyBhYm91 dCBfX3Bzcl9kaXNhYmxlKCk/IE1pZ2h0IGJlIHdvcnRoIGNoZWNraW5nIG90aGVyIGZpbGVzDQo+ IHdoYXQgdGhlIHJpZ2h0IGNvbnZlbnRpb24gaXMuDQoNCkl0IHZhcmllcyBmcm9tIGZpbGUgdG8g ZmlsZSBidXQgaW5zaWRlIG9mIGludGVsX3Bzci5jIHdlIGFyZSBub3QgYWRkaW5nDQogIl9fIiBz byBiZXR0ZXIga2VlcCB0aGF0LCByaWdodD8NCg0KPiANCj4gPiA+ID4gK3srCXN0cnVjdCBpbnRl bF9kaWdpdGFsX3BvcnQgKmludGVsX2RpZ19wb3J0ID0NCj4gPiA+ID4gZHBfdG9fZGlnX3BvcnQo aW50ZWxfZHApOw0KPiA+ID4gPiArCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBpbnRlbF9kaWdf cG9ydC0NCj4gPiA+ID4gPmJhc2UuYmFzZS5kZXY7DQo+ID4gPiA+ICsJc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShkZXYpOw0KPiA+ID4gPiArDQo+ID4gPiA+ICsJ aWYgKCFkZXZfcHJpdi0+cHNyLmVuYWJsZWQpDQo+ID4gPiA+ICsJCXJldHVybjsNCj4gPiA+ID4g Kw0KPiA+ID4gPiArCWRldl9wcml2LT5wc3IuZGlzYWJsZV9zb3VyY2UoaW50ZWxfZHApOw0KPiA+ ID4gPiArDQo+ID4gPiA+ICsJLyogRGlzYWJsZSBQU1Igb24gU2luayAqLw0KPiA+ID4gPiArCWRy bV9kcF9kcGNkX3dyaXRlYigmaW50ZWxfZHAtPmF1eCwgRFBfUFNSX0VOX0NGRywgMCk7DQo+ID4g PiA+ICsJZGV2X3ByaXYtPnBzci5lbmFibGVkID0gTlVMTDsNCj4gPiA+ID4gKwljYW5jZWxfZGVs YXllZF93b3JrX3N5bmMoJmRldl9wcml2LT5wc3Iud29yayk7DQo+ID4gPiA+ICt9DQo+ID4gPiA+ ICsNCj4gPiA+ID4gIC8qKg0KPiA+ID4gPiAgICogaW50ZWxfcHNyX2Rpc2FibGUgLSBEaXNhYmxl IFBTUg0KPiA+ID4gPiAgICogQGludGVsX2RwOiBJbnRlbCBEUA0KPiA+ID4gPiBAQCAtNzYyLDIw ICs3NzksOCBAQCB2b2lkIGludGVsX3Bzcl9kaXNhYmxlKHN0cnVjdCBpbnRlbF9kcA0KPiA+ID4g PiAqaW50ZWxfZHAsDQo+ID4gPiA+ICAJCXJldHVybjsNCj4gPiA+ID4gIA0KPiA+ID4gPiAgCW11 dGV4X2xvY2soJmRldl9wcml2LT5wc3IubG9jayk7DQo+ID4gPiA+IC0JaWYgKCFkZXZfcHJpdi0+ cHNyLmVuYWJsZWQpIHsNCj4gPiA+ID4gLQkJbXV0ZXhfdW5sb2NrKCZkZXZfcHJpdi0+cHNyLmxv Y2spOw0KPiA+ID4gPiAtCQlyZXR1cm47DQo+ID4gPiA+IC0JfQ0KPiA+ID4gPiAtDQo+ID4gPiA+ IC0JZGV2X3ByaXYtPnBzci5kaXNhYmxlX3NvdXJjZShpbnRlbF9kcCk7DQo+ID4gPiA+IC0NCj4g PiA+ID4gLQkvKiBEaXNhYmxlIFBTUiBvbiBTaW5rICovDQo+ID4gPiA+IC0JZHJtX2RwX2RwY2Rf d3JpdGViKCZpbnRlbF9kcC0+YXV4LCBEUF9QU1JfRU5fQ0ZHLCAwKTsNCj4gPiA+ID4gLQ0KPiA+ ID4gPiAtCWRldl9wcml2LT5wc3IuZW5hYmxlZCA9IE5VTEw7DQo+ID4gPiA+ICsJcHNyX2Rpc2Fi bGUoaW50ZWxfZHApOw0KPiA+ID4gPiAgCW11dGV4X3VubG9jaygmZGV2X3ByaXYtPnBzci5sb2Nr KTsNCj4gPiA+ID4gLQ0KPiA+ID4gPiAtCWNhbmNlbF9kZWxheWVkX3dvcmtfc3luYygmZGV2X3By aXYtPnBzci53b3JrKTsNCj4gPiA+ID4gIH0NCj4gPiA+ID4gIA0KPiA+ID4gPiAgc3RhdGljIGJv b2wgcHNyX3dhaXRfZm9yX2lkbGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUNCj4gPiA+ID4gKmRl dl9wcml2KQ0KPiA+ID4gPiBAQCAtMTAxNCwzICsxMDE5LDM0IEBAIHZvaWQgaW50ZWxfcHNyX2lu aXQoc3RydWN0DQo+ID4gPiA+IGRybV9pOTE1X3ByaXZhdGUNCj4gPiA+ID4gKmRldl9wcml2KQ0K PiA+ID4gPiAgCWRldl9wcml2LT5wc3Iuc2V0dXBfdnNjID0gaHN3X3Bzcl9zZXR1cF92c2M7DQo+ ID4gPiA+ICANCj4gPiA+ID4gIH0NCj4gPiA+ID4gKw0KPiA+ID4gPiArdm9pZCBpbnRlbF9wc3Jf c2hvcnRfcHVsc2Uoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCkNCj4gPiA+ID4gK3sNCj4gPiA+ ID4gKwlzdHJ1Y3QgaW50ZWxfZGlnaXRhbF9wb3J0ICppbnRlbF9kaWdfcG9ydCA9DQo+ID4gPiA+ IGRwX3RvX2RpZ19wb3J0KGludGVsX2RwKTsNCj4gPiA+ID4gKwlzdHJ1Y3QgZHJtX2RldmljZSAq ZGV2ID0gaW50ZWxfZGlnX3BvcnQtDQo+ID4gPiA+ID5iYXNlLmJhc2UuZGV2Ow0KPiA+ID4gPiAr CXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZGV2KTsNCj4gPiA+ ID4gKwlzdHJ1Y3QgaTkxNV9wc3IgKnBzciA9ICZkZXZfcHJpdi0+cHNyOw0KPiA+ID4gPiArCXVp bnQ4X3QgdmFsOw0KPiA+ID4gPiArDQo+ID4gPiA+ICsJaWYgKCFIQVNfUFNSKGRldl9wcml2KSB8 fCAhaW50ZWxfZHBfaXNfZWRwKGludGVsX2RwKSkNCj4gPiA+ID4gKwkJcmV0dXJuOw0KPiA+ID4g DQo+ID4gPiAJQ0FOX1BTUihkZXZfcHJpdikgc2hvdWxkIHRha2UgY2FyZSBvZiB0aGlzLg0KPiA+ IA0KPiA+IENBTl9QU1IgaXMgYmV0dGVyIGFuZCBJIHdpbGwgdXNlIHRoYXQsIGJ1dCB0byByZW1v dmUgdGhlIGxvY2sgYW5kDQo+ID4gJ2lmDQo+ID4gKHBzci0+ZW5hYmxlZCAhPSBpbnRlbF9kcCkn IHdlIHdvdWxkIGFsc28gbmVlZCB0byBjaGVjaw0KPiA+IGk5MTVfbW9kcGFyYW1zLmVuYWJsZV9w c3IuIEV2ZW4gYWx0aG91Z2ggd2UgY291bGQgZW5kIHVwIGRvaW5nIHRoZQ0KPiA+IGF1eA0KPiA+ IHRyYW5zYWN0aW9ucyBiZWxsb3cgYW5kIFBTUiBpcyBkaXNhYmxlZChiZWNhdXNlIG9mIG9uZSBv ZiB0aGUNCj4gPiBlcnJvcnMNCj4gPiBiZWxsb3cpLCB3aGF0IGRvIHlvdSB0aGluayBpdCBpcyBz dGlsbCB3b3J0aHkgZG8gaXQgbG9ja2xlc3M/DQo+IA0KPiBUaGF0IGlzIGEgZ29vZCBwb2ludCwg YXZvaWRpbmcgRFBDRCByZWFkIGluIGNhc2UgUFNSIGlzIGRpc2FibGVkIGlzDQo+IGluZGVlZCBi ZXR0ZXIuDQoNCg0KQ29vbCwgSSB3aWxsIHNlbmQgdGhlIG5ldyB2ZXJzaW9uIHNvb24uDQoNClRo YW5rcwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRl bC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK