Return-path: Received: from web23106.mail.ird.yahoo.com ([217.146.189.46]) by www.linuxtv.org with smtp (Exim 4.63) (envelope-from ) id 1JryfT-0003Qj-2T for linux-dvb@linuxtv.org; Fri, 02 May 2008 19:03:34 +0200 Date: Fri, 2 May 2008 17:02:56 +0000 (GMT) From: Juan Antonio Garcia To: Aidan Thornton MIME-Version: 1.0 Message-ID: <690868.46111.qm@web23106.mail.ird.yahoo.com> Cc: Jakob Steidl , linux-dvb@linuxtv.org Subject: Re: [linux-dvb] DVB driver for Pinnacle PCTV200e and PCTV60e List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============1181083220==" Mime-version: 1.0 Sender: linux-dvb-bounces@linuxtv.org Errors-To: linux-dvb-bounces+mchehab=infradead.org@linuxtv.org List-ID: --===============1181083220== Content-Type: multipart/alternative; boundary="0-1487326817-1209747776=:46111" --0-1487326817-1209747776=:46111 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Thanks for the hints.=0A=0AI made a driver update yesterday for kernel 2.6.= 24 using the last v4l tree I got:=0Av4l-dvb-2daeefda69fe, so probably that = will be much more closer to the actual tree.=0A- Is there any way to submit= it for review?=0A=0AAbout your hints:=0A- you mean that static variables w= ill be an issue.=0ACould then be better to include those variables in dvb_u= sb_device_properties?=0A=0A- Yes, the register increment has no use. I can = remove it away.=0A=0A- I also got feedback that the debug information is no= t handled correctly in the driver.=0ACould you advice on that one?=0A=0AI a= m really no expert, I have just been following the examples.=0ABut since it= is working, it would be great if people could use the driver.=0A=0AJuan=0A= =0A----- Mensaje original ----=0ADe: Aidan Thornton =0APara: Juan Antonio Garcia =0ACC: Marku= s Rechberger ; Jakob Steidl ; li= nux-dvb@linuxtv.org=0AEnviado: viernes, 2 de mayo, 2008 12:24:07=0AAsunto: = Re: [linux-dvb] DVB driver for Pinnacle PCTV200e and PCTV60e=0A=0AOn Thu, M= ay 1, 2008 at 8:58 PM, Markus Rechberger wrote:=0A>= Hi,=0A>=0A>=0A> On 5/1/08, Juan Antonio Garcia wrote:=0A> >=0A> > Hi,=0A> >=0A> > I updated the driver for bein= g supported in kernel 2.6.24 (Ubuntu 8.04).=0A> >=0A> > I am distributing= the update thought the Ubuntu forums, but it would be=0A> > better to dis= tribute it to more users. So Linux has more HW supported.=0A> >=0A> > Wha= t it should be done so it is included in the v4l tree?=0A> >=0A>=0A> I fo= rwarded the mail to the linux-dvb ML.=0A>=0A> > Now the driver supports 2 = devices:=0A> >=0A> > - Pinnacle PCTV 200e=0A> > - Pinnacle PCTV 60e=0A> = >=0A> > The driver wiki is:=0A> >=0A> > http://www.linuxtv.org/wiki/ind= ex.php/Pinnacle_PCTV_200e=0A> >=0A>=0A> Markus=0A=0AHi,=0A=0AThis driver = seems like it should be trivial to get working on=0Alinux-dvb, which is whe= re you want it - the tree you've based it on=0Aisn't much longer for this w= orld. (I don't think any of the code=0Ayou're using has changed significant= ly between Markus' branch and the=0Amain one). It needs some cleanup, thoug= h. At a glance:=0A=0A- Don't use C++-style comments (the single-line // one= s)=0A- The whole "addr =3D=3D pctv200e_mt2060_config.i2c_address" part look= s=0Aiffy; I think you should remove this and use i2c_gate_ctrl instead.=0AU= nfortunately, I'm not sure this'll work currently, since mt2060=0Adoesn't a= ppear to support it.=0A- ctrl_msg_last_device/ctrl_msg_last_operation must = go - they won't=0Awork right if you use multiple devices of this type. The = code in the=0A"if (ctrl_msg_last_device =3D=3D 0)" section can probably go = elsewhere,=0Abut I'm not sure where=0A- Why are you incrementing the regist= er value in pctv200e_ctrl_msg?=0A=0AThe linuxtv developers will probably be= able to give you more advice.=0A=0AAidan=0A=0A=0A=0A=0A=0A=0A _______= _______________________________________ =0AYahoo! Solidario. Intercambia lo= s objetos que ya no necesitas y ayuda a mantener un entorno m=C3=A1s ecol= =C3=B3gico. --0-1487326817-1209747776=:46111 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
Thanks for the hints.
=0A
=0AI made a driver = update yesterday for kernel 2.6.24 using the last v4l tree I got:
v4l-dv= b-2daeefda69fe, so probably that will be much more closer to the actual tre= e.
- Is there any way to submit it for review?

About your hints:<= br>- you mean that static variables will be an issue.
Could then be bett= er to include those variables in dvb_usb_device_properties?

- Yes, t= he register increment has no use. I can remove it away.

- I also got= feedback that the debug information is not handled correctly in the driver= .
Could you advice on that one?

I am really no expert, I have jus= t been following the examples.
But since it is working, it would be grea= t if people could use the driver.

Juan

----- Mensaje = original ----
De: Aidan Thornton <makosoft@googlemail.com>
Para= : Juan Antonio Garcia <juanantonio_garcia_01@yahoo.es>
CC: Markus Rechberger <mrechb= erger@gmail.com>; Jakob Steidl <j.steidl@liwest.at>; linux-dvb@lin= uxtv.org
Enviado: viernes, 2 de mayo, 2008 12:24:07
Asunto: Re: [linu= x-dvb] DVB driver for Pinnacle PCTV200e and PCTV60e

On Thu, May 1, 2= 008 at 8:58 PM, Markus Rechberger <mrechberger@gmail.com> = wrote:
> Hi,
>
>
>  On 5/1/08, Juan Antonio Ga= rcia <juanantonio_garcia_01@yahoo.es> wr= ote:
>  >
>  > Hi,
>  >
>&n= bsp; > I updated the driver for being supported in kernel 2.6.24 (Ubuntu= 8.04).
>  >
>  > I am distributing the update = thought the Ubuntu forums, but it would be
>  > better to distribute it to more users. So Linux has more HW supported.
> = >
>  > What it should be done so it is included in the v4= l tree?
>  >
>
>  I forwarded the mail to th= e linux-dvb ML.
>
>  > Now the driver supports 2 device= s:
>  >
>  > - Pinnacle PCTV 200e
> = > - Pinnacle PCTV 60e
>  >
>  > The driver = wiki is:
>  >
>  > http://www.linux= tv.org/wiki/index.php/Pinnacle_PCTV_200e
>  >
>
= >  Markus

Hi,

This driver seems like it should be tri= vial to get working on
linux-dvb, which is where you want it - the tree = you've based it on
isn't much longer for this world. (I don't think any = of the code
you're using has changed significantly between Markus' branch and the
main one). It needs some cleanup, though. At a glance:
- Don't use C++-style comments (the single-line // ones)
- The who= le "addr =3D=3D pctv200e_mt2060_config.i2c_address" part looks
iffy; I t= hink you should remove this and use i2c_gate_ctrl instead.
Unfortunately= , I'm not sure this'll work currently, since mt2060
doesn't appear to su= pport it.
- ctrl_msg_last_device/ctrl_msg_last_operation must go - they = won't
work right if you use multiple devices of this type. The code in t= he
"if (ctrl_msg_last_device =3D=3D 0)" section can probably go elsewher= e,
but I'm not sure where
- Why are you incrementing the register val= ue in pctv200e_ctrl_msg?

The linuxtv developers will probably be abl= e to give you more advice.

Aidan


=0A=0A= =0A=0A=0A=0A=0A

Yahoo! S= olidario.
Intercambia los objetos que ya no necesitas y ayuda a mant= ener un entorno m=C3=A1s ecol=C3=B3gico.
--0-1487326817-1209747776=:46111-- --===============1181083220== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb --===============1181083220==--