From: "flichtenheld (Code Review)" Date: Mon, 12 Jan 2026 14:19:25 +0000 References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: <6927f293386f37439ef2badd02e25fc730b072b3-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="Js4y4pzC3Yc="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: socks: Fix wrong success check in socks_username_password_auth List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --Js4y4pzC3Yc= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1466?usp=3Demail to review the following change. Change subject: socks: Fix wrong success check in socks_username_password_a= uth ...................................................................... socks: Fix wrong success check in socks_username_password_auth Due to wrong boolean operator the function did not correctly detect when the authentication failed. Reported-By: Joshua Rogers Found-By: ZeroPath (https://zeropath.com) Github: openvpn-private-issues#4 Change-Id: I13b411fb3e8b913ae049c6ca8a1cf5a2edbab0fb Signed-off-by: Frank Lichtenheld --- M src/openvpn/socks.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/66/1466/1 diff --git a/src/openvpn/socks.c b/src/openvpn/socks.c index ed2d9e9..1e99c9a 100644 --- a/src/openvpn/socks.c +++ b/src/openvpn/socks.c @@ -143,7 +143,7 @@ } /* VER =3D 5, SUCCESS =3D 0 --> auth success */ - if (buf[0] !=3D 5 && buf[1] !=3D 0) + if (buf[0] !=3D 5 || buf[1] !=3D 0) { msg(D_LINK_ERRORS, "socks_username_password_auth: server refused t= he authentication"); goto cleanup; -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1466?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: newchange Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I13b411fb3e8b913ae049c6ca8a1cf5a2edbab0fb Gerrit-Change-Number: 1466 Gerrit-PatchSet: 1 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos --Js4y4pzC3Yc= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: plaisthos.

flichtenheld would like plaisthos to review this change.

V= iew Change

socks: Fix wrong success check in socks_use=
rname_password_auth

Due to wrong boolean operator the function did n= ot
correctly detect when the authentication failed.

Reported-By: = Joshua Rogers <contact@...2949...>
Found-By: ZeroPath (https://zer= opath.com)
Github: openvpn-private-issues#4
Change-Id: I13b411fb3e8b9= 13ae049c6ca8a1cf5a2edbab0fb
Signed-off-by: Frank Lichtenheld <frank@...220...= ..2641...>
---
M src/openvpn/socks.c
1 file changed, 1 insertio= n(+), 1 deletion(-)

git pull ssh://gerrit.openvp=
n.net:29418/openvpn refs/changes/66/1466/1
diff --git a/src/openvpn=
/socks.c b/src/openvpn/socks.c
index ed2d9e9..1e99c9a 10064= 4
--- a/src/openvpn/socks.c
+++ b/src/openv= pn/socks.c
@@ -143,7 +143,7 @@
}

/* VER =3D 5, SUCCESS =3D 0 --> auth s= uccess */
- if (buf[= 0] !=3D 5 && buf[1] !=3D 0)
+ if (buf[0] !=3D 5 || buf[1] !=3D 0)
= {
msg(D_LINK_ERRORS, "socks_username_passwo= rd_auth: server refused the authentication");
= goto cleanup;

To view, visit change 1466= . To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I13b411fb3e8b913ae049c6ca8a1= cf5a2edbab0fb
Gerrit-Change-Number: 1466
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
= --Js4y4pzC3Yc=--