From: Tom St Denis Subject: Re: [PATCH 1/2] drm/amdgpu/gfx9: allocate queues horizontally across pipes Date: Tue, 6 Jun 2017 07:43:02 -0400 Message-ID: <692d3fb2-98de-0e11-d8bc-e255cc07b605@amd.com> References: <1496675193-4963-1-git-send-email-alexander.deucher@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1496675193-4963-1-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Rmlyc3QgaXMgUmV2aWV3ZWQtYnk6IFRvbSBTdCBEZW5pcyA8dG9tLnN0ZGVuaXNAYW1kLmNvbT4g YW5kIHNlY29uZCBpcyAKQWNrZWQtYnkuCgpDaGVlcnMsClRvbQoKT24gMDUvMDYvMTcgMTE6MDYg QU0sIEFsZXggRGV1Y2hlciB3cm90ZToKPiBQaXBlcyBwcm92aWRlIGJldHRlciBjb25jdXJyZW5j eSB0aGFuIHF1ZXVlcywgdGhlcmVmb3JlIHdlIHdhbnQgdG8gbWFrZQo+IHN1cmUgdGhhdCBhcHBz IHVzZSBxdWV1ZXMgZnJvbSBkaWZmZXJlbnQgcGlwZXMgd2hlbmV2ZXIgcG9zc2libGUuCj4gCj4g T3B0aW1pemUgZm9yIHRoZSB0cml2aWFsIGNhc2Ugd2hlcmUgYW4gYXBwIHdpbGwgY29uc3VtZSBy aW5ncyBpbiBvcmRlciwKPiB0aGVyZWZvcmUgd2UgZG9uJ3Qgd2FudCBhZGphY2VudCByaW5ncyB0 byBiZWxvbmcgdG8gdGhlIHNhbWUgcGlwZS4KPiAKPiBnZng5IHdhcyBtaXNzZWQgd2hlbiB0aGVz ZSBwYXRjaGVzIHdlcmUgcmViYXNlZC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBBbGV4IERldWNoZXIg PGFsZXhhbmRlci5kZXVjaGVyQGFtZC5jb20+Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vYW1k L2FtZGdwdS9nZnhfdjlfMC5jIHwgMTE1ICsrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0t LS0KPiAgIDEgZmlsZSBjaGFuZ2VkLCA1MiBpbnNlcnRpb25zKCspLCA2MyBkZWxldGlvbnMoLSkK PiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvZ2Z4X3Y5XzAuYyBi L2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2dmeF92OV8wLmMKPiBpbmRleCA5NTAyMzUzLi4w YzQ4ZjZjIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2dmeF92OV8w LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9nZnhfdjlfMC5jCj4gQEAgLTE0 ODMsOSArMTQ4Myw0NCBAQCBzdGF0aWMgaW50IGdmeF92OV8wX25nZ19lbihzdHJ1Y3QgYW1kZ3B1 X2RldmljZSAqYWRldikKPiAgIAlyZXR1cm4gMDsKPiAgIH0KPiAgIAo+ICtzdGF0aWMgaW50IGdm eF92OV8wX2NvbXB1dGVfcmluZ19pbml0KHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2LCBpbnQg cmluZ19pZCwKPiArCQkJCSAgICAgIGludCBtZWMsIGludCBwaXBlLCBpbnQgcXVldWUpCj4gK3sK PiArCWludCByOwo+ICsJdW5zaWduZWQgaXJxX3R5cGU7Cj4gKwlzdHJ1Y3QgYW1kZ3B1X3Jpbmcg KnJpbmcgPSAmYWRldi0+Z2Z4LmNvbXB1dGVfcmluZ1tyaW5nX2lkXTsKPiArCj4gKwlyaW5nID0g JmFkZXYtPmdmeC5jb21wdXRlX3JpbmdbcmluZ19pZF07Cj4gKwo+ICsJLyogbWVjMCBpcyBtZTEg Ki8KPiArCXJpbmctPm1lID0gbWVjICsgMTsKPiArCXJpbmctPnBpcGUgPSBwaXBlOwo+ICsJcmlu Zy0+cXVldWUgPSBxdWV1ZTsKPiArCj4gKwlyaW5nLT5yaW5nX29iaiA9IE5VTEw7Cj4gKwlyaW5n LT51c2VfZG9vcmJlbGwgPSB0cnVlOwo+ICsJcmluZy0+ZG9vcmJlbGxfaW5kZXggPSBBTURHUFVf RE9PUkJFTExfTUVDX1JJTkcwICsgcmluZ19pZDsKPiArCXJpbmctPmVvcF9ncHVfYWRkciA9IGFk ZXYtPmdmeC5tZWMuaHBkX2VvcF9ncHVfYWRkcgo+ICsJCQkJKyAocmluZ19pZCAqIEdGWDlfTUVD X0hQRF9TSVpFKTsKPiArCXNwcmludGYocmluZy0+bmFtZSwgImNvbXBfJWQuJWQuJWQiLCByaW5n LT5tZSwgcmluZy0+cGlwZSwgcmluZy0+cXVldWUpOwo+ICsKPiArCWlycV90eXBlID0gQU1ER1BV X0NQX0lSUV9DT01QVVRFX01FQzFfUElQRTBfRU9QCj4gKwkJKyAoKHJpbmctPm1lIC0gMSkgKiBh ZGV2LT5nZngubWVjLm51bV9waXBlX3Blcl9tZWMpCj4gKwkJKyByaW5nLT5waXBlOwo+ICsKPiAr CS8qIHR5cGUtMiBwYWNrZXRzIGFyZSBkZXByZWNhdGVkIG9uIE1FQywgdXNlIHR5cGUtMyBpbnN0 ZWFkICovCj4gKwlyID0gYW1kZ3B1X3JpbmdfaW5pdChhZGV2LCByaW5nLCAxMDI0LAo+ICsJCQkg ICAgICZhZGV2LT5nZnguZW9wX2lycSwgaXJxX3R5cGUpOwo+ICsJaWYgKHIpCj4gKwkJcmV0dXJu IHI7Cj4gKwo+ICsKPiArCXJldHVybiAwOwo+ICt9Cj4gKwo+ICAgc3RhdGljIGludCBnZnhfdjlf MF9zd19pbml0KHZvaWQgKmhhbmRsZSkKPiAgIHsKPiAtCWludCBpLCByLCByaW5nX2lkOwo+ICsJ aW50IGksIGosIGssIHIsIHJpbmdfaWQ7Cj4gICAJc3RydWN0IGFtZGdwdV9yaW5nICpyaW5nOwo+ ICAgCXN0cnVjdCBhbWRncHVfa2lxICpraXE7Cj4gICAJc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFk ZXYgPSAoc3RydWN0IGFtZGdwdV9kZXZpY2UgKiloYW5kbGU7Cj4gQEAgLTE1NDcsNjkgKzE1ODIs MjMgQEAgc3RhdGljIGludCBnZnhfdjlfMF9zd19pbml0KHZvaWQgKmhhbmRsZSkKPiAgIAkJCXJl dHVybiByOwo+ICAgCX0KPiAgIAo+IC0JLyogc2V0IHVwIHRoZSBjb21wdXRlIHF1ZXVlcyAqLwo+ IC0JZm9yIChpID0gMCwgcmluZ19pZCA9IDA7IGkgPCBBTURHUFVfTUFYX0NPTVBVVEVfUVVFVUVT OyBpKyspIHsKPiAtCQl1bnNpZ25lZCBpcnFfdHlwZTsKPiAtCj4gLQkJaWYgKCF0ZXN0X2JpdChp LCBhZGV2LT5nZngubWVjLnF1ZXVlX2JpdG1hcCkpCj4gLQkJCWNvbnRpbnVlOwo+IC0KPiAtCQlp ZiAoV0FSTl9PTihyaW5nX2lkID49IEFNREdQVV9NQVhfQ09NUFVURV9SSU5HUykpCj4gLQkJCWJy ZWFrOwo+IC0KPiAtCQlyaW5nID0gJmFkZXYtPmdmeC5jb21wdXRlX3JpbmdbcmluZ19pZF07Cj4g LQo+IC0JCS8qIG1lYzAgaXMgbWUxICovCj4gLQkJcmluZy0+bWUgPSAoKGkgLyBhZGV2LT5nZngu bWVjLm51bV9xdWV1ZV9wZXJfcGlwZSkKPiAtCQkJCS8gYWRldi0+Z2Z4Lm1lYy5udW1fcGlwZV9w ZXJfbWVjKQo+IC0JCQkJKyAxOwo+IC0JCXJpbmctPnBpcGUgPSAoaSAvIGFkZXYtPmdmeC5tZWMu bnVtX3F1ZXVlX3Blcl9waXBlKQo+IC0JCQkJJSBhZGV2LT5nZngubWVjLm51bV9waXBlX3Blcl9t ZWM7Cj4gLQkJcmluZy0+cXVldWUgPSBpICUgYWRldi0+Z2Z4Lm1lYy5udW1fcXVldWVfcGVyX3Bp cGU7Cj4gLQo+IC0JCXJpbmctPnJpbmdfb2JqID0gTlVMTDsKPiAtCQlyaW5nLT51c2VfZG9vcmJl bGwgPSB0cnVlOwo+IC0JCXJpbmctPmVvcF9ncHVfYWRkciA9IGFkZXYtPmdmeC5tZWMuaHBkX2Vv cF9ncHVfYWRkciArIChyaW5nX2lkICogR0ZYOV9NRUNfSFBEX1NJWkUpOwo+IC0JCXJpbmctPmRv b3JiZWxsX2luZGV4ID0gQU1ER1BVX0RPT1JCRUxMX01FQ19SSU5HMCArIHJpbmdfaWQ7Cj4gLQkJ c3ByaW50ZihyaW5nLT5uYW1lLCAiY29tcF8lZC4lZC4lZCIsIHJpbmctPm1lLCByaW5nLT5waXBl LCByaW5nLT5xdWV1ZSk7Cj4gLQo+IC0JCWlycV90eXBlID0gQU1ER1BVX0NQX0lSUV9DT01QVVRF X01FQzFfUElQRTBfRU9QCj4gLQkJCSsgKChyaW5nLT5tZSAtIDEpICogYWRldi0+Z2Z4Lm1lYy5u dW1fcGlwZV9wZXJfbWVjKQo+IC0JCQkrIHJpbmctPnBpcGU7Cj4gLQo+IC0JCS8qIHR5cGUtMiBw YWNrZXRzIGFyZSBkZXByZWNhdGVkIG9uIE1FQywgdXNlIHR5cGUtMyBpbnN0ZWFkICovCj4gLQkJ ciA9IGFtZGdwdV9yaW5nX2luaXQoYWRldiwgcmluZywgMTAyNCwgJmFkZXYtPmdmeC5lb3BfaXJx LAo+IC0JCQkJICAgICBpcnFfdHlwZSk7Cj4gLQkJaWYgKHIpCj4gLQkJCXJldHVybiByOwo+IC0K PiAtCQlyaW5nX2lkKys7Cj4gLQl9Cj4gLQo+IC0JLyogc2V0IHVwIHRoZSBjb21wdXRlIHF1ZXVl cyAqLwo+IC0JZm9yIChpID0gMCwgcmluZ19pZCA9IDA7IGkgPCBBTURHUFVfTUFYX0NPTVBVVEVf UVVFVUVTOyBpKyspIHsKPiAtCQl1bnNpZ25lZCBpcnFfdHlwZTsKPiAtCj4gLQkJLyogbWF4IDMy IHF1ZXVlcyBwZXIgTUVDICovCj4gLQkJaWYgKChpID49IDMyKSB8fCAoaSA+PSBBTURHUFVfTUFY X0NPTVBVVEVfUklOR1MpKSB7Cj4gLQkJCURSTV9FUlJPUigiVG9vIG1hbnkgKCVkKSBjb21wdXRl IHJpbmdzIVxuIiwgaSk7Cj4gLQkJCWJyZWFrOwo+ICsJLyogc2V0IHVwIHRoZSBjb21wdXRlIHF1 ZXVlcyAtIGFsbG9jYXRlIGhvcml6b250YWxseSBhY3Jvc3MgcGlwZXMgKi8KPiArCXJpbmdfaWQg PSAwOwo+ICsJZm9yIChpID0gMDsgaSA8IGFkZXYtPmdmeC5tZWMubnVtX21lYzsgKytpKSB7Cj4g KwkJZm9yIChqID0gMDsgaiA8IGFkZXYtPmdmeC5tZWMubnVtX3F1ZXVlX3Blcl9waXBlOyBqKysp IHsKPiArCQkJZm9yIChrID0gMDsgayA8IGFkZXYtPmdmeC5tZWMubnVtX3BpcGVfcGVyX21lYzsg aysrKSB7Cj4gKwkJCQlpZiAoIWFtZGdwdV9pc19tZWNfcXVldWVfZW5hYmxlZChhZGV2LCBpLCBr LCBqKSkKPiArCQkJCQljb250aW51ZTsKPiArCj4gKwkJCQlyID0gZ2Z4X3Y5XzBfY29tcHV0ZV9y aW5nX2luaXQoYWRldiwKPiArCQkJCQkJCSAgICAgICByaW5nX2lkLAo+ICsJCQkJCQkJICAgICAg IGksIGssIGopOwo+ICsJCQkJaWYgKHIpCj4gKwkJCQkJcmV0dXJuIHI7Cj4gKwo+ICsJCQkJcmlu Z19pZCsrOwo+ICsJCQl9Cj4gICAJCX0KPiAtCQlyaW5nID0gJmFkZXYtPmdmeC5jb21wdXRlX3Jp bmdbaV07Cj4gLQkJcmluZy0+cmluZ19vYmogPSBOVUxMOwo+IC0JCXJpbmctPnVzZV9kb29yYmVs bCA9IHRydWU7Cj4gLQkJcmluZy0+ZG9vcmJlbGxfaW5kZXggPSAoQU1ER1BVX0RPT1JCRUxMNjRf TUVDX1JJTkcwICsgaSkgPDwgMTsKPiAtCQlyaW5nLT5tZSA9IDE7IC8qIGZpcnN0IE1FQyAqLwo+ IC0JCXJpbmctPnBpcGUgPSBpIC8gODsKPiAtCQlyaW5nLT5xdWV1ZSA9IGkgJSA4Owo+IC0JCXJp bmctPmVvcF9ncHVfYWRkciA9IGFkZXYtPmdmeC5tZWMuaHBkX2VvcF9ncHVfYWRkciArIChpICog R0ZYOV9NRUNfSFBEX1NJWkUpOwo+IC0JCXNwcmludGYocmluZy0+bmFtZSwgImNvbXBfJWQuJWQu JWQiLCByaW5nLT5tZSwgcmluZy0+cGlwZSwgcmluZy0+cXVldWUpOwo+IC0JCWlycV90eXBlID0g QU1ER1BVX0NQX0lSUV9DT01QVVRFX01FQzFfUElQRTBfRU9QICsgcmluZy0+cGlwZTsKPiAtCQkv KiB0eXBlLTIgcGFja2V0cyBhcmUgZGVwcmVjYXRlZCBvbiBNRUMsIHVzZSB0eXBlLTMgaW5zdGVh ZCAqLwo+IC0JCXIgPSBhbWRncHVfcmluZ19pbml0KGFkZXYsIHJpbmcsIDEwMjQsCj4gLQkJCQkg ICAgICZhZGV2LT5nZnguZW9wX2lycSwgaXJxX3R5cGUpOwo+IC0JCWlmIChyKQo+IC0JCQlyZXR1 cm4gcjsKPiAgIAl9Cj4gICAKPiAgIAlyID0gZ2Z4X3Y5XzBfa2lxX2luaXQoYWRldik7Cj4gCgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwphbWQtZ2Z4IG1h aWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngK