From: Guoqing Jiang Subject: Re: [PATCH 1/6] md: switch to ->check_events for media change notifications Date: Wed, 8 Jul 2020 15:36:40 +0200 Message-ID: <69412063-07eb-ddd1-2fee-2d3e1258cecf@cloud.ionos.com> References: <20200708122546.214579-1-hch@lst.de> <20200708122546.214579-2-hch@lst.de> <09cd4827-52ae-0e7c-c3d3-e9a6cd27ff2b@cloud.ionos.com> <20200708132338.GO25523@casper.infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20200708132338.GO25523@casper.infradead.org> Content-Language: en-US Sender: linux-block-owner@vger.kernel.org To: Matthew Wilcox Cc: Christoph Hellwig , Jens Axboe , Song Liu , Ulf Hansson , linux-kernel@vger.kernel.org, linux-xtensa@linux-xtensa.org, linux-block@vger.kernel.org, linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org, linux-fsdevel@vger.kernel.org List-Id: linux-raid.ids On 7/8/20 3:23 PM, Matthew Wilcox wrote: > On Wed, Jul 08, 2020 at 03:17:31PM +0200, Guoqing Jiang wrote: >> On 7/8/20 2:25 PM, Christoph Hellwig wrote: >>> -static int md_media_changed(struct gendisk *disk) >>> -{ >>> - struct mddev *mddev = disk->private_data; >>> - >>> - return mddev->changed; >>> -} >> Maybe we can remove "changed" from struct mddev since no one reads it >> after the change. > You missed this hunk: > > +static unsigned int md_check_events(struct gendisk *disk, unsigned int clearing) > { > struct mddev *mddev = disk->private_data; > + unsigned int ret = 0; > > + if (mddev->changed) > + ret = DISK_EVENT_MEDIA_CHANGE; > mddev->changed = 0; > - return 0; > + return ret; > } > Yes, sorry for the noise. Thanks, Guoqing