From: Ron Madrid Date: Thu, 29 Jan 2009 09:28:44 -0800 (PST) Subject: [U-Boot] [PATCH] Exclude certain ns16550 functions from NAND_SPL builds In-Reply-To: <20090129102451.C1DB5832E416@gemini.denx.de> Message-ID: <697520.19982.qm@web83507.mail.sp1.yahoo.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de --- On Thu, 1/29/09, Wolfgang Denk wrote: > From: Wolfgang Denk > Subject: Re: [U-Boot] [PATCH] Exclude certain ns16550 functions from NAND_SPL builds > To: "Ron Madrid" > Cc: u-boot at lists.denx.de > Date: Thursday, January 29, 2009, 2:24 AM > Dear Ron Madrid, > > In message > <1233187331-20244-1-git-send-email-ron_madrid@sbcglobal.net> > you wrote: > > This patch will exclude all functions from > drivers/serial/ns16550.c from > > NAND_SPL builds with exception of NS16550_putc and > NS16550_init. This will save > > space and remove unused code from already tightly > constrained bootstrap images > > for NAND_SPL builds. > > > > Signed-off-by: Ron Madrid > > > --- > > drivers/serial/ns16550.c | 5 ++++- > > 1 files changed, 4 insertions(+), 1 deletions(-) > > This is a global file, so maybe we could use a less > specific #define > than CONFIG_NAND_SPL for this? Eventually we need this > later to boot > from device FOO, and I don't want to see this grow into > > if !defined(CONFIG_NAND_SPL) && > !defined(CONFIG_FOO) && !defined(CONFIG_BAR) > && ... I understand your concern. I am not sure what other #define would work. Are you suggesting the creation of a new #define such as #define CONFIG_NS16550_BASIC_OPS or something like that which can be put into the board specific config files? Ron