References: <20181007150413.1455-1-a@...2181...> <20200422092607.16050-1-a@...2181...> From: Antonio Quartulli Message-ID: <69990cda-fe76-3cf6-e0fd-f94baffe203b@...2181...> Date: Mon, 27 Apr 2020 09:58:16 +0200 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Subject: Re: [Openvpn-devel] [PATCH v9] convert *_inline attributes to bool List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: Arne Schwabe , openvpn-devel@lists.sourceforge.net Hi, On 27/04/2020 03:57, Arne Schwabe wrote: > Am 22.04.20 um 11:26 schrieb Antonio Quartulli: >> Carrying around the INLINE_TAG is not really efficient, >> because it requires a strcmp() to be performed every >> time we want to understand if the data is stored inline >> or not. >> >> Convert all the *_inline attributes to bool to make the >> logic easier and checks more efficient. >> > > Look through it. It is only a minor improvement but Antonio has been > persistent enough and spend enough time to make 9 versions of this so I > took the time to look through it: > > Acked-By: Arne Schwabe > > The patch is not uncrustify clean at the moment. So uncrustify should be > run on commit or we need a v10 of this patch. > > The patch does not apply cleanly anymore: The test_tls_crypt.c part > should be now. I can send v10 with these adjustments. Thanks for the review! -- Antonio Quartulli