From: "cron2 (Code Review)" Date: Fri, 24 Jan 2025 12:47:14 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., gianmarco@...2726..., openvpn-devel@lists.sourceforge.net, frank@...2641..., a@...2181... Message-ID: <69aa11844bea7648682fb8b1377b09dbc9fb2a9c-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="TK4d6rES0Yw="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: mroute: adapt to new protocol handling and hashing improvements List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: its_Giaan Cc: plaisthos , flichtenheld , openvpn-devel --TK4d6rES0Yw= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, its_Giaan, ordex, plais= thos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/765?usp=3Demail ) Change subject: mroute: adapt to new protocol handling and hashing improvem= ents ...................................................................... Patch Set 15: Code-Review-1 (3 comments) Patchset: PS15: Upgrade to -1 ;-) - mostly this is fine, but we still lost a "const" argume= nt, and there is a spurious blank line removal File src/openvpn/multi.c: http://gerrit.openvpn.net/c/openvpn/+/765/comment/6724d969_5ff543ed : PS15, Line 3413: spurious deletion of this blank line? don't :-) http://gerrit.openvpn.net/c/openvpn/+/765/comment/ee36f236_30cdf224 : PS15, Line 1156: struct mroute_addr *add= r, please bring the "const" back... -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/765?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ic66eccb5058fe9c0fae64d8e2ca88728068a92ab Gerrit-Change-Number: 765 Gerrit-PatchSet: 15 Gerrit-Owner: its_Giaan Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-CC: ordex Gerrit-Attention: plaisthos Gerrit-Attention: its_Giaan Gerrit-Attention: flichtenheld Gerrit-Attention: ordex Gerrit-Comment-Date: Fri, 24 Jan 2025 12:47:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --TK4d6rES0Yw= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, its_Giaan, ordex, p= laisthos.

Patch set 15:Code-Review -1

V= iew Change

3 comments:

  • Patchset:

    • Patch Set #15:

      Upgrade to -1 ;-) - mostly this is fine, bu= t we still lost a "const" argument, and there is a spurious blank= line removal

  • Fil= e src/openvpn/multi.c:

    • <= a href=3D"http://gerrit.openvpn.net/c/openvpn/+/765/comment/6724d969_5ff543= ed">Patch Set #15, Line 3413:

      Pa= tch Set #15, Line 1156: struct mroute_addr *addr,

      please bring the &q= uot;const" back...

To view, visit change 765. To = unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ic66eccb5058fe9c0fae64d8e2ca= 88728068a92ab
Gerrit-Change-Number: 765
Gerrit-PatchSet: 15
Gerrit-Owner: its_Giaan <gianmarco@...2786...= ..>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-CC: ordex <a@...2181...>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: its_Giaan <gianmarco@...1665...= 726...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Attention: ordex <a@...2181...> <= /div>
Gerrit-Comment-Date: Fri, 24 Jan 2025 12:47:14= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--TK4d6rES0Yw=--