From: Michel Thierry Subject: Re: [PATCH] drm/i915/icl: Use hw engine class, instance to find irq handler Date: Mon, 12 Mar 2018 15:47:28 -0700 Message-ID: <69de63c7-9b23-1817-0aa4-a055cb86fd99@intel.com> References: <20180312143308.20157-1-mika.kuoppala@linux.intel.com> <20180312144131.20629-1-mika.kuoppala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 092A26E244 for ; Mon, 12 Mar 2018 22:47:28 +0000 (UTC) In-Reply-To: <20180312144131.20629-1-mika.kuoppala@linux.intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Mika Kuoppala , "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org SGksCgpPbiAzLzEyLzIwMTggNzo0MSBBTSwgTWlrYSBLdW9wcGFsYSB3cm90ZToKPiBJbnRlcnJ1 cHQgaWRlbnRpdHkgcmVnaXN0ZXIgd2UgYWxyZWFkeSByZWFkIGZyb20gaGFyZHdhcmUKPiBjb250 YWlucyBlbmdpbmUgY2xhc3MgYW5kIGluc3RhbmNlIGZpZWxkcy4gTGV2ZXJhZ2UKPiB0aGVzZSBm aWVsZHMgdG8gZmluZCBjb3JyZWN0IGVuZ2luZSB0byBoYW5kbGUgdGhlIGludGVycnVwdC4KPiAK PiBhZGQvcmVtb3ZlOiAwLzAgZ3Jvdy9zaHJpbms6IDAvMSB1cC9kb3duOiAwLy0xNjAgKC0xNjAp Cj4gRnVuY3Rpb24gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgb2xkICAgICBu ZXcgICBkZWx0YQo+IGdlbjExX2lycV9oYW5kbGVyICAgICAgICAgICAgICAgICAgICAgICAgICAg IDc2NCAgICAgNjA0ICAgIC0xNjAKPiBUb3RhbDogQmVmb3JlPTE1MDY5NTMsIEFmdGVyPTE1MDY3 OTMsIGNoZyAtMC4wMSUKPiAKPiB2MjogaGFuZGxlIGNsYXNzL2luc3RhbmNlIG92ZXJmbG93IGNv cnJlY3RseSAoTWlrYSkKPiAKPiBTdWdnZXN0ZWQtYnk6IERhbmllbGUgQ2VyYW9sbyBTcHVyaW8g PGRhbmllbGUuY2VyYW9sb3NwdXJpb0BpbnRlbC5jb20+Cj4gQ2M6IERhbmllbGUgQ2VyYW9sbyBT cHVyaW8gPGRhbmllbGUuY2VyYW9sb3NwdXJpb0BpbnRlbC5jb20+Cj4gQ2M6IENocmlzIFdpbHNv biA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IENjOiBUdnJ0a28gVXJzdWxpbiA8dHZydGtv LnVyc3VsaW5AaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IE1pa2EgS3VvcHBhbGEgPG1pa2Eu a3VvcHBhbGFAbGludXguaW50ZWwuY29tPgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9pcnEuYyB8IDY0ICsrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t Cj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oIHwgIDIgKysKPiAgIDIgZmlsZXMg Y2hhbmdlZCwgMjMgaW5zZXJ0aW9ucygrKSwgNDMgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pOTE1X2lycS5jCj4gaW5kZXggODI4ZjMxMDQ0ODhjLi40OTgxNmQwYTM4MGIgMTAwNjQ0Cj4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfaXJxLmMKPiBAQCAtMjczMyw0NyArMjczMyw5IEBAIHN0YXRpYyB2b2lk IF9fZmluaV93ZWRnZShzdHJ1Y3Qgd2VkZ2VfbWUgKncpCj4gICAJICAgICAoVyktPmk5MTU7CQkJ CQkJCVwKPiAgIAkgICAgIF9fZmluaV93ZWRnZSgoVykpKQo+ICAgCj4gLXN0YXRpYyB2b2lkCj4g LWdlbjExX2d0X2VuZ2luZV9pcnFfaGFuZGxlcihzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqIGNv bnN0IGk5MTUsCj4gLQkJCSAgICBjb25zdCB1bnNpZ25lZCBpbnQgYmFuaywKPiAtCQkJICAgIGNv bnN0IHVuc2lnbmVkIGludCBlbmdpbmVfbiwKPiAtCQkJICAgIGNvbnN0IHUxNiBpaXIpCj4gLXsK PiAtCXN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKiogY29uc3QgZW5naW5lID0gaTkxNS0+ZW5naW5l Owo+IC0KPiAtCXN3aXRjaCAoYmFuaykgewo+IC0JY2FzZSAwOgo+IC0JCXN3aXRjaCAoZW5naW5l X24pIHsKPiAtCj4gLQkJY2FzZSBHRU4xMV9SQ1MwOgo+IC0JCQlyZXR1cm4gZ2VuOF9jc19pcnFf aGFuZGxlcihlbmdpbmVbUkNTXSwgaWlyKTsKPiAtCj4gLQkJY2FzZSBHRU4xMV9CQ1M6Cj4gLQkJ CXJldHVybiBnZW44X2NzX2lycV9oYW5kbGVyKGVuZ2luZVtCQ1NdLCBpaXIpOwo+IC0JCX0KPiAt CWNhc2UgMToKPiAtCQlzd2l0Y2ggKGVuZ2luZV9uKSB7Cj4gLQo+IC0JCWNhc2UgR0VOMTFfVkNT KDApOgo+IC0JCQlyZXR1cm4gZ2VuOF9jc19pcnFfaGFuZGxlcihlbmdpbmVbX1ZDUygwKV0sIGlp cik7Cj4gLQkJY2FzZSBHRU4xMV9WQ1MoMSk6Cj4gLQkJCXJldHVybiBnZW44X2NzX2lycV9oYW5k bGVyKGVuZ2luZVtfVkNTKDEpXSwgaWlyKTsKPiAtCQljYXNlIEdFTjExX1ZDUygyKToKPiAtCQkJ cmV0dXJuIGdlbjhfY3NfaXJxX2hhbmRsZXIoZW5naW5lW19WQ1MoMildLCBpaXIpOwo+IC0JCWNh c2UgR0VOMTFfVkNTKDMpOgo+IC0JCQlyZXR1cm4gZ2VuOF9jc19pcnFfaGFuZGxlcihlbmdpbmVb X1ZDUygzKV0sIGlpcik7Cj4gLQo+IC0JCWNhc2UgR0VOMTFfVkVDUygwKToKPiAtCQkJcmV0dXJu IGdlbjhfY3NfaXJxX2hhbmRsZXIoZW5naW5lW19WRUNTKDApXSwgaWlyKTsKPiAtCQljYXNlIEdF TjExX1ZFQ1MoMSk6Cj4gLQkJCXJldHVybiBnZW44X2NzX2lycV9oYW5kbGVyKGVuZ2luZVtfVkVD UygxKV0sIGlpcik7Cj4gLQkJfQo+IC0JfQo+IC19Cj4gLQo+ICAgc3RhdGljIHUzMgo+IC1nZW4x MV9ndF9lbmdpbmVfaW50cihzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqIGNvbnN0IGk5MTUsCj4g LQkJICAgICBjb25zdCB1bnNpZ25lZCBpbnQgYmFuaywgY29uc3QgdW5zaWduZWQgaW50IGJpdCkK PiArZ2VuMTFfZ3RfZW5naW5lX2lkZW50aXR5KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICogY29u c3QgaTkxNSwKPiArCQkJIGNvbnN0IHVuc2lnbmVkIGludCBiYW5rLCBjb25zdCB1bnNpZ25lZCBp bnQgYml0KQo+ICAgewo+ICAgCXZvaWQgX19pb21lbSAqIGNvbnN0IHJlZ3MgPSBpOTE1LT5yZWdz Owo+ICAgCXUzMiB0aW1lb3V0X3RzOwo+IEBAIC0yODAwLDcgKzI3NjIsNyBAQCBnZW4xMV9ndF9l bmdpbmVfaW50cihzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqIGNvbnN0IGk5MTUsCj4gICAJcmF3 X3JlZ193cml0ZShyZWdzLCBHRU4xMV9JTlRSX0lERU5USVRZX1JFRyhiYW5rKSwKPiAgIAkJICAg ICAgR0VOMTFfSU5UUl9EQVRBX1ZBTElEKTsKPiAgIAo+IC0JcmV0dXJuIGlkZW50ICYgR0VOMTFf SU5UUl9FTkdJTkVfTUFTSzsKPiArCXJldHVybiBpZGVudDsKPiAgIH0KPiAgIAo+ICAgc3RhdGlj IHZvaWQKPiBAQCAtMjgyNSwxMiArMjc4NywyOCBAQCBnZW4xMV9ndF9pcnFfaGFuZGxlcihzdHJ1 Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqIGNvbnN0IGk5MTUsCj4gICAJCX0KPiAgIAo+ICAgCQlmb3Jf ZWFjaF9zZXRfYml0KGJpdCwgJmludHJfZHcsIDMyKSB7Cj4gLQkJCWNvbnN0IHUxNiBpaXIgPSBn ZW4xMV9ndF9lbmdpbmVfaW50cihpOTE1LCBiYW5rLCBiaXQpOwo+ICsJCQljb25zdCB1MzIgaWRl bnQgPSBnZW4xMV9ndF9lbmdpbmVfaWRlbnRpdHkoaTkxNSwKPiArCQkJCQkJCQkgICBiYW5rLCBi aXQpOwo+ICsJCQljb25zdCB1MTYgaWlyID0gaWRlbnQgJiBHRU4xMV9JTlRSX0VOR0lORV9NQVNL Owo+ICsJCQl1OCBjbGFzcywgaW5zdGFuY2U7Cj4gKwkJCXN0cnVjdCBpbnRlbF9lbmdpbmVfY3Mg KmVuZ2luZTsKPiAgIAo+ICAgCQkJaWYgKHVubGlrZWx5KCFpaXIpKQo+ICAgCQkJCWNvbnRpbnVl Owo+ICAgCj4gLQkJCWdlbjExX2d0X2VuZ2luZV9pcnFfaGFuZGxlcihpOTE1LCBiYW5rLCBiaXQs IGlpcik7Cj4gKwkJCWNsYXNzID0gR0VOMTFfSU5UUl9FTkdJTkVfQ0xBU1MoaWRlbnQpOwo+ICsJ CQlpZiAodW5saWtlbHkoY2xhc3MgPj0gTUFYX0VOR0lORV9DTEFTUykpCgpNQVhfRU5HSU5FX0NM QVNTIHBvaW50cyB0byB0aGUgbGFzdCBDTEFTUywgc28gdGhpcyBzaG91bGQgYmUKCglpZiAodW5s aWtlbHkoY2xhc3MgPiBNQVhfRU5HSU5FX0NMQVNTKSkKCmFzIHlvdSBvcmlnaW5hbGx5IGhhZCBp biB0aGUgdjEgb2YgdGhpcyBwYXRjaC4KKEd1QyBpbnRlcnJ1cHRzIHdpbGwgYmUgcmVwb3J0ZWQg d2l0aCBjbGFzcyA9IE9USEVSX0NMQVNTKS4KCj4gKwkJCQljb250aW51ZTsKPiArCj4gKwkJCWlu c3RhbmNlID0gR0VOMTFfSU5UUl9FTkdJTkVfSU5TVEFOQ0UoaWRlbnQpOwo+ICsJCQlpZiAodW5s aWtlbHkoaW5zdGFuY2UgPj0gTUFYX0VOR0lORV9JTlNUQU5DRSkpCj4gKwkJCQljb250aW51ZTsK PiArCgpTYW1lIGhlcmUsIE1BWF9FTkdJTkVfSU5TVEFOQ0UgaXMgaW5jbHVzaXZlIHRvby4KClRo YXQncyB3aHkgd2UgaGF2ZSB0aGUgR0VNX1dBUk5fT04ncyBpbiBpbnRlbF9lbmdpbmVfc2V0dXAo KS4KCj4gKwkJCWVuZ2luZSA9IGk5MTUtPmVuZ2luZV9jbGFzc1tjbGFzc11baW5zdGFuY2VdOwo+ ICsJCQlpZiAodW5saWtlbHkoIWVuZ2luZSkpCj4gKwkJCQljb250aW51ZTsKPiArCj4gKwkJCWdl bjhfY3NfaXJxX2hhbmRsZXIoZW5naW5lLCBpaXIpOwo+ICAgCQl9Cj4gICAKPiAgIAkJLyogQ2xl YXIgbXVzdCBiZSBhZnRlciBzaGFyZWQgaGFzIGJlZW4gc2VydmVkIGZvciBlbmdpbmUgKi8KPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaCBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfcmVnLmgKPiBpbmRleCBlNmE4YzBlZTdkZjEuLjA2NTgyNTI5MDQ4MiAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oCj4gKysrIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaAo+IEBAIC03MTE4LDYgKzcxMTgsOCBAQCBlbnVt IHsKPiAgICNkZWZpbmUgR0VOMTFfSU5UUl9JREVOVElUWV9SRUcxCV9NTUlPKDB4MTkwMDY0KQo+ ICAgI2RlZmluZSAgR0VOMTFfSU5UUl9EQVRBX1ZBTElECQkoMSA8PCAzMSkKPiAgICNkZWZpbmUg IEdFTjExX0lOVFJfRU5HSU5FX01BU0sJCSgweGZmZmYpCj4gKyNkZWZpbmUgIEdFTjExX0lOVFJf RU5HSU5FX0NMQVNTKHgpCSgoKHgpICYgR0VOTUFTSygxOCwgMTYpKSA+PiAxNikKPiArI2RlZmlu ZSAgR0VOMTFfSU5UUl9FTkdJTkVfSU5TVEFOQ0UoeCkJKCgoeCkgJiBHRU5NQVNLKDI1LCAyMCkp ID4+IDIwKQo+ICAgCj4gICAjZGVmaW5lIEdFTjExX0lOVFJfSURFTlRJVFlfUkVHKHgpCV9NTUlP KDB4MTkwMDYwICsgKHggKiA0KSkKPiAgIAo+IApfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9pbnRlbC1nZngK