From: Masaki Kanno Subject: [PATCH] Fix parameter check of xm dmesg Date: Tue, 31 Oct 2006 15:07:57 +0900 Message-ID: <6EC6FCB2E951CEkanno.masaki@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="Boundary-y447Yo9Bj2eof9vuBQO3o" Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org --Boundary-y447Yo9Bj2eof9vuBQO3o Content-Type: text/plain; charset=iso-2022-jp Content-Transfer-Encoding: 7bit Content-Description: Mail message body Hi, I found a small bug in xm dmesg command. Even if I gave xm dmesg command a wrong parameter, xm dmesg command did not become an error. # xm dmesg xyz __ __ _____ ___ _ _ _ \ \/ /___ _ __ |___ / / _ \ _ _ _ __ ___| |_ __ _| |__ | | ___ \ // _ \ '_ \ |_ \| | | |__| | | | '_ \/ __| __/ _` | '_ \| |/ _ \ / \ __/ | | | ___) | |_| |__| |_| | | | \__ \ || (_| | |_) | | __/ /_/\_\___|_| |_| |____(_)___/ \__,_|_| |_|___/\__\__,_|_.__/|_|\___| http://www.cl.cam.ac.uk/netos/xen University of Cambridge Computer Laboratory Xen version 3.0-unstable (root@) () Tue Oct 31 11:06:09 JST 2006 Latest ChangeSet: Mon Oct 30 17:35:11 2006 +0000 12033:b21246720fde (XEN) Command line: /xen-3.0-unstable.gz (XEN) Physical RAM map: This patch adds a checking of wrong parameter into xm dmesg command. If wrong parameter is given, xm dmesg command shows the following error messages. # xm dmesg xyz Error: No parameter required Usage: xm dmesg [-c|--clear] Read and/or clear Xend's message buffer. -c, --clear Clear dmesg buffer Signed-off-by: Masaki Kanno Best regards, Kan --Boundary-y447Yo9Bj2eof9vuBQO3o Content-Type: application/octet-stream; name="dmesg.patch" Content-Disposition: attachment; filename="dmesg.patch" Content-Transfer-Encoding: base64 ZGlmZiAtciBiMjEyNDY3MjBmZGUgdG9vbHMvcHl0aG9uL3hlbi94bS9tYWluLnB5Ci0tLSBh L3Rvb2xzL3B5dGhvbi94ZW4veG0vbWFpbi5weQlNb24gT2N0IDMwIDE3OjM1OjExIDIwMDYg KzAwMDAKKysrIGIvdG9vbHMvcHl0aG9uL3hlbi94bS9tYWluLnB5CVR1ZSBPY3QgMzEgMTA6 MTg6NDcgMjAwNiArMDkwMApAQCAtMTAzMiwyNiArMTAzMiwyMyBAQCBkZWYgeG1fZG1lc2co YXJncyk6CiBkZWYgeG1fZG1lc2coYXJncyk6CiAgICAgYXJnX2NoZWNrKGFyZ3MsICJkbWVz ZyIsIDAsIDEpCiAgICAgCi0gICAgZ29wdHMgPSBPcHRzKHVzZT0iIiJbLWN8LS1jbGVhcl0K LQotUmVhZCBYZW4ncyBtZXNzYWdlIGJ1ZmZlciAoYm9vdCBvdXRwdXQsIHdhcm5pbmcgYW5k IGVycm9yIG1lc3NhZ2VzKSBvciBjbGVhcgotaXRzIGNvbnRlbnRzIGlmIHRoZSBbLWN8LS1j bGVhcl0gZmxhZyBpcyBzcGVjaWZpZWQuCi0iIiIpCi0KLSAgICBnb3B0cy5vcHQoJ2NsZWFy Jywgc2hvcnQ9J2MnLAotICAgICAgICAgICAgICBmbj1zZXRfdHJ1ZSwgZGVmYXVsdD0wLAot ICAgICAgICAgICAgICB1c2U9IkNsZWFyIHRoZSBjb250ZW50cyBvZiB0aGUgWGVuIG1lc3Nh Z2UgYnVmZmVyLiIpCi0gICAgIyBXb3JrIGFyb3VuZCBmb3IgZ29wdHMKLSAgICBteWFyZ3Mg PSBhcmdzCi0gICAgbXlhcmdzLmluc2VydCgwLCAnZG1lc2cnKQotICAgIGdvcHRzLnBhcnNl KG15YXJncykKLSAgICAKLSAgICBpZiBsZW4obXlhcmdzKSBub3QgaW4gKDEsIDIpOgotICAg ICAgICBlcnIoJ0ludmFsaWQgYXJndW1lbnRzOiAnICsgc3RyKG15YXJncykpCisgICAgdHJ5 OgorICAgICAgICAob3B0aW9ucywgcGFyYW1zKSA9IGdldG9wdC5nbnVfZ2V0b3B0KGFyZ3Ms ICdjJywgWydjbGVhciddKQorICAgIGV4Y2VwdCBnZXRvcHQuR2V0b3B0RXJyb3IsIG9wdGVy cjoKKyAgICAgICAgZXJyKG9wdGVycikKKyAgICAgICAgc3lzLmV4aXQoMSkKKyAgICAKKyAg ICB1c2VfY2xlYXIgPSAwCisgICAgZm9yIChrLCB2KSBpbiBvcHRpb25zOgorICAgICAgICBp ZiBrIGluIFsnLWMnLCAnLS1jbGVhciddOgorICAgICAgICAgICAgdXNlX2NsZWFyID0gMQor ICAgIAorICAgIGlmIGxlbihwYXJhbXMpIDoKKyAgICAgICAgZXJyKCJObyBwYXJhbWV0ZXIg cmVxdWlyZWQiKQogICAgICAgICB1c2FnZSgnZG1lc2cnKQogICAgICAgICBzeXMuZXhpdCgx KQogCi0gICAgaWYgbm90IGdvcHRzLnZhbHMuY2xlYXI6CisgICAgaWYgbm90IHVzZV9jbGVh cjoKICAgICAgICAgcHJpbnQgc2VydmVyLnhlbmQubm9kZS5kbWVzZy5pbmZvKCkKICAgICBl bHNlOgogICAgICAgICBzZXJ2ZXIueGVuZC5ub2RlLmRtZXNnLmNsZWFyKCkK --Boundary-y447Yo9Bj2eof9vuBQO3o Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --Boundary-y447Yo9Bj2eof9vuBQO3o--