From: "selvanair (Code Review)"
Date: Tue, 9 Jul 2024 21:40:21 +0000
In-Reply-To:
References:
Reply-To: selva.nair@...277..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net, frank@...2641...
Message-ID: <6a978ec4a9cd386794f7cf0fa86e33ac83d57cdf-EmailReviewComments-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="c6uqU56QazQ="; charset=UTF-8
Subject: [Openvpn-devel] [M] Change in openvpn[master]: Static-challenge
concatenation option
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Cc: flichtenheld , plaisthos , openvpn-devel
--c6uqU56QazQ=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, plaisthos.
selvanair has posted comments on this change. ( http://gerrit.openvpn.net/c=
/openvpn/+/665?usp=3Demail )
Change subject: Static-challenge concatenation option
......................................................................
Patch Set 3:
(2 comments)
File doc/management-notes.txt:
http://gerrit.openvpn.net/c/openvpn/+/665/comment/3e068024_aebfdec6 :
PS2, Line 1333: FORMAT =3D bit 2 =3D 1 if response should be conca=
tenated with password
> v2 is coming.
Done
File src/openvpn/misc.h:
http://gerrit.openvpn.net/c/openvpn/+/665/comment/c1296d70_31640ce7 :
PS2, Line 121: #define GET_USER_PASS_STATIC_CHALLENGE_CONCAT (1<<11) /* in=
dicates password and response should be concatenated */
> Test was submitted along with: see https://gerrit.openvpn. [=E2=80=A6]
Done
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/665?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I59a90446bfe73d8856516025a58a6f62cc98ab0d
Gerrit-Change-Number: 665
Gerrit-PatchSet: 3
Gerrit-Owner: selvanair
Gerrit-Reviewer: flichtenheld
Gerrit-Reviewer: plaisthos
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
Gerrit-Attention: flichtenheld
Gerrit-Comment-Date: Tue, 09 Jul 2024 21:40:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld
Comment-In-Reply-To: selvanair
Gerrit-MessageType: comment
--c6uqU56QazQ=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, plaisthos.
View C=
hange
2 comments:
=
File doc/management-notes.txt:
<=
ul style=3D"list-style: none; padding: 0;">Patch Set #2, Line 1333=
: FORMAT =3D b=
it 2 =3D 1 if response should be concatenated with password
v2 is coming.
Done
File src/openvpn/misc.h:
Done
To view, visit change 665. To unsubscribe=
, or for help writing mail filters, visit settings.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I59a90446bfe73d8856516025a58=
a6f62cc98ab0d
Gerrit-Change-Number: 665
Gerrit-PatchSet: 3
Gerrit-Owner: selvanair <selva.nair@...1354...=
..>
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...=
.1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...=
41...>
Gerrit-Comment-Date: Tue, 09 Jul 2024 21:40:21=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <frank@...1186...=
.2641...>
Comment-In-Reply-To: selvanair <selva.nair@=
...277...>
Gerrit-MessageType: comment
--c6uqU56QazQ=--