From: "ralf_lici (Code Review)" Date: Fri, 18 Jul 2025 14:41:02 +0000 References: Reply-To: ralf@...2726..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <6adced6192e0b879944d33220b732ec6a20ef684-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="rondNW8chLs="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: improve float collision logging List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos , flichtenheld Cc: openvpn-devel --rondNW8chLs= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1091?usp=3Demail to review the following change. Change subject: improve float collision logging ...................................................................... improve float collision logging Extend the log message printed when an instance floats to an address already taken by another instance with the same certificate. The updated message now includes the instance being closed, the reason it's being closed, and the new instance taking over that address. Change-Id: I217cfb319b85fd75a88f7d4d50c374d28771df28 Signed-off-by: Ralf Lici --- M src/openvpn/multi.c 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/91/1091/1 diff --git a/src/openvpn/multi.c b/src/openvpn/multi.c index ead3dd0..4696686 100644 --- a/src/openvpn/multi.c +++ b/src/openvpn/multi.c @@ -3263,7 +3263,11 @@ mroute_addr_print(&mi->real, &gc)); goto done; } - msg(D_MULTI_MEDIUM, "closing instance %s", multi_instance_string(e= x_mi, false, &gc)); + + msg(D_MULTI_LOW, "closing instance %s due to float collision with = %s " + "using the same certificate", + multi_instance_string(ex_mi, false, &gc), + multi_instance_string(mi, false, &gc)); multi_close_instance(m, ex_mi, false); } -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1091?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I217cfb319b85fd75a88f7d4d50c374d28771df28 Gerrit-Change-Number: 1091 Gerrit-PatchSet: 1 Gerrit-Owner: ralf_lici Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-MessageType: newchange --rondNW8chLs= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, plaisthos.

ralf_lici would like plaisthos and flichtenheld to review this change.

V= iew Change

improve float collision logging

Extend the log messag= e printed when an instance floats to an address
already taken by another= instance with the same certificate. The updated
message now includes th= e instance being closed, the reason it's being
closed, and the new i= nstance taking over that address.

Change-Id: I217cfb319b85fd75a88f7d= 4d50c374d28771df28
Signed-off-by: Ralf Lici <ralf@...2726...>
-= --
M src/openvpn/multi.c
1 file changed, 5 insertions(+), 1 deletion(= -)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/9=
1/1091/1
diff --git a/src/openvpn/multi.c b/src/openvpn/multi.c
index ead3dd0..4696686 100644
--- a/src/openvp= n/multi.c
+++ b/src/openvpn/multi.c
@@ -326= 3,7 +3263,11 @@
mroute_addr_print(&mi-= >real, &gc));
goto done;
}

- m= sg(D_MULTI_MEDIUM, "closing instance %s", multi_instance_string(e= x_mi, false, &gc));
+
+ msg(D_M= ULTI_LOW, "closing instance %s due to float collision with %s "
+ "usi= ng the same certificate",
+ multi_instance_string(ex_mi, false, &gc),=
+ multi_instance= _string(mi, false, &gc));
multi_close_instance= (m, ex_mi, false);
}


To view, visit change 1091. To unsubscribe, or for help wr= iting mail filters, visit se= ttings.

<= div itemscope itemprop=3D"action" itemtype=3D"http://schema.org/ViewAction"= >
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I217cfb319b85fd75a88f7d4d50c= 374d28771df28
Gerrit-Change-Number: 1091
Gerrit-PatchSet: 1
Gerrit-Owner: ralf_lici <ralf@...2726...>= ;
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-MessageType: newchange
--rondNW8chLs=--