From: Marek Vasut Date: Thu, 27 Aug 2020 11:49:25 +0200 Subject: [PATCH] Revert "env: Warn on force access if ENV_ACCESS_IGNORE_FORCE set" In-Reply-To: <20200827094342.25780-1-alex.kiernan@gmail.com> References: <20200827094342.25780-1-alex.kiernan@gmail.com> Message-ID: <6ae1f4ca-df4d-e421-768e-c321ca9c512a@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 8/27/20 11:43 AM, Alex Kiernan wrote: > This reverts commit 0f036bf4b87e6416f5c4d23865a62a62d9073c20. > > With this change applied and CONFIG_ENV_ACCESS_IGNORE_FORCE disabled, > the warning appears on every force overwrite, but the variable is then > written to: > > => env print ethaddr > ethaddr=00:1C:2B:08:AF:65 > => env set ethaddr 00:00:00:00:00:00 > ## Error: Can't overwrite "ethaddr" > ## Error inserting "ethaddr" variable, errno=1 > => env print ethaddr > ethaddr=00:1C:2B:08:AF:65 > => env set -f ethaddr 00:00:00:00:00:00 > ## Error: Can't force access to "ethaddr" > => env print ethaddr > ethaddr=00:00:00:00:00:00 > > Signed-off-by: Alex Kiernan > --- > As I noted in my email, I can't see an immediately obvious way to make > this work as intended and given we're at -rc3, I think a revert is the > most appropriate way forward. Can you please spend some more time on proper fix, instead of just reverting ? Reverting isn't the way forward most of the time.