Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D80FFC54FCB for ; Wed, 22 Apr 2020 14:01:27 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AE0A42077D for ; Wed, 22 Apr 2020 14:01:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE0A42077D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jRFw1-0007sH-GJ; Wed, 22 Apr 2020 14:01:05 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jRFvz-0007sC-Ud for xen-devel@lists.xenproject.org; Wed, 22 Apr 2020 14:01:03 +0000 X-Inumbo-ID: b3663de7-84a1-11ea-9289-12813bfff9fa Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b3663de7-84a1-11ea-9289-12813bfff9fa; Wed, 22 Apr 2020 14:01:02 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id DF032ABCF; Wed, 22 Apr 2020 14:01:00 +0000 (UTC) Subject: Re: [PATCH] xen/grants: fix hypercall continuation for GNTTABOP_cache_flush To: Juergen Gross References: <20200422130753.14713-1-jgross@suse.com> From: Jan Beulich Message-ID: <6b050b8e-72d2-2d4f-3e23-101596d31d40@suse.com> Date: Wed, 22 Apr 2020 16:00:55 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200422130753.14713-1-jgross@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , xen-devel@lists.xenproject.org Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 22.04.2020 15:07, Juergen Gross wrote: > --- a/xen/common/grant_table.c > +++ b/xen/common/grant_table.c > @@ -3626,12 +3626,12 @@ do_grant_table_op( > if ( unlikely(!guest_handle_okay(cflush, count)) ) > goto out; > rc = gnttab_cache_flush(cflush, &opaque_in, count); > - if ( rc > 0 ) > + if ( rc >= 0 ) > { > guest_handle_add_offset(cflush, rc); > uop = guest_handle_cast(cflush, void); > + opaque_out = opaque_in; > } > - opaque_out = opaque_in; > break; > } > > @@ -3641,7 +3641,7 @@ do_grant_table_op( > } > > out: > - if ( rc > 0 || opaque_out != 0 ) > + if ( rc > 0 || (opaque_out != 0 && rc == 0) ) I disagree with this part - opaque_out shouldn't end up non-zero when rc < 0, and it won't anymore with the change in the earlier hunk. Jan