From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 1/3] drm/amdgpu: Avoid accessing job->entity after the job is scheduled. Date: Mon, 23 Oct 2017 14:36:31 +0200 Message-ID: <6b49f609-a083-ddde-ff3b-2abfe39890c3@gmail.com> References: <1508506327-1084-1-git-send-email-Andrey.Grodzovsky@amd.com> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1508506327-1084-1-git-send-email-Andrey.Grodzovsky-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Andrey Grodzovsky , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Cc: christian.koenig-5C7GfCeVMHo@public.gmane.org QW0gMjAuMTAuMjAxNyB1bSAxNTozMiBzY2hyaWViIEFuZHJleSBHcm9kem92c2t5Ogo+IEJ1Zzog YW1kZ3B1X2pvYl9mcmVlX2NiIHdhcyBhY2Nlc3Npbmcgc19qb2ItPnNfZW50aXR5IHdoZW4gdGhl IGFsbG9jYXRlZAo+IGFtZGdwdV9jdHggKGFuZCB0aGUgZW50aXR5IGluc2lkZSBpdCkgd2VyZSBh bHJlYWR5IGRlYWxsb2NhdGVkIGZyb20KPiBhbWRncHVfY3NfcGFyc2VyX2ZpbmkuCj4KPiBGaXg6 IFNhdmUgam9iJ3MgcHJpb3JpdHkgb24gaXQncyBjcmVhdGlvbiBpbnN0ZWFkIG9mIGFjY2Vzc2lu ZyBpdCBmcm9tCj4gc19lbnRpdHkgbGF0ZXIgb24uCj4KPiBTaWduZWQtb2ZmLWJ5OiBBbmRyZXkg R3JvZHpvdnNreSA8QW5kcmV5Lkdyb2R6b3Zza3lAYW1kLmNvbT4KClJldmlld2VkLWJ5OiBDaHJp c3RpYW4gS8O2bmlnIDxjaHJpc3RpYW4ua29lbmlnQGFtZC5jb20+Cgo+IC0tLQo+ICAgZHJpdmVy cy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2NzLmMgICAgICAgIHwgIDMgKy0tCj4gICBkcml2 ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfam9iLmMgICAgICAgfCAgNSArKy0tLQo+ICAg ZHJpdmVycy9ncHUvZHJtL2FtZC9zY2hlZHVsZXIvZ3B1X3NjaGVkdWxlci5jIHwgIDEgKwo+ICAg ZHJpdmVycy9ncHUvZHJtL2FtZC9zY2hlZHVsZXIvZ3B1X3NjaGVkdWxlci5oIHwgMzIgKysrKysr KysrKysrLS0tLS0tLS0tLS0tLS0tCj4gICA0IGZpbGVzIGNoYW5nZWQsIDE4IGluc2VydGlvbnMo KyksIDIzIGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQv YW1kZ3B1L2FtZGdwdV9jcy5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2Nz LmMKPiBpbmRleCBmN2ZjZWI2Li5hNzYwYjZlIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9hbWQvYW1kZ3B1L2FtZGdwdV9jcy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRn cHUvYW1kZ3B1X2NzLmMKPiBAQCAtMTE5Miw4ICsxMTkyLDcgQEAgc3RhdGljIGludCBhbWRncHVf Y3Nfc3VibWl0KHN0cnVjdCBhbWRncHVfY3NfcGFyc2VyICpwLAo+ICAgCWpvYi0+dWZfc2VxdWVu Y2UgPSBzZXE7Cj4gICAKPiAgIAlhbWRncHVfam9iX2ZyZWVfcmVzb3VyY2VzKGpvYik7Cj4gLQlh bWRncHVfcmluZ19wcmlvcml0eV9nZXQoam9iLT5yaW5nLAo+IC0JCQkJIGFtZF9zY2hlZF9nZXRf am9iX3ByaW9yaXR5KCZqb2ItPmJhc2UpKTsKPiArCWFtZGdwdV9yaW5nX3ByaW9yaXR5X2dldChq b2ItPnJpbmcsIGpvYi0+YmFzZS5zX3ByaW9yaXR5KTsKPiAgIAo+ICAgCXRyYWNlX2FtZGdwdV9j c19pb2N0bChqb2IpOwo+ICAgCWFtZF9zY2hlZF9lbnRpdHlfcHVzaF9qb2IoJmpvYi0+YmFzZSk7 Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9qb2IuYyBi L2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9qb2IuYwo+IGluZGV4IDBjZmM2OGQu LmE1OGUzYzUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1 X2pvYi5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2pvYi5jCj4g QEAgLTEwNCw3ICsxMDQsNyBAQCBzdGF0aWMgdm9pZCBhbWRncHVfam9iX2ZyZWVfY2Ioc3RydWN0 IGFtZF9zY2hlZF9qb2IgKnNfam9iKQo+ICAgewo+ICAgCXN0cnVjdCBhbWRncHVfam9iICpqb2Ig PSBjb250YWluZXJfb2Yoc19qb2IsIHN0cnVjdCBhbWRncHVfam9iLCBiYXNlKTsKPiAgIAo+IC0J YW1kZ3B1X3JpbmdfcHJpb3JpdHlfcHV0KGpvYi0+cmluZywgYW1kX3NjaGVkX2dldF9qb2JfcHJp b3JpdHkoc19qb2IpKTsKPiArCWFtZGdwdV9yaW5nX3ByaW9yaXR5X3B1dChqb2ItPnJpbmcsIHNf am9iLT5zX3ByaW9yaXR5KTsKPiAgIAlkbWFfZmVuY2VfcHV0KGpvYi0+ZmVuY2UpOwo+ICAgCWFt ZGdwdV9zeW5jX2ZyZWUoJmpvYi0+c3luYyk7Cj4gICAJYW1kZ3B1X3N5bmNfZnJlZSgmam9iLT5k ZXBfc3luYyk7Cj4gQEAgLTE0MSw4ICsxNDEsNyBAQCBpbnQgYW1kZ3B1X2pvYl9zdWJtaXQoc3Ry dWN0IGFtZGdwdV9qb2IgKmpvYiwgc3RydWN0IGFtZGdwdV9yaW5nICpyaW5nLAo+ICAgCWpvYi0+ ZmVuY2VfY3R4ID0gZW50aXR5LT5mZW5jZV9jb250ZXh0Owo+ICAgCSpmID0gZG1hX2ZlbmNlX2dl dCgmam9iLT5iYXNlLnNfZmVuY2UtPmZpbmlzaGVkKTsKPiAgIAlhbWRncHVfam9iX2ZyZWVfcmVz b3VyY2VzKGpvYik7Cj4gLQlhbWRncHVfcmluZ19wcmlvcml0eV9nZXQoam9iLT5yaW5nLAo+IC0J CQkJIGFtZF9zY2hlZF9nZXRfam9iX3ByaW9yaXR5KCZqb2ItPmJhc2UpKTsKPiArCWFtZGdwdV9y aW5nX3ByaW9yaXR5X2dldChqb2ItPnJpbmcsIGpvYi0+YmFzZS5zX3ByaW9yaXR5KTsKPiAgIAlh bWRfc2NoZWRfZW50aXR5X3B1c2hfam9iKCZqb2ItPmJhc2UpOwo+ICAgCj4gICAJcmV0dXJuIDA7 Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvc2NoZWR1bGVyL2dwdV9zY2hlZHVs ZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvc2NoZWR1bGVyL2dwdV9zY2hlZHVsZXIuYwo+IGlu ZGV4IGU0ZDNiNGUuLjFiYmJjZTIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9z Y2hlZHVsZXIvZ3B1X3NjaGVkdWxlci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9zY2hl ZHVsZXIvZ3B1X3NjaGVkdWxlci5jCj4gQEAgLTUyOSw2ICs1MjksNyBAQCBpbnQgYW1kX3NjaGVk X2pvYl9pbml0KHN0cnVjdCBhbWRfc2NoZWRfam9iICpqb2IsCj4gICB7Cj4gICAJam9iLT5zY2hl ZCA9IHNjaGVkOwo+ICAgCWpvYi0+c19lbnRpdHkgPSBlbnRpdHk7Cj4gKwlqb2ItPnNfcHJpb3Jp dHkgPSBlbnRpdHktPnJxIC0gc2NoZWQtPnNjaGVkX3JxOwo+ICAgCWpvYi0+c19mZW5jZSA9IGFt ZF9zY2hlZF9mZW5jZV9jcmVhdGUoZW50aXR5LCBvd25lcik7Cj4gICAJaWYgKCFqb2ItPnNfZmVu Y2UpCj4gICAJCXJldHVybiAtRU5PTUVNOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v YW1kL3NjaGVkdWxlci9ncHVfc2NoZWR1bGVyLmggYi9kcml2ZXJzL2dwdS9kcm0vYW1kL3NjaGVk dWxlci9ncHVfc2NoZWR1bGVyLmgKPiBpbmRleCA1MmM4ZTU0Li4zZjc1YjQ1IDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvc2NoZWR1bGVyL2dwdV9zY2hlZHVsZXIuaAo+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9hbWQvc2NoZWR1bGVyL2dwdV9zY2hlZHVsZXIuaAo+IEBAIC0zMCw2 ICszMCwxOSBAQAo+ICAgc3RydWN0IGFtZF9ncHVfc2NoZWR1bGVyOwo+ICAgc3RydWN0IGFtZF9z Y2hlZF9ycTsKPiAgIAo+ICtlbnVtIGFtZF9zY2hlZF9wcmlvcml0eSB7Cj4gKwlBTURfU0NIRURf UFJJT1JJVFlfTUlOLAo+ICsJQU1EX1NDSEVEX1BSSU9SSVRZX0xPVyA9IEFNRF9TQ0hFRF9QUklP UklUWV9NSU4sCj4gKwlBTURfU0NIRURfUFJJT1JJVFlfTk9STUFMLAo+ICsJQU1EX1NDSEVEX1BS SU9SSVRZX0hJR0hfU1csCj4gKwlBTURfU0NIRURfUFJJT1JJVFlfSElHSF9IVywKPiArCUFNRF9T Q0hFRF9QUklPUklUWV9LRVJORUwsCj4gKwlBTURfU0NIRURfUFJJT1JJVFlfTUFYLAo+ICsJQU1E X1NDSEVEX1BSSU9SSVRZX0lOVkFMSUQgPSAtMSwKPiArCUFNRF9TQ0hFRF9QUklPUklUWV9VTlNF VCA9IC0yCj4gK307Cj4gKwo+ICsKPiAgIC8qKgo+ICAgICogQSBzY2hlZHVsZXIgZW50aXR5IGlz IGEgd3JhcHBlciBhcm91bmQgYSBqb2IgcXVldWUgb3IgYSBncm91cAo+ICAgICogb2Ygb3RoZXIg ZW50aXRpZXMuIEVudGl0aWVzIHRha2UgdHVybnMgZW1pdHRpbmcgam9icyBmcm9tIHRoZWlyCj4g QEAgLTgzLDYgKzk2LDcgQEAgc3RydWN0IGFtZF9zY2hlZF9qb2Igewo+ICAgCXN0cnVjdCBkZWxh eWVkX3dvcmsJCXdvcmtfdGRyOwo+ICAgCXVpbnQ2NF90CQkJaWQ7Cj4gICAJYXRvbWljX3Qga2Fy bWE7Cj4gKwllbnVtIGFtZF9zY2hlZF9wcmlvcml0eSBzX3ByaW9yaXR5Owo+ICAgfTsKPiAgIAo+ ICAgZXh0ZXJuIGNvbnN0IHN0cnVjdCBkbWFfZmVuY2Vfb3BzIGFtZF9zY2hlZF9mZW5jZV9vcHNf c2NoZWR1bGVkOwo+IEBAIC0xMTQsMTggKzEyOCw2IEBAIHN0cnVjdCBhbWRfc2NoZWRfYmFja2Vu ZF9vcHMgewo+ICAgCXZvaWQgKCpmcmVlX2pvYikoc3RydWN0IGFtZF9zY2hlZF9qb2IgKnNjaGVk X2pvYik7Cj4gICB9Owo+ICAgCj4gLWVudW0gYW1kX3NjaGVkX3ByaW9yaXR5IHsKPiAtCUFNRF9T Q0hFRF9QUklPUklUWV9NSU4sCj4gLQlBTURfU0NIRURfUFJJT1JJVFlfTE9XID0gQU1EX1NDSEVE X1BSSU9SSVRZX01JTiwKPiAtCUFNRF9TQ0hFRF9QUklPUklUWV9OT1JNQUwsCj4gLQlBTURfU0NI RURfUFJJT1JJVFlfSElHSF9TVywKPiAtCUFNRF9TQ0hFRF9QUklPUklUWV9ISUdIX0hXLAo+IC0J QU1EX1NDSEVEX1BSSU9SSVRZX0tFUk5FTCwKPiAtCUFNRF9TQ0hFRF9QUklPUklUWV9NQVgsCj4g LQlBTURfU0NIRURfUFJJT1JJVFlfSU5WQUxJRCA9IC0xLAo+IC0JQU1EX1NDSEVEX1BSSU9SSVRZ X1VOU0VUID0gLTIKPiAtfTsKPiAtCj4gICAvKioKPiAgICAqIE9uZSBzY2hlZHVsZXIgaXMgaW1w bGVtZW50ZWQgZm9yIGVhY2ggaGFyZHdhcmUgcmluZwo+ICAgKi8KPiBAQCAtMTc2LDEwICsxNzgs NCBAQCBib29sIGFtZF9zY2hlZF9kZXBlbmRlbmN5X29wdGltaXplZChzdHJ1Y3QgZG1hX2ZlbmNl KiBmZW5jZSwKPiAgIAkJCQkgICAgc3RydWN0IGFtZF9zY2hlZF9lbnRpdHkgKmVudGl0eSk7Cj4g ICB2b2lkIGFtZF9zY2hlZF9qb2Jfa2lja291dChzdHJ1Y3QgYW1kX3NjaGVkX2pvYiAqc19qb2Ip Owo+ICAgCj4gLXN0YXRpYyBpbmxpbmUgZW51bSBhbWRfc2NoZWRfcHJpb3JpdHkKPiAtYW1kX3Nj aGVkX2dldF9qb2JfcHJpb3JpdHkoc3RydWN0IGFtZF9zY2hlZF9qb2IgKmpvYikKPiAtewo+IC0J cmV0dXJuIChqb2ItPnNfZW50aXR5LT5ycSAtIGpvYi0+c2NoZWQtPnNjaGVkX3JxKTsKPiAtfQo+ IC0KPiAgICNlbmRpZgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmFtZC1nZnggbWFpbGluZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeAo=