Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD838C433E0 for ; Mon, 18 Jan 2021 15:35:45 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8916A206F7 for ; Mon, 18 Jan 2021 15:35:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8916A206F7 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.69774.125053 (Exim 4.92) (envelope-from ) id 1l1WZ7-0003o3-0h; Mon, 18 Jan 2021 15:35:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 69774.125053; Mon, 18 Jan 2021 15:35:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l1WZ6-0003nw-Tn; Mon, 18 Jan 2021 15:35:36 +0000 Received: by outflank-mailman (input) for mailman id 69774; Mon, 18 Jan 2021 15:35:35 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l1WZ5-0003nm-7a for xen-devel@lists.xenproject.org; Mon, 18 Jan 2021 15:35:35 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 563a2749-4ee6-4363-bb7f-27eee2313182; Mon, 18 Jan 2021 15:35:34 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 55CD3AC63; Mon, 18 Jan 2021 15:35:33 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 563a2749-4ee6-4363-bb7f-27eee2313182 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1610984133; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TVI7VVvHYyVE7QzeNy/jdcAfgKXgNy41qppNapJ1++Y=; b=SuOAr0a9vuV0hpJDvdo3oNe3I9mIJIlKIVmPH3kNHr3W4LR/CzX+ooa1Cq2JhabqkMPHZw M2ZEUuUmO1J/u87JxZjaHfWG22ET9TFrjYzhL+dJ6YXUucQCiWakLrvWn7PLy4h1bKJBzQ r745q7qWwwxF6hhj6scMuUQOu5sTLxg= Subject: Re: [PATCH] xen/decompress: make helper symbols static To: Andrew Cooper Cc: George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <28f15465-bfcd-606b-eb24-42bfb990ae3d@suse.com> <0290fc6d-a7a1-3f30-668d-2ef24fbc4802@citrix.com> From: Jan Beulich Message-ID: <6b8f2b6d-a2fc-12c9-90ef-04ac5e9cce30@suse.com> Date: Mon, 18 Jan 2021 16:35:32 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <0290fc6d-a7a1-3f30-668d-2ef24fbc4802@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 18.01.2021 16:31, Andrew Cooper wrote: > On 18/01/2021 15:13, Jan Beulich wrote: >> On 18.01.2021 12:58, Andrew Cooper wrote: >>> but I really would >>> like to see the STATIC and INIT defines disappear eventually. >> I too would like to, but I don't see this happen in particular >> for INIT and INITDATA, when we have two distinct environments >> where this code gets built. Unless you envision the tool stack / >> stubdom side of the build to gain >> >> #define __init >> #define __initdata >> >> ? > > I think that's fine. > > One way or another, some header file somewhere needs to plumb this up > for the differing environments.  I just don't see the need for an extra > level of indirection. I see. Maybe I can do so while I'm touching this code anyway. >> As far as STATIC goes, being in the middle of the DomU side >> work of this, I've found a need to sprinkle around quite a >> few of them in zstd/decompress.c, again to silence similar >> compiler diagnostics. > > Do you mean you've had to add more STATIC's in? Yes indeed. Plus #ifdef out some of the functions that aren't used at all, i.e. where with static added the compiler would still warn. Yet I didn't want to delete code there, in order for future changes we might want to grab from Linux to apply reasonably. Jan