Message-ID: <6b98d160-b483-f49d-fd9d-ac769acb74a0@...1227...> Date: Thu, 28 Jul 2022 14:56:05 +0200 MIME-Version: 1.0 Content-Language: en-GB References: <20220720123249.909-1-a@...2181...> From: Arne Schwabe In-Reply-To: <20220720123249.909-1-a@...2181...> Subject: Re: [Openvpn-devel] [PATCH v2 09/25] dco: configure keys in DCO right after generating them List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit To: Antonio Quartulli , openvpn-devel@lists.sourceforge.net > index 87d6fc31..dba9d02c 100644 > --- a/src/openvpn/options.c > +++ b/src/openvpn/options.c > @@ -3194,6 +3194,16 @@ options_postprocess_mutate_ce(struct options *o, struct connection_entry *ce) > ce->explicit_exit_notification = 0; > } > > + /* when DCO is in use we can't send data channel packets. > + * EEN needs to be re-implemented over the control channel in order > + * to work. > + */ > + if (dco_enabled(o) && ce->explicit_exit_notification) > + { > + msg(M_WARN, "NOTICE: --explicit-exit-notify ignored when " > + "data channel offload is in use"); > + ce->explicit_exit_notification = 0; > + } I don't like this. There is already the patch from me that allows this on the control channel. So we need a better solution than disabling it when dco is enabled. Did you check what happens if data packets are tried being sent when DCO is enabled? Maybe that just has a warning now that no key is active. Arne