From: "selvanair (Code Review)" Date: Tue, 31 Mar 2026 18:53:54 +0000 References: Reply-To: selva.nair@...277..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: <6ba107a223071d18cba451f8c3cdf23c5861accf-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="ZVnZNRAJ708="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: Inlined credentials: read missing password from management interface List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --ZVnZNRAJ708= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1599?usp=3Demail to review the following change. Change subject: Inlined credentials: read missing password from management = interface ...................................................................... Inlined credentials: read missing password from management interface When commit 39619b7fab added support for inlining username only, fallback for password was from console. This is not ideal when graphical UI is in use as there is no console. Instead, query the management interface when possible. This patch just extends a similar fix when username is read from a file and password is missing. As before, any username read from file or inlined is not peserved as we currently have no way of locking the username in the management interface prompt. Change-Id: Ieeb2f980330d485739dbf3d722f107c1dbf704fc Signed-off-by: Selva Nair --- M src/openvpn/misc.c 1 file changed, 17 insertions(+), 19 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/99/1599/1 diff --git a/src/openvpn/misc.c b/src/openvpn/misc.c index c00a3ce..979293f 100644 --- a/src/openvpn/misc.c +++ b/src/openvpn/misc.c @@ -305,24 +305,6 @@ { strncpy(up->password, password_buf, USER_PASS_LEN); } - /* The auth-file does not have the password: get both user= name - * and password from the management interface if possible. - * Otherwise set to read password from console. - */ -#if defined(ENABLE_MANAGEMENT) - else if (management && (flags & GET_USER_PASS_MANAGEMENT) - && management_query_user_pass_enabled(management)) - { - msg(D_LOW, - "No password found in %s authfile '%s'. Querying t= he management interface", - prefix, auth_file); - if (!auth_user_pass_mgmt(up, prefix, flags, auth_chall= enge)) - { - fclose(fp); - return false; - } - } -#endif else { password_from_stdin =3D 1; @@ -348,7 +330,23 @@ if (username_from_stdin || password_from_stdin || response_from_st= din) { #ifdef ENABLE_MANAGEMENT - if (auth_challenge && (flags & GET_USER_PASS_DYNAMIC_CHALLENGE= ) && response_from_stdin) + /* If management-query-passwords is true, we could be here bec= ause + * of no password present in auth-file or inline. In that case + * query via the management interface instead of stdin/console. + */ + if (management && (flags & GET_USER_PASS_MANAGEMENT) + && management_query_user_pass_enabled(management) + && !(flags & GET_USER_PASS_USERNAME_ONLY)) + { + msg(D_LOW, + "No '%s' password found in authfile or inline. Queryin= g the management interface", + prefix); + if (!auth_user_pass_mgmt(up, prefix, flags, auth_challenge= )) + { + return false; + } + } + else if (auth_challenge && (flags & GET_USER_PASS_DYNAMIC_CHAL= LENGE) && response_from_stdin) { struct auth_challenge_info *ac =3D parse_auth_challenge(au= th_challenge, &gc); if (ac) -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1599?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: newchange Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ieeb2f980330d485739dbf3d722f107c1dbf704fc Gerrit-Change-Number: 1599 Gerrit-PatchSet: 1 Gerrit-Owner: selvanair Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos --ZVnZNRAJ708= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: plaisthos.

selvanair would like plaisthos to review this change.

V= iew Change

Inlined credentials: read missing password =
from management interface

When commit 39619b7fab added support for i= nlining username only,
fallback for password was from console. This is n= ot ideal when
graphical UI is in use as there is no console. Instead, qu= ery the
management interface when possible.

This patch just exten= ds a similar fix when username is read from
a file and password is missi= ng. As before, any username read
from file or inlined is not peserved as= we currently have no way
of locking the username in the management inte= rface prompt.

Change-Id: Ieeb2f980330d485739dbf3d722f107c1dbf704fcSigned-off-by: Selva Nair <selva.nair@...277...>
---
M src/op= envpn/misc.c
1 file changed, 17 insertions(+), 19 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/chan=
ges/99/1599/1
diff --git a/src/openvpn/misc.c b/src/openvpn/misc.c<=
/span>
index c00a3ce..979293f 100644
--- a/src/ope= nvpn/misc.c
+++ b/src/openvpn/misc.c
@@ -30= 5,24 +305,6 @@
{
= strncpy(up->password, password_buf, USER_PASS_LEN); }
- /* The auth-file does not have the password: get both = username
- = * and password from the management interface if possible.
- * Otherwise set to= read password from console.

- */
-#if defined(ENABLE_MANAGEMENT)
- else if (management && (flags & G= ET_USER_PASS_MANAGEMENT)
- = {
- = msg(D_LOW,
- = "No password found in %s authfile '%s'. Que= rying the management interface",
- prefix, auth_file);
- if (!auth_user_pa= ss_mgmt(up, prefix, flags, auth_challenge))
- {
- fclose(fp);
- return false;
- }
- }

-#endif
= else
{
= password_from_stdin =3D 1;
@@ -348,7 +330,23= @@
if (username_from_stdin || password_from_stdin= || response_from_stdin)
{
#ifdef= ENABLE_MANAGEMENT
- = if (auth_challenge && (flags & GET_USER_PASS_DYNAMIC_C= HALLENGE) && response_from_stdin)
+ /* If management-query-passwords is true,= we could be here because
+ * of no password present in auth-file or inline. In that= case
+ *= query via the management interface instead of stdin/console.
+ */
+ if (management &&= (flags & GET_USER_PASS_MANAGEMENT)
+ && management_query_user_pass_e= nabled(management)
+ = && !(flags & GET_USER_PASS_USERNAME_ONLY))
+ {
<= span style=3D"color: hsl(120, 100%, 40%);">+ msg(D_LOW,
+ &quo= t;No '%s' password found in authfile or inline. Querying the manage= ment interface",
+ prefix);
+ if (!auth_user_pass_mgmt(up, prefix, flags, auth= _challenge))
+ = {
+ = return false;
+ }
+ = else if (auth_challenge && (flags & GET_USER_PASS_DYNA= MIC_CHALLENGE) && response_from_stdin)
= {
struct auth_challenge_info *ac =3D pars= e_auth_challenge(auth_challenge, &gc);
= if (ac)

To view, visit change 1599. To uns= ubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ieeb2f980330d485739dbf3d722f= 107c1dbf704fc
Gerrit-Change-Number: 1599
Gerrit-PatchSet: 1
Gerrit-Owner: selvanair <selva.nair@...1354...= ..>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
= --ZVnZNRAJ708=--