Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DFB71C2A5 for ; Fri, 26 Jan 2024 14:55:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706280952; cv=none; b=JI+EnwhT2nFOK0YDyAoZ3Kgxv4wW14/ifoDIg5vCp/aKp8/K2bDZpJm0aXHcz0MoizSoDE9ODFWC8GPhzkncrrZPVtazkVMAFUjN4tRJ6qQtXAlJgvSjU7XZcZWR2JuTKQg534MtOYt3Qx3y6+GnO5kb67wQCAC+DZbHCcq6nAY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706280952; c=relaxed/simple; bh=8M0bYM0uXUy87wYCND7vobh+e83o+qNUDlfNCt5UwQ0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Lq+kJdsPafnLyPpo1kjegWAPkhv2D4IdSRfjIq10jlYOCphyixuktwC9fIZAYhUcAKyC0c0efliYoD7lwceDaKQgY+6ZZWYJx+HcFrQ0xfX7Z9aIlRq6PNtyauqkoNGn90IcLJTHorEYN3U9jEUQL43LkpoYL9GsDZCzaJrerp4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=WRnLUuZM; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WRnLUuZM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706280949; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=u+xutdsv8OQWpGIwPrCBB7COgMFnmUuub8Q23UENQOg=; b=WRnLUuZMnfxoedeqYaxKUkvGEdJxgmaYqq3DsRIhDa+sNzhKzzJxSy9/njnF3/lpc/Kiwl rCzCes09OGMI07GT+5BSx+sFA2sMb3ZXzru1Oys2C5CdLrTVZHrosyJwah485h1j14EDyM XrLYTcSRjnbqErx6Wcd17O80PI1WZMw= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-155-k5CII76xPyCi3gfFxRgrKA-1; Fri, 26 Jan 2024 09:55:28 -0500 X-MC-Unique: k5CII76xPyCi3gfFxRgrKA-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-337d6024098so318673f8f.1 for ; Fri, 26 Jan 2024 06:55:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706280928; x=1706885728; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=u+xutdsv8OQWpGIwPrCBB7COgMFnmUuub8Q23UENQOg=; b=Hm5Jb/bAUgz6VEKUAmjm4MCiwjqpapqvvF1k/9jYz3Zm8wuy4bhFmbhOim1kUn90IR x1xr2OjpoiIFBEABHWL/bEouD7CuM1mpAmJMktjysDCCh67aJGfH/wHTFlHGJtkGxpT7 4mraNjcOOUSWi9rhIPWE7XmG9lTu5r1iajFHNdm6Jp3qY45uvdGD1fKUirBTaIaJzeB8 4G+BhBHd5ctmDWTyJxdFyCCH14jj12hjXJK1R/Bau9gASgblgF6w9eQO0Z5afX5mWvSw IfkRbKrz8kynFad1Hu8aUpktO7tiM9E94I7SXrGt4NIlONJP4GKttTQtc7Ll8ix0qaTH H9zg== X-Gm-Message-State: AOJu0YxA1OItDcilpU9Wgs7W2+bOvaz03tGfzj0w4a7wWDBrJU32XIEr 0xp0yC1vzwFHBdO3GlH3OSRg4+qDEeF68tLDaKHUqst34dWgu7c7h2C1/GgRjv64God4bfFqjU7 jEZnZVNgARfacJIFSsS3k3sDi0ytju9aoHvwT8fcwXyXJR73PGg== X-Received: by 2002:a5d:408a:0:b0:337:6529:6cf6 with SMTP id o10-20020a5d408a000000b0033765296cf6mr986748wrp.88.1706280927691; Fri, 26 Jan 2024 06:55:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IEqEIvk2kFaWE+6p+67gNRCZPhINgR7+LGUFfyW/xO4tXwJIsC0Wenc4hkyI9a1wgdZVUMRiA== X-Received: by 2002:a5d:408a:0:b0:337:6529:6cf6 with SMTP id o10-20020a5d408a000000b0033765296cf6mr986731wrp.88.1706280927266; Fri, 26 Jan 2024 06:55:27 -0800 (PST) Received: from ?IPV6:2003:cb:c70a:5100:7e95:22ff:3f9b:1e92? (p200300cbc70a51007e9522ff3f9b1e92.dip0.t-ipconnect.de. [2003:cb:c70a:5100:7e95:22ff:3f9b:1e92]) by smtp.gmail.com with ESMTPSA id cc9-20020a5d5c09000000b00339443be964sm171464wrb.91.2024.01.26.06.55.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Jan 2024 06:55:26 -0800 (PST) Message-ID: <6bc40e34-7bef-46ea-8b28-2cc76780dc65@redhat.com> Date: Fri, 26 Jan 2024 15:55:25 +0100 Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 45/66] memory: Introduce memory_region_init_ram_guest_memfd() Content-Language: en-US To: Xiaoyao Li , Paolo Bonzini , Igor Mammedov , "Michael S . Tsirkin" , Marcel Apfelbaum , Richard Henderson , Peter Xu , =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , Cornelia Huck , =?UTF-8?Q?Daniel_P_=2E_Berrang=C3=A9?= , Eric Blake , Markus Armbruster , Marcelo Tosatti Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, Michael Roth , Sean Christopherson , Claudio Fontana , Gerd Hoffmann , Isaku Yamahata , Chenyi Qiang References: <20240125032328.2522472-1-xiaoyao.li@intel.com> <20240125032328.2522472-46-xiaoyao.li@intel.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240125032328.2522472-46-xiaoyao.li@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 25.01.24 04:23, Xiaoyao Li wrote: > Introduce memory_region_init_ram_guest_memfd() to allocate private > guset memfd on the MemoryRegion initialization. It's for the use case of > TDVF, which must be private on TDX case. > > Signed-off-by: Xiaoyao Li > --- > include/exec/memory.h | 6 ++++++ > system/memory.c | 27 +++++++++++++++++++++++++++ > 2 files changed, 33 insertions(+) > > diff --git a/include/exec/memory.h b/include/exec/memory.h > index f25959f6d30f..3a7f41b030e8 100644 > --- a/include/exec/memory.h > +++ b/include/exec/memory.h > @@ -1607,6 +1607,12 @@ bool memory_region_init_ram(MemoryRegion *mr, > uint64_t size, > Error **errp); > > +bool memory_region_init_ram_guest_memfd(MemoryRegion *mr, > + Object *owner, > + const char *name, > + uint64_t size, > + Error **errp); > + > /** > * memory_region_init_rom: Initialize a ROM memory region. > * > diff --git a/system/memory.c b/system/memory.c > index 74f647f2e56f..41049d3e4c9a 100644 > --- a/system/memory.c > +++ b/system/memory.c > @@ -3619,6 +3619,33 @@ bool memory_region_init_ram(MemoryRegion *mr, > return true; > } > > +bool memory_region_init_ram_guest_memfd(MemoryRegion *mr, > + Object *owner, > + const char *name, > + uint64_t size, > + Error **errp) > +{ > + DeviceState *owner_dev; > + > + if (!memory_region_init_ram_flags_nomigrate(mr, owner, name, size, > + RAM_GUEST_MEMFD, errp)) { > + return false; > + } > + > + memory_region_set_default_private(mr); It would be much cleaner to just pass the flag when initializing the memory region. Ideally, we can get rid of memory_region_set_default_private(). What you do in patch #33 feels like a layer violation. -- Cheers, David / dhildenb