From: Oscar Mateo Subject: Re: [PATCH 2/2] drm/i915/cnl: Fix SSEU Device Status. Date: Wed, 20 Sep 2017 12:49:15 -0700 Message-ID: <6bebcd5c-7610-17b5-38c0-0e32f2c2ddec@intel.com> References: <20170920183525.20530-1-rodrigo.vivi@intel.com> <20170920183525.20530-2-rodrigo.vivi@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1FAF46E1B7 for ; Wed, 20 Sep 2017 19:49:14 +0000 (UTC) In-Reply-To: <20170920183525.20530-2-rodrigo.vivi@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Rodrigo Vivi , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org CgpPbiAwOS8yMC8yMDE3IDExOjM1IEFNLCBSb2RyaWdvIFZpdmkgd3JvdGU6Cj4gQ05MIGFkZHMg YW4gZXh0cmEgcmVnaXN0ZXIgZm9yIHNsaWNlL3N1YnNsaWNlIGluZm9ybWF0aW9uLgo+IEFsdGhv dWdoIG5vIFNLVSBpcyBwbGFuZWQgd2l0aCBhbiBleHRyYSBzbGljZSBsZXQncyBhbHJlYWR5Cj4g aGFuZGxlIHRoaXMgZXh0cmEgcGllY2Ugb2YgaW5mb3JtYXRpb24gc28gd2UgZG9uJ3QgaGF2ZSB0 aGUKPiByaXNrIGluIGZ1dHVyZSBvZiBnZXR0aW5nIGEgcGFydCB0aGF0IG1pZ2h0IGhhdmUgY2hv c2VuIHRoaXMKPiBwYXJ0IG9mIHRoZSBkaWUgaW5zdGVhZCBvZiBvdGhlciBzbGljZXMgb3IgYW55 dGhpbmcgbGlrZSB0aGF0Lgo+Cj4gQWxzbyBpZiBzdWJzbGljZSBpcyBkaXNhYmxlZCB0aGUgaW5m b3JtYXRpb24gb2YgZXUgYWNrIGZvciB0aGF0Cj4gaXMgZ2FyYmFnZSwgc28gbGV0J3Mgc2tpcCBj aGVja3MgZm9yIGV1IGlmIHN1YnNsaWNlIGlzIGRpc2FibGVkCj4gYXMgd2Ugc2tpcCB0aGUgc3Vi c2xpY2UgaWYgc2xpY2UgaXMgZGlzYWJsZWQuCj4KPiBUaGUgcmVzdCBpcyBwcmV0dHkgbXVjaCBs aWtlIGdlbjkuCj4KPiB2MjogUmVtb3ZlIElTX0NBTk5PTkxBS0UgZnJvbSBnZW45IHN0YXR1cyBm dW5jdGlvbi4KPgo+IHYzOiBDb25zaWRlciBzX21heCA9IDYgYW5kIHNzX21heD00IHRvIHJ1biBv dmVyIGFsbCBwb3NzaWJsZQo+ICAgICAgc2xpY2VzIGFuZCBzdWJzbGljZXMgcG9zc2libGUgYnkg c3BlYy4gQWx0aG91Z2ggbm8gcmVhbAo+ICAgICAgaGFyZHdhcmUgd2lsbCBoYXZlIHRoYXQgbWFu eSBzbGljZXMvc3Vic2xpY2VzLgo+ICAgICAgVG8gbWF0Y2ggd2l0aCBzc2V1IGluZm8gaW5pdC4K CkV2ZW4gYmV0dGVyIDopCgo+IENjOiBPc2NhciBNYXRlbyA8b3NjYXIubWF0ZW9AaW50ZWwuY29t Pgo+IFNpZ25lZC1vZmYtYnk6IFJvZHJpZ28gVml2aSA8cm9kcmlnby52aXZpQGludGVsLmNvbT4K PiBSZXZpZXdlZC1ieTogT3NjYXIgTWF0ZW8gPG9zY2FyLm1hdGVvQGludGVsLmNvbT4KPiBTaWdu ZWQtb2ZmLWJ5OiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2aUBpbnRlbC5jb20+Cj4gLS0tCj4g ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYyB8IDU0ICsrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVn LmggICAgIHwgIDYgKysrKysKPiAgIDIgZmlsZXMgY2hhbmdlZCwgNTggaW5zZXJ0aW9ucygrKSwg MiBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2RlYnVnZnMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jCj4gaW5kZXgg Y2E2ZmE2ZDEyMmM2Li5lMTk3ZTVkOTkyNzcgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9kZWJ1Z2ZzLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rl YnVnZnMuYwo+IEBAIC00NTc1LDYgKzQ1NzUsNTQgQEAgc3RhdGljIHZvaWQgY2hlcnJ5dmlld19z c2V1X2RldmljZV9zdGF0dXMoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAg CX0KPiAgIH0KPiAgIAo+ICtzdGF0aWMgdm9pZCBnZW4xMF9zc2V1X2RldmljZV9zdGF0dXMoc3Ry dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICsJCQkJICAgICBzdHJ1Y3Qgc3NldV9k ZXZfaW5mbyAqc3NldSkKPiArewo+ICsJY29uc3Qgc3RydWN0IGludGVsX2RldmljZV9pbmZvICpp bmZvID0gSU5URUxfSU5GTyhkZXZfcHJpdik7Cj4gKwlpbnQgc19tYXggPSA2LCBzc19tYXggPSA0 Owo+ICsJaW50IHMsIHNzOwo+ICsJdTMyIHNfcmVnW3NfbWF4XSwgZXVfcmVnWzIgKiBzX21heF0s IGV1X21hc2tbMl07Cj4gKwo+ICsJZm9yIChzID0gMDsgcyA8IHNfbWF4OyBzKyspIHsKPiArCQlz X3JlZ1tzXSA9IEk5MTVfUkVBRChHRU4xMF9TTElDRV9QR0NUTF9BQ0socykpOwo+ICsJCWV1X3Jl Z1syICogc10gPSBJOTE1X1JFQUQoR0VOMTBfU1MwMV9FVV9QR0NUTF9BQ0socykpOwo+ICsJCWV1 X3JlZ1syICogcyArIDFdID0gSTkxNV9SRUFEKEdFTjEwX1NTMjNfRVVfUEdDVExfQUNLKHMpKTsK PiArCX0KPiArCj4gKwlldV9tYXNrWzBdID0gR0VOOV9QR0NUTF9TU0FfRVUwOF9BQ0sgfAo+ICsJ CSAgICAgR0VOOV9QR0NUTF9TU0FfRVUxOV9BQ0sgfAo+ICsJCSAgICAgR0VOOV9QR0NUTF9TU0Ff RVUyMTBfQUNLIHwKPiArCQkgICAgIEdFTjlfUEdDVExfU1NBX0VVMzExX0FDSzsKPiArCWV1X21h c2tbMV0gPSBHRU45X1BHQ1RMX1NTQl9FVTA4X0FDSyB8Cj4gKwkJICAgICBHRU45X1BHQ1RMX1NT Ql9FVTE5X0FDSyB8Cj4gKwkJICAgICBHRU45X1BHQ1RMX1NTQl9FVTIxMF9BQ0sgfAo+ICsJCSAg ICAgR0VOOV9QR0NUTF9TU0JfRVUzMTFfQUNLOwo+ICsKPiArCWZvciAocyA9IDA7IHMgPCBzX21h eDsgcysrKSB7Cj4gKwkJaWYgKChzX3JlZ1tzXSAmIEdFTjlfUEdDVExfU0xJQ0VfQUNLKSA9PSAw KQo+ICsJCQkvKiBza2lwIGRpc2FibGVkIHNsaWNlICovCj4gKwkJCWNvbnRpbnVlOwo+ICsKPiAr CQlzc2V1LT5zbGljZV9tYXNrIHw9IEJJVChzKTsKPiArCQlzc2V1LT5zdWJzbGljZV9tYXNrID0g aW5mby0+c3NldS5zdWJzbGljZV9tYXNrOwo+ICsKPiArCQlmb3IgKHNzID0gMDsgc3MgPCBzc19t YXg7IHNzKyspIHsKPiArCQkJdW5zaWduZWQgaW50IGV1X2NudDsKPiArCj4gKwkJCWlmICghKHNf cmVnW3NdICYgKEdFTjlfUEdDVExfU1NfQUNLKHNzKSkpKQo+ICsJCQkJLyogc2tpcCBkaXNhYmxl ZCBzdWJzbGljZSAqLwo+ICsJCQkJY29udGludWU7Cj4gKwo+ICsJCQlldV9jbnQgPSAyICogaHdl aWdodDMyKGV1X3JlZ1syICogcyArIHNzIC8gMl0gJgo+ICsJCQkJCSAgICAgICBldV9tYXNrW3Nz ICUgMl0pOwo+ICsJCQlzc2V1LT5ldV90b3RhbCArPSBldV9jbnQ7Cj4gKwkJCXNzZXUtPmV1X3Bl cl9zdWJzbGljZSA9IG1heF90KHVuc2lnbmVkIGludCwKPiArCQkJCQkJICAgICAgc3NldS0+ZXVf cGVyX3N1YnNsaWNlLAo+ICsJCQkJCQkgICAgICBldV9jbnQpOwo+ICsJCX0KPiArCX0KPiArfQo+ ICsKPiAgIHN0YXRpYyB2b2lkIGdlbjlfc3NldV9kZXZpY2Vfc3RhdHVzKHN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdiwKPiAgIAkJCQkgICAgc3RydWN0IHNzZXVfZGV2X2luZm8gKnNz ZXUpCj4gICB7Cj4gQEAgLTQ2MTAsNyArNDY1OCw3IEBAIHN0YXRpYyB2b2lkIGdlbjlfc3NldV9k ZXZpY2Vfc3RhdHVzKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgIAo+ICAg CQlzc2V1LT5zbGljZV9tYXNrIHw9IEJJVChzKTsKPiAgIAo+IC0JCWlmIChJU19HRU45X0JDKGRl dl9wcml2KSB8fCBJU19DQU5OT05MQUtFKGRldl9wcml2KSkKPiArCQlpZiAoSVNfR0VOOV9CQyhk ZXZfcHJpdikpCj4gICAJCQlzc2V1LT5zdWJzbGljZV9tYXNrID0KPiAgIAkJCQlJTlRFTF9JTkZP KGRldl9wcml2KS0+c3NldS5zdWJzbGljZV9tYXNrOwo+ICAgCj4gQEAgLTQ3MTYsOCArNDc2NCwx MCBAQCBzdGF0aWMgaW50IGk5MTVfc3NldV9zdGF0dXMoc3RydWN0IHNlcV9maWxlICptLCB2b2lk ICp1bnVzZWQpCj4gICAJCWNoZXJyeXZpZXdfc3NldV9kZXZpY2Vfc3RhdHVzKGRldl9wcml2LCAm c3NldSk7Cj4gICAJfSBlbHNlIGlmIChJU19CUk9BRFdFTEwoZGV2X3ByaXYpKSB7Cj4gICAJCWJy b2Fkd2VsbF9zc2V1X2RldmljZV9zdGF0dXMoZGV2X3ByaXYsICZzc2V1KTsKPiAtCX0gZWxzZSBp ZiAoSU5URUxfR0VOKGRldl9wcml2KSA+PSA5KSB7Cj4gKwl9IGVsc2UgaWYgKElTX0dFTjkoZGV2 X3ByaXYpKSB7Cj4gICAJCWdlbjlfc3NldV9kZXZpY2Vfc3RhdHVzKGRldl9wcml2LCAmc3NldSk7 Cj4gKwl9IGVsc2UgaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPj0gMTApIHsKPiArCQlnZW4xMF9z c2V1X2RldmljZV9zdGF0dXMoZGV2X3ByaXYsICZzc2V1KTsKPiAgIAl9Cj4gICAKPiAgIAlpbnRl bF9ydW50aW1lX3BtX3B1dChkZXZfcHJpdik7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfcmVnLmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oCj4gaW5k ZXggMWMyNTc3OTdjNTgzLi5hYzVjOGUwODg3OGQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9yZWcuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVn LmgKPiBAQCAtODAyMCwxMSArODAyMCwxNyBAQCBlbnVtIHsKPiAgICNkZWZpbmUgICBDSFZfRVUz MTFfUEdfRU5BQkxFCQkoMTw8MSkKPiAgIAoKSSdtIGFmcmFpZCB0aGUgZm9sbG93aW5nIG5vdyBy ZXF1aXJlcyBleHRyYSBkZWZpbmVzIGZvciBzbGljZSA9IDQgYW5kIDU6Cgo+ICAgI2RlZmluZSBH RU45X1NMSUNFX1BHQ1RMX0FDSyhzbGljZSkJX01NSU8oMHg4MDRjICsgKHNsaWNlKSoweDQpCj4g KyNkZWZpbmUgR0VOMTBfU0xJQ0VfUEdDVExfQUNLKHNsaWNlKQkoKHNsaWNlKSA9PSAzID8gX01N SU8oMHg4MDgwKSA6IFwKPiArCQkJCQkgR0VOOV9TTElDRV9QR0NUTF9BQ0soKHNsaWNlKSkpCgow eDgwODAgKyAoc2xpY2UpKjB4NAoKPiAgICNkZWZpbmUgICBHRU45X1BHQ1RMX1NMSUNFX0FDSwkJ KDEgPDwgMCkKPiAgICNkZWZpbmUgICBHRU45X1BHQ1RMX1NTX0FDSyhzdWJzbGljZSkJKDEgPDwg KDIgKyAoc3Vic2xpY2UpKjIpKQo+ICAgCj4gICAjZGVmaW5lIEdFTjlfU1MwMV9FVV9QR0NUTF9B Q0soc2xpY2UpCV9NTUlPKDB4ODA1YyArIChzbGljZSkqMHg4KQo+ICsjZGVmaW5lIEdFTjEwX1NT MDFfRVVfUEdDVExfQUNLKHNsaWNlKQkoKHNsaWNlKSA9PSAzID8gX01NSU8oMHg4MDhjKSA6IFwK PiArCQkJCQkgR0VOOV9TUzAxX0VVX1BHQ1RMX0FDSygoc2xpY2UpKSkKCjB4ODA4YyArIChzbGlj ZSkqMHg4Cgo+ICAgI2RlZmluZSBHRU45X1NTMjNfRVVfUEdDVExfQUNLKHNsaWNlKQlfTU1JTygw eDgwNjAgKyAoc2xpY2UpKjB4OCkKPiArI2RlZmluZSBHRU4xMF9TUzIzX0VVX1BHQ1RMX0FDSyhz bGljZSkJKChzbGljZSkgPT0gMyA/IF9NTUlPKDB4ODA5MCkgOiBcCj4gKwkJCQkJIEdFTjlfU1My M19FVV9QR0NUTF9BQ0soKHNsaWNlKSkpCgoweDgwOTAgKyAoc2xpY2UpKjB4OAoKCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5n IGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=