Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B896C433E0 for ; Tue, 9 Feb 2021 20:57:46 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 51FE964E6F for ; Tue, 9 Feb 2021 20:57:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 51FE964E6F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=dm-devel-bounces@redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-101-Vl_pseruMPiBlUoRWnbdmQ-1; Tue, 09 Feb 2021 15:57:40 -0500 X-MC-Unique: Vl_pseruMPiBlUoRWnbdmQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7D41480196E; Tue, 9 Feb 2021 20:57:34 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D386160C04; Tue, 9 Feb 2021 20:57:33 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 4C8954E58D; Tue, 9 Feb 2021 20:57:31 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 119KvS63015188 for ; Tue, 9 Feb 2021 15:57:28 -0500 Received: by smtp.corp.redhat.com (Postfix) id 83A612026D3C; Tue, 9 Feb 2021 20:57:28 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7B7AD2026D49 for ; Tue, 9 Feb 2021 20:57:26 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1AC70803D54 for ; Tue, 9 Feb 2021 20:57:26 +0000 (UTC) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by relay.mimecast.com with ESMTP id us-mta-460-FAYCwFyDMO6JaOj54DnLWw-1; Tue, 09 Feb 2021 15:57:21 -0500 X-MC-Unique: FAYCwFyDMO6JaOj54DnLWw-1 Received: from [192.168.86.31] (c-71-197-163-6.hsd1.wa.comcast.net [71.197.163.6]) by linux.microsoft.com (Postfix) with ESMTPSA id DDD8820B6C40; Tue, 9 Feb 2021 12:57:19 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com DDD8820B6C40 To: Mimi Zohar , stephen.smalley.work@gmail.com, casey@schaufler-ca.com, agk@redhat.com, snitzer@redhat.com, gmazyland@gmail.com, paul@paul-moore.com References: <20210130004519.25106-1-tusharsu@linux.microsoft.com> <27f73411fc1d6ce6dd16a29344d729d9aa760250.camel@linux.ibm.com> <27a4592c3b75861d2b9c8fb1511f593aa987222c.camel@linux.ibm.com> <38ba5889d517ee010a6bf370f8892059dd7d3bfe.camel@linux.ibm.com> From: Tushar Sugandhi Message-ID: <6bf1d3b1-522a-4df7-b18b-3789855b5740@linux.microsoft.com> Date: Tue, 9 Feb 2021 12:57:19 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <38ba5889d517ee010a6bf370f8892059dd7d3bfe.camel@linux.ibm.com> X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: dm-devel@redhat.com Cc: sashal@kernel.org, dm-devel@redhat.com, selinux@vger.kernel.org, jmorris@namei.org, linux-kernel@vger.kernel.org, nramas@linux.microsoft.com, linux-security-module@vger.kernel.org, tyhicks@linux.microsoft.com, linux-integrity@vger.kernel.org Subject: Re: [dm-devel] [PATCH 0/3] support for duplicate measurement of integrity critical data X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" On 2021-02-09 10:53 a.m., Mimi Zohar wrote: > On Tue, 2021-02-09 at 10:23 -0800, Tushar Sugandhi wrote: >>> On Mon, 2021-02-08 at 15:22 -0500, Mimi Zohar wrote: >>>> On Fri, 2021-01-29 at 16:45 -0800, Tushar Sugandhi wrote: >>>>> IMA does not measure duplicate buffer data since TPM extend is a very >>>>> expensive operation. However, in some cases for integrity critical >>>>> data, the measurement of duplicate data is necessary to accurately >>>>> determine the current state of the system. Eg, SELinux state changing >>>>> from 'audit', to 'enforcing', and back to 'audit' again. In this >>>>> example, currently, IMA will not measure the last state change to >>>>> 'audit'. This limits the ability of attestation services to accurately >>>>> determine the current state of the integrity critical data on the >>>>> system. >>>>> >>>>> This series addresses this gap by providing the ability to measure >>>>> duplicate entries for integrity critical data, driven by policy. >>>> >>>> The same reason for re-measuring buffer data is equally applicable to >>>> files. In both cases, the file or the buffer isn't re-measured if it >>>> already exists in the htable. Please don't limit this patch set to >>>> just buffer data. >>> >> Agreed. I wasn't sure if you wanted the support for files, or other >> buffer measurement scenarios, except critical data. So I started the >> implementation with supporting just critical data. Happy to extend it >> to files and other buffer measurement scenarios as you suggested. >> >>> Instead of making the change on a per measurement rule basis, disabling >>> "htable" would be the simplest way of forcing re-measurements. All >>> that would be needed is a new Kconfig (e.g. CONFIG_IMA_DISABLE_HTABLE) >>> and the associated test in ima_add_template_entry(). >>> >> Agreed. Earlier I wasn't sure if you wanted allow_dup support for all >> the scenarios. Now that it is clear, I will implement it as you >> suggested. Thank you so much for the pointers. Appreciate it. > > There are two different solutions - per measurement rule, disabling > htable - being discussed. Disabling htable requires miminumal > changes. Which version are you thinking of implementing? > I am thinking of implementing "disabling 'htable' using a new Kconfig (e.g. CONFIG_IMA_DISABLE_HTABLE)". That is, not using the var ima_htable or ima_lookup_digest_entry() if that CONFIG is set. So the duplicate measurements are allowed when the CONFIG is set. This would cover all the measurement scenarios through a single CONFIG setting. I am not planning to implement it as a "per measurement rule". Sorry it wasn't clear in my earlier response. Thanks, Tushar > thanks, > > Mimi > -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel