From: Chris Wilson Subject: Re: [PATCH 4/4 v2] drm/i915: Never read FORCEWAKE Date: Sun, 02 Sep 2012 09:41:44 +0100 Message-ID: <6c3329$5q3u4c@orsmga002.jf.intel.com> References: <1346565590-1760-1-git-send-email-ben@bwidawsk.net> <1346565590-1760-4-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 7B13E9E7E1 for ; Sun, 2 Sep 2012 01:42:10 -0700 (PDT) In-Reply-To: <1346565590-1760-4-git-send-email-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org Cc: Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On Sat, 1 Sep 2012 22:59:50 -0700, Ben Widawsky wrote: > The same designer from the previous patch has told us to never read > FORCEWAKE. We only do this for the POSTING_READ(), so simply change that > to something within the same cacheline (for no reason in particular > other than it sounds nice). In the _mt case we can leverage > the gtfifodbg check for the POSTING_READ. The first two are Reviewed-by: Chris Wilson The real meat of the change in the second two look good, so Acked-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre