Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C0EF7D29DE4 for ; Tue, 13 Jan 2026 07:33:57 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vfYuZ-0001X0-Ti; Tue, 13 Jan 2026 02:33:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfYuU-0001Pf-O2 for qemu-devel@nongnu.org; Tue, 13 Jan 2026 02:33:51 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfYuT-00078J-Bp for qemu-devel@nongnu.org; Tue, 13 Jan 2026 02:33:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768289628; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=LgrnZn9DpnmLbRcEamTKGlLki0a/irUt6JBO2xg4gnc=; b=H1Vtj4hnXmv2Ojen33XNDxwt9+ExhNsDfMbwHI1ww27fTNA9vvjxsXp5j89Z05PIVjmsej rMR4LF3oFTDyfIn8ucKTqFhN2U3xlgmhVEwuSsy7QwyQTH88n/vDB83HUDehE7Nm9VZ8pA fyHvwBXb2HprzA+iLy1uLktb0wJLXKY= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-373-LT6bXiApPkqLm_hytq5Hgw-1; Tue, 13 Jan 2026 02:33:47 -0500 X-MC-Unique: LT6bXiApPkqLm_hytq5Hgw-1 X-Mimecast-MFC-AGG-ID: LT6bXiApPkqLm_hytq5Hgw_1768289626 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-88a3356a310so178322306d6.3 for ; Mon, 12 Jan 2026 23:33:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768289626; x=1768894426; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=LgrnZn9DpnmLbRcEamTKGlLki0a/irUt6JBO2xg4gnc=; b=UjQU6v+pqp2xJrpdDIqqIfx6qG4aF0Sii2oW/MVKEZCIiwrNFxw+1iK4n1WIXIdVHx WL0jmSVn/2xwpwueRRxQ5jwyGOs75W7dwM9oJIqvpj24bQlz6VIkux4PTYcKSIj7w4wU b0Y2IZt/firJdNFNY8Ej7P1WcqP38CpNjzeNcbE/vTFr8TTYaWsHLdufmEDmJItclcZE xtuhIWj5BUdLEM18Mn2f35DpPPDU8KUy0TKZ++w/WODbdN7hEadpD7X3Wu+2kceCoXOI xf3TTu5VhvNd8CBhGclROlQMxG/JJbxJG3kWYoCm6jmhgdRUm7QW2vwEA3V99qp4BlTU Hgsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768289626; x=1768894426; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LgrnZn9DpnmLbRcEamTKGlLki0a/irUt6JBO2xg4gnc=; b=mEX97vDHM1tdR0KRZ5yZ/zOXzqPD/ZkugZkTrVRvRSC7hYLzOCkzIg6C/wv5YFUW49 cV+JAH43VB619t6vaGV9W2FqqDFWWHL1xqoKqjrHMz5UY+/1INnuJXp+eR+Gzv4vCHZD qHwnj4rDoTvwt/Wml+bR6ZzRFbWz0M8iG8bB/gPhNr86SY84o0mAdxeUpvWT7bPQNFYK GUmlF/wZ1T9Dmy/sAxv8NmM8J9WxLB9KJA/TMF817Uewk2WyTrWnhLMMrTA3zZNsvikZ xlHa/cHZUo6qCoLTTqxl/SuV8Dz60lNEwrbPWcy33RlBZEvhkXKcEMIet0n/mlCBz4c2 hiNg== X-Forwarded-Encrypted: i=1; AJvYcCV1jka/pxSxSRsEfMswhTny6ni/L3YfChxi5t209DgMTz0Lb9J7EYPTSNbSpqM89sxbUlSmNW4QjiTN@nongnu.org X-Gm-Message-State: AOJu0Yxx89wf3VLarbNBU8gwTLzHlj2wJc2Jgjr4Me7RkqVRv4whZuHI 5mpOesEhMbjYSwEfrSELjAiqqIMlOK0n0BtiE0OI5lu1H4vjWcsECt1LJNtwa7QPsrUKeLcMWfH FwbZ6iBafodM+qI4ftf28z6gKRGMSw4mBLPIshL+r9tKjOsfA4dCJYQ3c X-Gm-Gg: AY/fxX6V+JlCCVuKkJGaf3IYKS4aVpyy3GKar38rS0igUroBlPF23B2PG8jFGlApW2y nA4Nz3Dq533KDrzJSquD6RvE/HINBf7qmXyGo5xlKxS4HaTqdjy4M0AaDrsj7EyeZvz/b7Adjzb Tkjg6ZPcITCthOMoisLXZerp6X1L215lI1aL2/K8PHs0NKk2+W7mCzaD4cPNx1YdtIEMte9v3id Ly65UZMVQOZFek2MgO/cjVsT8AO4L5+4RAPcMv8xiOT5ZMKkwNaGEWi28gROBOuxx3TYcqGtYmZ UePOg/Yk/5J3+t0dmoliABnThNfwcXd7LbdyB8+vhddfUy/C9/BPqNhB34UyrRcluES/XvybhCh w1lfTd2oQQT109zDNCVm7PuyNd146ym6zam4zJ3tP8IjFosAn X-Received: by 2002:a05:6214:4688:b0:793:dce5:4540 with SMTP id 6a1803df08f44-89084174a93mr343237896d6.2.1768289626546; Mon, 12 Jan 2026 23:33:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IFTO+vcNtUUyZc9XJlUqNHg69uPO29vheBAv0blidz1OhShubUT8lUJpTn4gKXhopc2tVbnaA== X-Received: by 2002:a05:6214:4688:b0:793:dce5:4540 with SMTP id 6a1803df08f44-89084174a93mr343237676d6.2.1768289626204; Mon, 12 Jan 2026 23:33:46 -0800 (PST) Received: from ?IPV6:2a01:e0a:280:24f0:9db0:474c:ff43:9f5c? ([2a01:e0a:280:24f0:9db0:474c:ff43:9f5c]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-89077267e14sm152742256d6.49.2026.01.12.23.33.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Jan 2026 23:33:45 -0800 (PST) Message-ID: <6c4ecbd6-ffeb-4e11-a570-e7f995b5f6cd@redhat.com> Date: Tue, 13 Jan 2026 08:33:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] tests/rcutorture: Fix build error To: Richard Henderson , qemu-devel@nongnu.org Cc: Paolo Bonzini References: <20260112163350.1251114-1-clg@redhat.com> <9bf69b0e-17b6-4016-965b-7cb3582b3b3e@linaro.org> Content-Language: en-US, fr From: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= Autocrypt: addr=clg@redhat.com; keydata= xsFNBFu8o3UBEADP+oJVJaWm5vzZa/iLgpBAuzxSmNYhURZH+guITvSySk30YWfLYGBWQgeo 8NzNXBY3cH7JX3/a0jzmhDc0U61qFxVgrPqs1PQOjp7yRSFuDAnjtRqNvWkvlnRWLFq4+U5t yzYe4SFMjFb6Oc0xkQmaK2flmiJNnnxPttYwKBPd98WfXMmjwAv7QfwW+OL3VlTPADgzkcqj 53bfZ4VblAQrq6Ctbtu7JuUGAxSIL3XqeQlAwwLTfFGrmpY7MroE7n9Rl+hy/kuIrb/TO8n0 ZxYXvvhT7OmRKvbYuc5Jze6o7op/bJHlufY+AquYQ4dPxjPPVUT/DLiUYJ3oVBWFYNbzfOrV RxEwNuRbycttMiZWxgflsQoHF06q/2l4ttS3zsV4TDZudMq0TbCH/uJFPFsbHUN91qwwaN/+ gy1j7o6aWMz+Ib3O9dK2M/j/O/Ube95mdCqN4N/uSnDlca3YDEWrV9jO1mUS/ndOkjxa34ia 70FjwiSQAsyIwqbRO3CGmiOJqDa9qNvd2TJgAaS2WCw/TlBALjVQ7AyoPEoBPj31K74Wc4GS Rm+FSch32ei61yFu6ACdZ12i5Edt+To+hkElzjt6db/UgRUeKfzlMB7PodK7o8NBD8outJGS tsL2GRX24QvvBuusJdMiLGpNz3uqyqwzC5w0Fd34E6G94806fwARAQABzSJDw6lkcmljIExl IEdvYXRlciA8Y2xnQHJlZGhhdC5jb20+wsGRBBMBCAA7FiEEoPZlSPBIlev+awtgUaNDx8/7 7KEFAmTLlVECGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQUaNDx8/77KG0eg// S0zIzTcxkrwJ/9XgdcvVTnXLVF9V4/tZPfB7sCp8rpDCEseU6O0TkOVFoGWM39sEMiQBSvyY lHrP7p7E/JYQNNLh441MfaX8RJ5Ul3btluLapm8oHp/vbHKV2IhLcpNCfAqaQKdfk8yazYhh EdxTBlzxPcu+78uE5fF4wusmtutK0JG0sAgq0mHFZX7qKG6LIbdLdaQalZ8CCFMKUhLptW71 xe+aNrn7hScBoOj2kTDRgf9CE7svmjGToJzUxgeh9mIkxAxTu7XU+8lmL28j2L5uNuDOq9vl hM30OT+pfHmyPLtLK8+GXfFDxjea5hZLF+2yolE/ATQFt9AmOmXC+YayrcO2ZvdnKExZS1o8 VUKpZgRnkwMUUReaF/mTauRQGLuS4lDcI4DrARPyLGNbvYlpmJWnGRWCDguQ/LBPpbG7djoy k3NlvoeA757c4DgCzggViqLm0Bae320qEc6z9o0X0ePqSU2f7vcuWN49Uhox5kM5L86DzjEQ RHXndoJkeL8LmHx8DM+kx4aZt0zVfCHwmKTkSTQoAQakLpLte7tWXIio9ZKhUGPv/eHxXEoS 0rOOAZ6np1U/xNR82QbF9qr9TrTVI3GtVe7Vxmff+qoSAxJiZQCo5kt0YlWwti2fFI4xvkOi V7lyhOA3+/3oRKpZYQ86Frlo61HU3r6d9wzOwU0EW7yjdQEQALyDNNMw/08/fsyWEWjfqVhW pOOrX2h+z4q0lOHkjxi/FRIRLfXeZjFfNQNLSoL8j1y2rQOs1j1g+NV3K5hrZYYcMs0xhmrZ KXAHjjDx7FW3sG3jcGjFW5Xk4olTrZwFsZVUcP8XZlArLmkAX3UyrrXEWPSBJCXxDIW1hzwp bV/nVbo/K9XBptT/wPd+RPiOTIIRptjypGY+S23HYBDND3mtfTz/uY0Jytaio9GETj+fFis6 TxFjjbZNUxKpwftu/4RimZ7qL+uM1rG1lLWc9SPtFxRQ8uLvLOUFB1AqHixBcx7LIXSKZEFU CSLB2AE4wXQkJbApye48qnZ09zc929df5gU6hjgqV9Gk1rIfHxvTsYltA1jWalySEScmr0iS YBZjw8Nbd7SxeomAxzBv2l1Fk8fPzR7M616dtb3Z3HLjyvwAwxtfGD7VnvINPbzyibbe9c6g LxYCr23c2Ry0UfFXh6UKD83d5ybqnXrEJ5n/t1+TLGCYGzF2erVYGkQrReJe8Mld3iGVldB7 JhuAU1+d88NS3aBpNF6TbGXqlXGF6Yua6n1cOY2Yb4lO/mDKgjXd3aviqlwVlodC8AwI0Sdu jWryzL5/AGEU2sIDQCHuv1QgzmKwhE58d475KdVX/3Vt5I9kTXpvEpfW18TjlFkdHGESM/Jx IqVsqvhAJkalABEBAAHCwV8EGAECAAkFAlu8o3UCGwwACgkQUaNDx8/77KEhwg//WqVopd5k 8hQb9VVdk6RQOCTfo6wHhEqgjbXQGlaxKHoXywEQBi8eULbeMQf5l4+tHJWBxswQ93IHBQjK yKyNr4FXseUI5O20XVNYDJZUrhA4yn0e/Af0IX25d94HXQ5sMTWr1qlSK6Zu79lbH3R57w9j hQm9emQEp785ui3A5U2Lqp6nWYWXz0eUZ0Tad2zC71Gg9VazU9MXyWn749s0nXbVLcLS0yop s302Gf3ZmtgfXTX/W+M25hiVRRKCH88yr6it+OMJBUndQVAA/fE9hYom6t/zqA248j0QAV/p LHH3hSirE1mv+7jpQnhMvatrwUpeXrOiEw1nHzWCqOJUZ4SY+HmGFW0YirWV2mYKoaGO2YBU wYF7O9TI3GEEgRMBIRT98fHa0NPwtlTktVISl73LpgVscdW8yg9Gc82oe8FzU1uHjU8b10lU XOMHpqDDEV9//r4ZhkKZ9C4O+YZcTFu+mvAY3GlqivBNkmYsHYSlFsbxc37E1HpTEaSWsGfA HQoPn9qrDJgsgcbBVc1gkUT6hnxShKPp4PlsZVMNjvPAnr5TEBgHkk54HQRhhwcYv1T2QumQ izDiU6iOrUzBThaMhZO3i927SG2DwWDVzZltKrCMD1aMPvb3NU8FOYRhNmIFR3fcalYr+9gD uVKe8BVz4atMOoktmt0GWTOC8P4= In-Reply-To: <9bf69b0e-17b6-4016-965b-7cb3582b3b3e@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 1/12/26 22:58, Richard Henderson wrote: > On 1/13/26 03:33, Cédric Le Goater wrote: >> Newer gcc compiler (version 16.0.0 20260103 (Red Hat 16.0.0-0) (GCC)) >> detects an unused variable error: >> >>    ../tests/unit/rcutorture.c: In function ‘rcu_read_stress_test’: >>    ../tests/unit/rcutorture.c:251:18: error: variable ‘garbage’ set but not used [-Werror=unused-but-set-variable=] >>      251 |     volatile int garbage = 0; >>          |                  ^~~~~~~ >> >> Since the 'garbage' variable is used to generate memory reads from the >> CPU while holding the RCU lock, it can not be removed. Tag it as >> ((unused)) instead to silence the compiler warnings/errors. > > That shouldn't happen for a volatile variable: please report this as a compiler bug. Yes. That seemed to defeat the purpose. > > That said, gcc-16 has been released, so > Reviewed-by: Richard Henderson Applied to vfio-next. Thanks, C. > > > r~ > >> >> Signed-off-by: Cédric Le Goater >> --- >>   tests/unit/rcutorture.c | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tests/unit/rcutorture.c b/tests/unit/rcutorture.c >> index 7662081683f5d781da74402113b73884780b1243..2f19d479a3f210cbca19205a0656eda1f4c2e5a7 100644 >> --- a/tests/unit/rcutorture.c >> +++ b/tests/unit/rcutorture.c >> @@ -248,7 +248,7 @@ static void *rcu_read_stress_test(void *arg) >>       int pc; >>       long long n_reads_local = 0; >>       long long rcu_stress_local[RCU_STRESS_PIPE_LEN + 1] = { 0 }; >> -    volatile int garbage = 0; >> +    volatile int garbage __attribute__ ((unused)) = 0; >>       rcu_register_thread(); >