From: "plaisthos (Code Review)" Date: Fri, 6 Mar 2026 13:36:56 +0000 In-Reply-To: References: Reply-To: arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <6d13640838b6d43b0eabf5f6bb969da54caef946-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="oDXnGQzPN18="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: Optimise iterating over all clients by remembering highest peer id List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: flichtenheld , openvpn-devel --oDXnGQzPN18= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld. plaisthos has posted comments on this change by plaisthos. ( http://gerrit.= openvpn.net/c/openvpn/+/1557?usp=3Demail ) Change subject: Optimise iterating over all clients by remembering highest = peer id ...................................................................... Patch Set 1: (1 comment) File src/openvpn/multi.c: http://gerrit.openvpn.net/c/openvpn/+/1557/comment/54c3fb30_19036b99?usp=3D= email : PS1, Line 4109: if (mi->context.c2.tls_multi->peer_id > m->max_peerid) > I would suggest moving this code below the ASSERT. In the end it makes no= difference. [=E2=80=A6] done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1557?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: If797f3fe178fba3f43fb12898e5484bfb38f05c3 Gerrit-Change-Number: 1557 Gerrit-PatchSet: 1 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Fri, 06 Mar 2026 13:36:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld --oDXnGQzPN18= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: flichtenheld.

View = Change

1 comment:

    =
  • File src/openvpn/multi.c:

    • Patch Set #1, L= ine 4109: if (mi-&g= t;context.c2.tls_multi->peer_id > m->max_peerid)

      I would suggest moving this code below the ASSERT. In the end it makes= no difference. [=E2=80=A6]

      done

To view, visit change 1557. To unsubscribe, or for help writing mail filters= , visit settings= .

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: If797f3fe178fba3f43fb12898e5= 484bfb38f05c3
Gerrit-Change-Number: 1557
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Comment-Date: Fri, 06 Mar 2026 13:36:56= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <frank@...1186...= .2641...>
= --oDXnGQzPN18=--