From: "cron2 (Code Review)" Date: Wed, 3 Jan 2024 22:45:10 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <6d1b9c0efaac3dc6cd3bbffa812b8ede9f26b2db-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="XwQxwCeEpF8="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: Check PRF availability on initialisation and add --force-tls-key-mate... List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: flichtenheld , openvpn-devel --XwQxwCeEpF8= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/460?usp=3Demail ) The change is no longer submittable: Code-Review is unsatisfied now. Change subject: Check PRF availability on initialisation and add --force-tl= s-key-material-export ...................................................................... Patch Set 8: Code-Review-2 (2 comments) Patchset: PS8: sorry... found another one :-( File src/openvpn/crypto.c: http://gerrit.openvpn.net/c/openvpn/+/460/comment/131b2f38_d4640bad : PS8, Line 1809: return (ret && memcmp(out, expected_out, sizeof(out)) != =3D 0); It pains me to return to "-2" again, but there is something really weird go= ing on here - to see what happens if the PRF fails, I changed "expected_out= [3] to "2" in my tree, and it still succeeds. Wat. So I look at the compa= rison, and we should be checking for `=3D=3D 0` here ("out =3D=3D expected_= out", this is not strcmp()...). So I fired up gdb with -O0, and this is what it says... ``` (gdb) print ret $1 =3D 1 (gdb) print out $2 =3D "qD\376%@su\225" (gdb) print expected_out $3 =3D "\340_\037\001\000\000\000" ``` -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/460?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I04f8c7c413e7cb62c726262feee6ca89c7e86c70 Gerrit-Change-Number: 460 Gerrit-PatchSet: 8 Gerrit-Owner: plaisthos Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Wed, 03 Jan 2024 22:45:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --XwQxwCeEpF8= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, plaisthos.

Patch set 8:Code-Review -2=

The change is no longer submittable: Code-Review is unsatisfied now.=

Vi= ew Change

2 comments:

  • Patchset:

    <= /li>
  • File src/openvpn/crypto.c:

    <= ul style=3D"list-style: none; padding: 0;">
  • Patch Set #8, Line 1809= : return (ret &= & memcmp(out, expected_out, sizeof(out)) !=3D 0);

    It pains me to return to &q= uot;-2" again, but there is something really weird going on here - to = see what happens if the PRF fails, I changed "expected_out[3] to "= ;2" in my tree, and it still succeeds. Wat. So I look at the compari= son, and we should be checking for `=3D=3D 0` here ("out =3D=3D expect= ed_out", this is not strcmp()...).

    So I fired up gdb with -O0, and this is what it = says...

    ```(gdb) print ret
    $1 =3D 1
    (gdb) print out
    $2 =3D "qD\376%@su= \225"
    (gdb) print expected_out
    $3 =3D "\340_\037\001\000\00= 0\000"
    ```

To view, visit change 460. To unsub= scribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I04f8c7c413e7cb62c726262feee= 6ca89c7e86c70
Gerrit-Change-Number: 460
Gerrit-PatchSet: 8
Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Comment-Date: Wed, 03 Jan 2024 22:45:10= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--XwQxwCeEpF8=--