Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CE94C433DF for ; Wed, 14 Oct 2020 16:02:30 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 89CAD20B1F for ; Wed, 14 Oct 2020 16:02:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="PeU8k3Qg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 89CAD20B1F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.6824.17953 (Exim 4.92) (envelope-from ) id 1kSjEG-0002n0-Sh; Wed, 14 Oct 2020 16:02:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 6824.17953; Wed, 14 Oct 2020 16:02:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kSjEG-0002mt-PY; Wed, 14 Oct 2020 16:02:16 +0000 Received: by outflank-mailman (input) for mailman id 6824; Wed, 14 Oct 2020 16:02:15 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kSjEF-0002mo-NG for xen-devel@lists.xenproject.org; Wed, 14 Oct 2020 16:02:15 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c901b96e-ee31-4c5b-8169-8631ed022c1f; Wed, 14 Oct 2020 16:02:14 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id EFF69AB95; Wed, 14 Oct 2020 16:02:13 +0000 (UTC) Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kSjEF-0002mo-NG for xen-devel@lists.xenproject.org; Wed, 14 Oct 2020 16:02:15 +0000 X-Inumbo-ID: c901b96e-ee31-4c5b-8169-8631ed022c1f Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c901b96e-ee31-4c5b-8169-8631ed022c1f; Wed, 14 Oct 2020 16:02:14 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1602691334; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TM75gjrOKOQOYIVqj36yGiifNPOCac22GvcGkd56HZQ=; b=PeU8k3QgW50o68hEKqdxQyLymApfVqrPafynzrrvPWhGETNQnFZBavDowbuQR3+zXt91ap 7BgnN73O7qhjypDFDrKmPrOqbEGPcsxJoYc+Jwc51AxrGYyswi3qnx7v0aGSEnatw0Jx1k +OMNGUNmE/TMSrJO2TyasiPyQ1JCnqo= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id EFF69AB95; Wed, 14 Oct 2020 16:02:13 +0000 (UTC) Subject: Re: [PATCH] libelf: Handle PVH kernels lacking ENTRY elfnote To: Jason Andryuk Cc: xen-devel@lists.xenproject.org, Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu References: <20201014153150.83875-1-jandryuk@gmail.com> From: Jan Beulich Message-ID: <6d373cae-c7dc-e109-1df3-ccbbe4bdd9c8@suse.com> Date: Wed, 14 Oct 2020 18:02:12 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <20201014153150.83875-1-jandryuk@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 14.10.2020 17:31, Jason Andryuk wrote: > Linux kernels only have an ENTRY elfnote when built with CONFIG_PV. A > kernel build CONFIG_PVH=y CONFIG_PV=n lacks the note. In this case, > virt_entry will be UNSET_ADDR, overwritten by the ELF header e_entry, > and fail the check against the virt address range. > > Change the code to only check virt_entry against the virtual address > range if it was set upon entry to the function. Not checking at all seems wrong to me. The ELF spec anyway says "virtual address", so an out of bounds value is at least suspicious. > Maybe the overwriting of virt_entry could be removed, but I don't know > if there would be unintended consequences where (old?) kernels don't > have an elfnote, but do have an in-range e_entry? The failing kernel I > just looked at has an e_entry of 0x1000000. And if you dropped the overwriting, what entry point would we use in the absence of an ELF note? I'd rather put up the option of adjusting the entry (or the check), if it looks like a valid physical address. Jan