From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 3/4] drm/amdgpu: don't return when ring not ready for fill_buffer Date: Thu, 1 Mar 2018 09:41:26 +0100 Message-ID: <6dedfc7f-cf69-676f-463d-be52cda1b1bb@amd.com> References: <1519802463-9090-1-git-send-email-Monk.Liu@amd.com> <1519802463-9090-3-git-send-email-Monk.Liu@amd.com> <01879d0d-edea-680e-c9f2-1005d94f1dfd@gmail.com> <3a8945f9-848e-dd19-373d-5dddc69f76cb@amd.com> <7af9b6fb-28e8-4e25-5d4a-5b566a00cbea@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "Liu, Monk" , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" PiBJZiB3ZSBhcmUgaW4gZ3B1IHJlc3Qgc3RhZ2UsIHdlIGNhbiBsZXQgU0RNQSBqb2IgbGl2ZSB3 aXRoIHRoZSBjYXNlIG9mIHJpbmcgbm90IHJlYWR5LCAgY2FuIHlvdSBwb2ludCBvdXQgd2hlcmUg aXMgdGhlIHByb2JsZW0gPwphbWRncHVfZXZpY3RfZmxhZ3MoKSBhbmQgYW1kZ3B1X2JvX21vdmUo KSBuZWVkcyB0byBrbm93IGlmIHRoZSBTRE1BIHJpbmcgCmlzIGF2YWlsYWJsZSBkdXJpbmcgc3Vz cGVuZC9yZXN1bWUuCgpFLmcuIHN1c3BlbmQgd29ya3MgYXMgdGhpczoKMS4gRXZpY3QgYWxsIG5v cm1hbCBCT3MgZnJvbSBWUkFNIHVzaW5nIHRoZSBTRE1BLgoyLiBEaXNhYmxlIFNETUEsIEdBUlQs IFBTUCBldGMuLi4gZS5nLiBkaXNhYmxlIHRoZSBoYXJkd2FyZS4KMy4gVW5waW4gYWxsIEJPcyBp biBWUkFNIHVzZWQgYnkgaGFyZHdhcmUgZW5naW5lcywgZS5nLiB0aGUgR0FSVCB0YWJsZSwgCmZp cm13YXJlIGV0Yy4uLgo0LiBFdmljdCBhbGwgcmVtYWluaW5nIEJPcyBmcm9tIFZSQU0gdXNpbmcg Q1BVIGNvcGllcy4KClJlc3VtZSB3b3JrcyB0aGUgb3RoZXIgd2F5IGFyb3VuZDoKMS4gTW92ZSBh bGwgQk9zIGZvciBHQVJUIHRhYmxlIGFuZCBmaXJtd2FyZSBiYWNrIGludG8gVlJBTSB1c2luZyBD UFUgY29waWVzLgoyLiBQaW4gdGhvc2UgQk9zIGluIFZSQU0gYW5kIGVuYWJsZSB0aGUgaGFyZHdh cmUuCjMuIFVzZSB0aGUgU0RNQSB0byBtb3ZlIGJhY2sgYWxsIG90aGVyIEJPcyBpbnRvIFZSQU0u CgpUbyBmaWd1cmUgb3V0IGlmIHdlIHNob3VsZCB1c2UgdGhlIENQVSBjb3B5IG9yIHRoZSBTRE1B IHRoZSByaW5nLT5yZWFkeSAKZmxhZyBpcyB1c2VkLiBTbyByZW1vdmluZyB0aGlzIGNoZWNrIGlz IHJlYWxseSBhIG5vLWdvIGJlY2F1c2UgaXQgd291bGQgCmJyZWFrIHN1c3BlbmQvcmVzdW1lLgoK VGhlIG9ubHkgb3RoZXIgYWx0ZXJuYXRpdmUgSSBjYW4gc2VlIGlzIHRvIGFkZCBhIHNlcGFyYXRl IGZsYWcgaW4gCmFtZGdwdV9tbWFuIGlmIGJ1ZmZlcl9mdW5jcyBzaG91bGQgYmUgdXNlZCBvciBu b3QuIFNlZSBhbGwgdGhlIGNhbGxlcnMgCm9mIGFtZGdwdV90dG1fc2V0X2FjdGl2ZV92cmFtX3Np emUoKSBhcyB3ZWxsLgoKU29tZXRoaW5nIGxpa2UgcmVuYW1pbmcgYW1kZ3B1X3R0bV9zZXRfYWN0 aXZlX3ZyYW1fc2l6ZSgpIGludG8gCmFtZGdwdV90dG1fc2V0X2J1ZmZlcl9mdW5jc19yZWFkKCkg YW5kIGlnbm9yaW5nIGFueSBjaGFuZ2UgaWYgZ3B1X3Jlc2V0IAppcyBzZXQuCgpCVFc6IENoYW5n aW5nIHRoZSBhY3RpdmUgVlJBTSBzaXplIGluIEdQVSByZXNldCBpcyBxdWl0ZSBhIGJ1ZyB5b3Ug CnN0dW1ibGVkIG92ZXIgaGVyZSwgc28gdGhpcyByZWFsbHkgbmVlZHMgZml4aW5nIGFueXdheS4K ClJlZ2FyZHMsCkNocmlzdGlhbi4KCkFtIDAxLjAzLjIwMTggdW0gMDk6MjMgc2NocmllYiBMaXUs IE1vbms6Cj4gQWNjZWxfd29ya2luZyBpcyBvbmx5IGZvciBHRlggcmluZywgSSBkb24ndCB0aGlu ayB0ZXN0IGl0IGlzIGFwcHJvcHJpYXRlIGZvciBTRE1BIGpvYnMgLi4uLgo+Cj4gSWYgd2UgYXJl IGluIGdwdSByZXN0IHN0YWdlLCB3ZSBjYW4gbGV0IFNETUEgam9iIGxpdmUgd2l0aCB0aGUgY2Fz ZSBvZiByaW5nIG5vdCByZWFkeSwgIGNhbiB5b3UgcG9pbnQgb3V0IHdoZXJlIGlzIHRoZSBwcm9i bGVtID8KPgo+IEluIGZhY3Qgd2UgZGlkIHN0cmVzcyBURFIgdGVzdCB3aXRoIHRoaXMgcGF0Y2gg YW5kIGl0IGNhbiByZWFsbHkgZml4IGNvdXBsZSBvdmVyIGtpbGwgaXNzdWVzCj4KPgo+IC9Nb25r Cj4KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+IEZyb206IENocmlzdGlhbiBLw7ZuaWcg W21haWx0bzpja29lbmlnLmxlaWNodHp1bWVya2VuQGdtYWlsLmNvbV0KPiBTZW50OiAyMDE45bm0 M+aciDHml6UgMTY6MTYKPiBUbzogTGl1LCBNb25rIDxNb25rLkxpdUBhbWQuY29tPjsgS29lbmln LCBDaHJpc3RpYW4gPENocmlzdGlhbi5Lb2VuaWdAYW1kLmNvbT47IGFtZC1nZnhAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCj4gU3ViamVjdDogUmU6IFtQQVRDSCAzLzRdIGRybS9hbWRncHU6IGRvbid0 IHJldHVybiB3aGVuIHJpbmcgbm90IHJlYWR5IGZvciBmaWxsX2J1ZmZlcgo+Cj4gQWgsIGNyYXAg eWVhaCB0aGF0IHdvbid0IHdvcmsgc2luY2Ugd2UgZG9uJ3QgZnJlZSB0aGUgcmluZy4KPgo+IEtl eSBwb2ludCBpcyB3ZSBuZWVkIHRvIGRpc3RpbmN0IGJldHdlZW4gdGhlIHJpbmcgZG9lc24ndCB3 b3JrIHRlbXBvcmFyeSBiZWNhdXNlIHdlIGFyZSBpbiBhIEdQVSByZXNldCBhbmQgaXQgZG9lc24n dCB3b3JrIGF0IGFsbCBiZWNhdXNlIHdlIGFyZSBtaXNzaW5nIGZpcm13YXJlIG9yIHN0dWZmIGxp a2UgdGhhdC4KPgo+IEFuZCBubywgY2hlY2tpbmcgdGhlIGdwdV9yZXNldCBmbGFnIGlzIHRvdGFs bHkgcmFjeSBhbmQgY2FuJ3QgYmUgZG9uZSBlaXRoZXIuIEhvdyBhYm91dCBjaGVja2luZyBhY2Nl bF93b3JraW5nIGluc3RlYWQ/Cj4KPiBDaHJpc3RpYW4uCj4KPiBBbSAwMS4wMy4yMDE4IHVtIDA3 OjAxIHNjaHJpZWIgTGl1LCBNb25rOgo+Pj4gUGxlYXNlIGNoYW5nZSB0aGUgdGVzdCB0byB1c2Ug cmluZy0+cmluZ19vYmogaW5zdGVhZCwgdGhpcyB3YXkgd2Ugc3RpbGwgYmFpbCBvdXQgaWYgc29t ZWJvZHkgdHJpZXMgdG8gc3VibWl0IGNvbW1hbmRzIGJlZm9yZSB0aGUgcmluZyBpcyBldmVuIGFs bG9jYXRlZC4KPj4gSSBkb24ndCB1bmRlcnN0YW5kIGhvdyBjb3VsZCBmaWxsX2J1ZmZlcigpIGdl dCBydW4gdW5kZXIgdGhlIGNhc2UgdGhhdCByaW5nLT5yaW5nX29iaiBpcyBub3QgZXZlbiBhbGxv Y2F0ZWQgLi4uIHdoZXJlIGlzIHN1Y2ggY2FzZSA/Cj4+Cj4+Cj4+IC9Nb25rCj4+Cj4+IC0tLS0t T3JpZ2luYWwgTWVzc2FnZS0tLS0tCj4+IEZyb206IEtvZW5pZywgQ2hyaXN0aWFuCj4+IFNlbnQ6 IDIwMTjlubQy5pyIMjjml6UgMjA6NDYKPj4gVG86IExpdSwgTW9uayA8TW9uay5MaXVAYW1kLmNv bT47IGFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4+IFN1YmplY3Q6IFJlOiBbUEFUQ0gg My80XSBkcm0vYW1kZ3B1OiBkb24ndCByZXR1cm4gd2hlbiByaW5nIG5vdCByZWFkeQo+PiBmb3Ig ZmlsbF9idWZmZXIKPj4KPj4gR29vZCBwb2ludCwgYnV0IGluIHRoaXMgY2FzZSB3ZSBuZWVkIHNv bWUgb3RoZXIgaGFuZGxpbmcuCj4+Cj4+IFBsZWFzZSBjaGFuZ2UgdGhlIHRlc3QgdG8gdXNlIHJp bmctPnJpbmdfb2JqIGluc3RlYWQsIHRoaXMgd2F5IHdlIHN0aWxsIGJhaWwgb3V0IGlmIHNvbWVi b2R5IHRyaWVzIHRvIHN1Ym1pdCBjb21tYW5kcyBiZWZvcmUgdGhlIHJpbmcgaXMgZXZlbiBhbGxv Y2F0ZWQuCj4+Cj4+IEFuZCB5b3UgYWxzbyBuZWVkIHRvIGZpeCBhIGNvdXBsZSBvZiBvdGhlciBw bGFjZXMgaW4gYW1kZ3B1X3R0bS5jLgo+Pgo+PiBSZWdhcmRzLAo+PiBDaHJpc3RpYW4uCj4+Cj4+ IEFtIDI4LjAyLjIwMTggdW0gMTM6MzQgc2NocmllYiBMaXUsIE1vbms6Cj4+PiBCZWNhdXNlIHdo ZW4gU0RNQSB3YXMgaGFuZyBieSBsaWtlIHByb2Nlc3MgQSwgYW5kIG1lYW53aGlsZSBhbm90aGVy Cj4+PiBwcm9jZXNzIEIgaXMgYWxyZWFkeSBydW5uaW5nIGludG8gdGhlIGNvZGUgb2YgZmlsbF9i dWZmZXIoKSBTbyBqdXN0IGxldCBwcm9jZXNzIEIgY29udGludWUsIGRvbid0IGJsb2NrIGl0IG90 aGVyd2lzZSBwcm9jZXNzIEIgd291bGQgZmFpbCBieSBzb2Z0d2FyZSByZWFzb24gLgo+Pj4KPj4+ IExldCBpdCBydW4gYW5kIGZpbmFsbHkgcHJvY2VzcyBCJ3Mgam9iIHdvdWxkIGZhaWwgYW5kIEdQ VSByZWNvdmVyCj4+PiB3aWxsIHJlcGVhdCBpdCBhZ2FpbiAoc2luY2UgaXQgaXMgYSBrZXJuZWwg am9iKQo+Pj4KPj4+IFdpdGhvdXQgdGhpcyBzb2x1dGlvbiBvdGhlciBwcm9jZXNzIHdpbGwgYmUg Z3JlYXRseSBoYXJtZWQgYnkgb25lCj4+PiBibGFjayBzaGVlcCB0aGF0IHRyaWdnZXJpbmcgR1BV IHJlY292ZXIKPj4+Cj4+PiAvTW9uawo+Pj4KPj4+Cj4+Pgo+Pj4gLS0tLS1PcmlnaW5hbCBNZXNz YWdlLS0tLS0KPj4+IEZyb206IENocmlzdGlhbiBLw7ZuaWcgW21haWx0bzpja29lbmlnLmxlaWNo dHp1bWVya2VuQGdtYWlsLmNvbV0KPj4+IFNlbnQ6IDIwMTjlubQy5pyIMjjml6UgMjA6MjQKPj4+ IFRvOiBMaXUsIE1vbmsgPE1vbmsuTGl1QGFtZC5jb20+OyBhbWQtZ2Z4QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwo+Pj4gU3ViamVjdDogUmU6IFtQQVRDSCAzLzRdIGRybS9hbWRncHU6IGRvbid0IHJl dHVybiB3aGVuIHJpbmcgbm90IHJlYWR5Cj4+PiBmb3IgZmlsbF9idWZmZXIKPj4+Cj4+PiBBbSAy OC4wMi4yMDE4IHVtIDA4OjIxIHNjaHJpZWIgTW9uayBMaXU6Cj4+Pj4gYmVjYXVzZSB0aGlzIHRp bWUgU0RNQSBtYXkgdW5kZXIgR1BVIFJFU0VUIHNvIGl0cyByaW5nLT5yZWFkeSBtYXkKPj4+PiBu b3QgdHJ1ZSwga2VlcCBnb2luZyBhbmQgR1BVIHNjaGVkdWxlciB3aWxsIHJlc2NoZWR1bGUgdGhp cyBqb2IgaWYKPj4+PiBpdCBmYWlsZWQuCj4+Pj4KPj4+PiBnaXZlIGEgd2FybmluZyBvbiBjb3B5 X2J1ZmZlciB3aGVuIGdvIHRocm91Z2ggZGlyZWN0X3N1Ym1pdCB3aGlsZQo+Pj4+IHJpbmctPnJl YWR5IGlzIGZhbHNlCj4+PiBOQUssIHRoYXQgdGVzdCBoYXMgYWxyZWFkeSBzYXZlZCB1cyBxdWl0 ZSBhIGJ1bmNoIG9mIHRyb3VibGUgd2l0aCB0aGUgZmIgbGF5ZXIuCj4+Pgo+Pj4gV2h5IGV4YWN0 bHkgYXJlIHlvdSBydW5uaW5nIGludG8gaXNzdWVzIHdpdGggdGhhdD8KPj4+Cj4+PiBDaHJpc3Rp YW4uCj4+Pgo+Pj4+IENoYW5nZS1JZDogSWZlNmNkNTVlMGU4NDNkOTk5MDBlNWJlZDU0MTg0OTll ODg2MzM2ODUKPj4+PiBTaWduZWQtb2ZmLWJ5OiBNb25rIExpdSA8TW9uay5MaXVAYW1kLmNvbT4K Pj4+PiAtLS0KPj4+PiAgICAgIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV90dG0u YyB8IDYgKy0tLS0tCj4+Pj4gICAgICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDUg ZGVsZXRpb25zKC0pCj4+Pj4KPj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9h bWRncHUvYW1kZ3B1X3R0bS5jCj4+Pj4gYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRn cHVfdHRtLmMKPj4+PiBpbmRleCBlMzhlNmRiLi43Yjc1YWM5IDEwMDY0NAo+Pj4+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV90dG0uYwo+Pj4+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV90dG0uYwo+Pj4+IEBAIC0xNjU2LDYgKzE2NTYsNyBA QCBpbnQgYW1kZ3B1X2NvcHlfYnVmZmVyKHN0cnVjdCBhbWRncHVfcmluZyAqcmluZywgdWludDY0 X3Qgc3JjX29mZnNldCwKPj4+PiAgICAgIAlhbWRncHVfcmluZ19wYWRfaWIocmluZywgJmpvYi0+ aWJzWzBdKTsKPj4+PiAgICAgIAlXQVJOX09OKGpvYi0+aWJzWzBdLmxlbmd0aF9kdyA+IG51bV9k dyk7Cj4+Pj4gICAgICAJaWYgKGRpcmVjdF9zdWJtaXQpIHsKPj4+PiArCQlXQVJOX09OKCFyaW5n LT5yZWFkeSk7Cj4+Pj4gICAgICAJCXIgPSBhbWRncHVfaWJfc2NoZWR1bGUocmluZywgam9iLT5u dW1faWJzLCBqb2ItPmlicywKPj4+PiAgICAgIAkJCQkgICAgICAgTlVMTCwgZmVuY2UpOwo+Pj4+ ICAgICAgCQlqb2ItPmZlbmNlID0gZG1hX2ZlbmNlX2dldCgqZmVuY2UpOyBAQCAtMTY5MiwxMSAr MTY5Myw2IEBAIGludAo+Pj4+IGFtZGdwdV9maWxsX2J1ZmZlcihzdHJ1Y3QgYW1kZ3B1X2JvICpi bywKPj4+PiAgICAgIAlzdHJ1Y3QgYW1kZ3B1X2pvYiAqam9iOwo+Pj4+ICAgICAgCWludCByOwo+ Pj4+ICAgICAgCj4+Pj4gLQlpZiAoIXJpbmctPnJlYWR5KSB7Cj4+Pj4gLQkJRFJNX0VSUk9SKCJU cnlpbmcgdG8gY2xlYXIgbWVtb3J5IHdpdGggcmluZyB0dXJuZWQgb2ZmLlxuIik7Cj4+Pj4gLQkJ cmV0dXJuIC1FSU5WQUw7Cj4+Pj4gLQl9Cj4+Pj4gLQo+Pj4+ICAgICAgCWlmIChiby0+dGJvLm1l bS5tZW1fdHlwZSA9PSBUVE1fUExfVFQpIHsKPj4+PiAgICAgIAkJciA9IGFtZGdwdV90dG1fYWxs b2NfZ2FydCgmYm8tPnRibyk7Cj4+Pj4gICAgICAJCWlmIChyKQo+PiBfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+PiBhbWQtZ2Z4IG1haWxpbmcgbGlzdAo+ PiBhbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+PiBodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngKCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmFtZC1nZnggbWFpbGluZyBsaXN0CmFtZC1nZnhAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vYW1kLWdmeAo=