Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4853C433F5 for ; Wed, 22 Sep 2021 14:07:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B195E60F44 for ; Wed, 22 Sep 2021 14:07:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234563AbhIVOIt (ORCPT ); Wed, 22 Sep 2021 10:08:49 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:58401 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233005AbhIVOIs (ORCPT ); Wed, 22 Sep 2021 10:08:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632319638; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ba+E7Owd22l9waSriV+JqQxtDijO6mPBTbt1IbtPw9I=; b=gojZt7zjxUfTFP0EHbfRHu2IP5j8+0NNffiIQKN6p7jXpqz29zgh5PuRs0CyhnqAHYnwN4 Jzjsd3q16hgpEApgu6KaNtgEYWEhVqC9c3paky0Z0JMSQc0lezEe/xfLNpdBrEdXM0XxpF nSLzoh0PNFpB0WzediqVUe55pyt/I3k= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-464-0cWPcXjiPvCb3Gt7ZZ6vKA-1; Wed, 22 Sep 2021 10:07:17 -0400 X-MC-Unique: 0cWPcXjiPvCb3Gt7ZZ6vKA-1 Received: by mail-ed1-f69.google.com with SMTP id c7-20020a05640227c700b003d27f41f1d4so3168601ede.16 for ; Wed, 22 Sep 2021 07:07:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Ba+E7Owd22l9waSriV+JqQxtDijO6mPBTbt1IbtPw9I=; b=BTfRye7b7B/KT95g4F2zZQ2kF5x1gEWJhjpIw44zVBE1DBxJ8+qPFb6X6urjqHOEvy S9IJxasvWddrT2Y4AVaXshbnxbujWoHbIEeiD/qsht32BedRHAwC3eIU3HVMLuvvRniR p2/V4OpX2uSG1QFSBnY0EcLmrNhlRV41VwKSQdEBEInSKwwjxQs0EJ8tiqsK+BMR2qY6 3fzfHxlZZzDswlIxiu72GqafPk8Vjsz2lt7OoSJ/VdGQHfavlagpu9jwBlv3suGjBlly mRV1/80pkuvSCLqQTMRiI52voADJLTxgYN9rkOnvvnR4aM10ZyzVL47p3tlHsbCHMZgv /aRA== X-Gm-Message-State: AOAM5318dPOea8My7d6KJH5J1uFQim28TXvjljV/pJVkHeS6/Oeuw+bA lSCjjUOmlMIplpPPJREQG+Uv6rE+gZ4JkCKXKsqbL0/bpiG8l53qZVLW5rqvuI/k7mwfYtzBwz1 fvi8GphA2kM7C X-Received: by 2002:a17:906:1749:: with SMTP id d9mr40308227eje.178.1632319636064; Wed, 22 Sep 2021 07:07:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy6M+rFLfczRLlUYHd+A6h2bnYjANTy7Y9pJTrQqXxB4qcEgTjq8X+c/eA49sJeu54GxPp7lQ== X-Received: by 2002:a17:906:1749:: with SMTP id d9mr40308213eje.178.1632319635878; Wed, 22 Sep 2021 07:07:15 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id x7sm1263870ede.86.2021.09.22.07.07.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Sep 2021 07:07:15 -0700 (PDT) Subject: Re: [PATCH] KVM: nVMX: Filter out all unsupported controls when eVMCS was activated To: Vitaly Kuznetsov , Sean Christopherson Cc: kvm@vger.kernel.org, Wanpeng Li , Jim Mattson , linux-kernel@vger.kernel.org References: <20210907163530.110066-1-vkuznets@redhat.com> <87v93a2pu9.fsf@vitty.brq.redhat.com> From: Paolo Bonzini Message-ID: <6e97f33c-e4d4-5669-c642-a904c9e22a8d@redhat.com> Date: Wed, 22 Sep 2021 16:07:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <87v93a2pu9.fsf@vitty.brq.redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 09/09/21 09:03, Vitaly Kuznetsov wrote: > Sean Christopherson writes: > >> On Tue, Sep 07, 2021, Vitaly Kuznetsov wrote: >>> Let's be bold this time and instead of playing whack-a-mole just filter out >>> all unsupported controls from VMX MSRs. >> >> Out of curiosity, why didn't we do this from the get-go? > > We actually did, the initial implementation (57b119da3594f) was > filtering out everything but then things changed in "only clear controls > which are known to cause issues" (31de3d2500e4). I forgot everything > already but was able to google this suggestion from Paolo: > > https://www.lkml.org/lkml/2020/1/22/1108 The doubt was whether userspaces could be enabling eVMCS blindly, and thus would lose features for Linux guests. Paolo