From: Shannon Nelson Date: Fri, 23 Jun 2017 10:19:44 -0700 Subject: [Intel-wired-lan] [next PATCH S74-V2 05/10] i40e: separate hw_features from runtime changing flags In-Reply-To: <20170623082451.32671-5-alice.michael@intel.com> References: <20170623082451.32671-1-alice.michael@intel.com> <20170623082451.32671-5-alice.michael@intel.com> Message-ID: <6ead4bb4-74f8-56d4-ef77-e925598bb356@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: On 6/23/2017 1:24 AM, Alice Michael wrote: > From: Jacob Keller > > The number of flags found in pf->flags has grown quite large, and there > are a lot of different types of flags. Most of the flags are simply > hardware features which are enabled on some firmware or some MAC types. > Other flags are dynamic run-time flags which enable or disable certain > features of the driver. > > Separate these two types of flags into pf->hw_features and pf->flags. In general this looks fine and really has long been needed. My only concern is that the name chosen clashes with netdev->hw_features. This is a small nit, but I think a slightly different name would be better in the long run. Even simply "features" would be good. sln