From: Eugen.Hristev at microchip.com Date: Thu, 26 Nov 2020 08:17:22 +0000 Subject: [PATCH v2] mmc: atmel-sdhci: fix the clk_enable call in case of no ops In-Reply-To: References: <20201109110217.34237-1-eugen.hristev@microchip.com> Message-ID: <6f48eb61-d26f-2402-b554-7a0565f93b03@microchip.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 09.11.2020 14:14, Jaehoon Chung wrote: > On 11/9/20 8:02 PM, Eugen Hristev wrote: >> If the clock driver does not offer a clk_enable ops, then the system will >> return -ENOSYS. >> The clk_enable works with CCF (common clock framework). >> Some clocks in some cases (like the generic clock for some products: sama5d2) >> do not have the clk_enable primitive, and in this case probing of the driver >> will fail. >> This patch changes the behavior to return an error in case there is really >> an error, and not a missing primitive. >> If the clock driver does not have an enable primitive, most likely clocks >> are always enabled or enabled in the set_rate primitives. >> >> Fixes: 81f16438d4 ("mmc: atmel-sdhci: enable the required generic clock") >> Signed-off-by: Eugen Hristev > > Reviewed-by: Jaehoon Chung > > Best Regards, > Jaehoon Chung > >> --- Applied to u-boot-atmel/master