From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH] drm: fix call_kern.cocci warnings v2 Date: Thu, 25 Oct 2018 10:56:11 +0200 Message-ID: <6f63db7a-e51b-5829-9eb0-265ebd6dd99c@gmail.com> References: <20181025085301.8217-1-david1.zhou@amd.com> Reply-To: christian.koenig@amd.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20181025085301.8217-1-david1.zhou@amd.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Chunming Zhou , dri-devel@lists.freedesktop.org Cc: =?UTF-8?Q?Christian_K=c3=b6nig?= , intel-gfx@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org QW0gMjUuMTAuMTggdW0gMTA6NTMgc2NocmllYiBDaHVubWluZyBaaG91Ogo+IGRyaXZlcnMvZ3B1 L2RybS9kcm1fc3luY29iai5jOjIwMjo0LTE0OiBFUlJPUjogZnVuY3Rpb24gZHJtX3N5bmNvYmpf ZmluZF9zaWduYWxfcHRfZm9yX3BvaW50IGNhbGxlZCBvbiBsaW5lIDM5MCBpbnNpZGUgbG9jayBv biBsaW5lIDM4OSBidXQgdXNlcyBHRlBfS0VSTkVMCj4KPiAgICBGaW5kIGZ1bmN0aW9ucyB0aGF0 IHJlZmVyIHRvIEdGUF9LRVJORUwgYnV0IGFyZSBjYWxsZWQgd2l0aCBsb2NrcyBoZWxkLgo+Cj4g U2VtYW50aWMgcGF0Y2ggaW5mb3JtYXRpb246Cj4gICAgVGhlIHByb3Bvc2VkIGNoYW5nZSBvZiBj b252ZXJ0aW5nIHRoZSBHRlBfS0VSTkVMIGlzIG5vdCBuZWNlc3NhcmlseSB0aGUKPiAgICBjb3Jy ZWN0IG9uZS4gIEl0IG1heSBiZSBkZXNpcmVkIHRvIHVubG9jayB0aGUgbG9jaywgb3IgdG8gbm90 IGNhbGwgdGhlCj4gICAgZnVuY3Rpb24gdW5kZXIgdGhlIGxvY2sgaW4gdGhlIGZpcnN0IHBsYWNl Lgo+Cj4gR2VuZXJhdGVkIGJ5OiBzY3JpcHRzL2NvY2NpbmVsbGUvbG9ja3MvY2FsbF9rZXJuLmNv Y2NpCgpUaGF0IGNvbW1lbnQgaXMgbm8gbG9uZ2VyIHRydWUuCgo+Cj4gdjI6Cj4gc3luY29iai0+ dGltZWxpbmUgc3RpbGwgbmVlZHMgcHJvdGVjdC4KPgo+IFNpZ25lZC1vZmYtYnk6IENodW5taW5n IFpob3UgPGRhdmlkMS56aG91QGFtZC5jb20+Cj4gQ2M6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFy dGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IGludGVsLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKPiBDYzogQ2hyaXN0aWFuIEvDtm5pZyA8ZWFzeTJyZW1lbWJlci5jaGtAZ29v Z2xlbWFpbC5jb20+Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vZHJtX3N5bmNvYmouYyB8IDI1 ICsrKysrKysrKysrKystLS0tLS0tLS0tLS0KPiAgIDEgZmlsZSBjaGFuZ2VkLCAxMyBpbnNlcnRp b25zKCspLCAxMiBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v ZHJtX3N5bmNvYmouYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fc3luY29iai5jCj4gaW5kZXggYjdl YWE2MDNmMzY4Li5iODQzZDRjMjc3OGMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2Ry bV9zeW5jb2JqLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX3N5bmNvYmouYwo+IEBAIC0x MTEsMTUgKzExMSwxNiBAQCBzdGF0aWMgc3RydWN0IGRtYV9mZW5jZQo+ICAgCQkJCSAgICAgIHVp bnQ2NF90IHBvaW50KQo+ICAgewo+ICAgCXN0cnVjdCBkcm1fc3luY29ial9zaWduYWxfcHQgKnNp Z25hbF9wdDsKPiArCXN0cnVjdCBkbWFfZmVuY2UgKmYgPSBOVUxMOwo+ICsJc3RydWN0IGRybV9z eW5jb2JqX3N0dWJfZmVuY2UgKmZlbmNlID0KPiArCQlremFsbG9jKHNpemVvZihzdHJ1Y3QgZHJt X3N5bmNvYmpfc3R1Yl9mZW5jZSksCj4gKwkJCUdGUF9LRVJORUwpOwo+ICAgCj4gKwlpZiAoIWZl bmNlKQo+ICsJCXJldHVybiBOVUxMOwo+ICsJc3Bpbl9sb2NrKCZzeW5jb2JqLT5wdF9sb2NrKTsK CkhvdyBhYm91dCB1c2luZyBhIHNpbmdsZSBzdGF0aWMgc3R1YiBmZW5jZSBsaWtlIEkgc3VnZ2Vz dGVkPwoKQ2hyaXN0aWFuLgoKPiAgIAlpZiAoKHN5bmNvYmotPnR5cGUgPT0gRFJNX1NZTkNPQkpf VFlQRV9USU1FTElORSkgJiYKPiAgIAkgICAgKHBvaW50IDw9IHN5bmNvYmotPnRpbWVsaW5lKSkg ewo+IC0JCXN0cnVjdCBkcm1fc3luY29ial9zdHViX2ZlbmNlICpmZW5jZSA9Cj4gLQkJCWt6YWxs b2Moc2l6ZW9mKHN0cnVjdCBkcm1fc3luY29ial9zdHViX2ZlbmNlKSwKPiAtCQkJCUdGUF9LRVJO RUwpOwo+IC0KPiAtCQlpZiAoIWZlbmNlKQo+IC0JCQlyZXR1cm4gTlVMTDsKPiAgIAkJc3Bpbl9s b2NrX2luaXQoJmZlbmNlLT5sb2NrKTsKPiAgIAkJZG1hX2ZlbmNlX2luaXQoJmZlbmNlLT5iYXNl LAo+ICAgCQkJICAgICAgICZkcm1fc3luY29ial9zdHViX2ZlbmNlX29wcywKPiBAQCAtMTI4LDYg KzEyOSw3IEBAIHN0YXRpYyBzdHJ1Y3QgZG1hX2ZlbmNlCj4gICAJCQkgICAgICAgcG9pbnQpOwo+ ICAgCj4gICAJCWRtYV9mZW5jZV9zaWduYWwoJmZlbmNlLT5iYXNlKTsKPiArCQlzcGluX3VubG9j aygmc3luY29iai0+cHRfbG9jayk7Cj4gICAJCXJldHVybiAmZmVuY2UtPmJhc2U7Cj4gICAJfQo+ ICAgCj4gQEAgLTEzNyw5ICsxMzksMTIgQEAgc3RhdGljIHN0cnVjdCBkbWFfZmVuY2UKPiAgIAkJ aWYgKChzeW5jb2JqLT50eXBlID09IERSTV9TWU5DT0JKX1RZUEVfQklOQVJZKSAmJgo+ICAgCQkg ICAgKHBvaW50ICE9IHNpZ25hbF9wdC0+dmFsdWUpKQo+ICAgCQkJY29udGludWU7Cj4gLQkJcmV0 dXJuIGRtYV9mZW5jZV9nZXQoJnNpZ25hbF9wdC0+ZmVuY2VfYXJyYXktPmJhc2UpOwo+ICsJCWYg PSBkbWFfZmVuY2VfZ2V0KCZzaWduYWxfcHQtPmZlbmNlX2FycmF5LT5iYXNlKTsKPiArCQlicmVh azsKPiAgIAl9Cj4gLQlyZXR1cm4gTlVMTDsKPiArCXNwaW5fdW5sb2NrKCZzeW5jb2JqLT5wdF9s b2NrKTsKPiArCWtmcmVlKGZlbmNlKTsKPiArCXJldHVybiBmOwo+ICAgfQo+ICAgCj4gICBzdGF0 aWMgdm9pZCBkcm1fc3luY29ial9hZGRfY2FsbGJhY2tfbG9ja2VkKHN0cnVjdCBkcm1fc3luY29i aiAqc3luY29iaiwKPiBAQCAtMTY2LDkgKzE3MSw3IEBAIHN0YXRpYyB2b2lkIGRybV9zeW5jb2Jq X2ZlbmNlX2dldF9vcl9hZGRfY2FsbGJhY2soc3RydWN0IGRybV9zeW5jb2JqICpzeW5jb2JqLAo+ ICAgCX0KPiAgIAo+ICAgCW11dGV4X2xvY2soJnN5bmNvYmotPmNiX211dGV4KTsKPiAtCXNwaW5f bG9jaygmc3luY29iai0+cHRfbG9jayk7Cj4gICAJKmZlbmNlID0gZHJtX3N5bmNvYmpfZmluZF9z aWduYWxfcHRfZm9yX3BvaW50KHN5bmNvYmosIHB0X3ZhbHVlKTsKPiAtCXNwaW5fdW5sb2NrKCZz eW5jb2JqLT5wdF9sb2NrKTsKPiAgIAlpZiAoISpmZW5jZSkKPiAgIAkJZHJtX3N5bmNvYmpfYWRk X2NhbGxiYWNrX2xvY2tlZChzeW5jb2JqLCBjYiwgZnVuYyk7Cj4gICAJbXV0ZXhfdW5sb2NrKCZz eW5jb2JqLT5jYl9tdXRleCk7Cj4gQEAgLTM3OSwxMSArMzgyLDkgQEAgZHJtX3N5bmNvYmpfcG9p bnRfZ2V0KHN0cnVjdCBkcm1fc3luY29iaiAqc3luY29iaiwgdTY0IHBvaW50LCB1NjQgZmxhZ3Ms Cj4gICAJCWlmIChyZXQgPCAwKQo+ICAgCQkJcmV0dXJuIHJldDsKPiAgIAl9Cj4gLQlzcGluX2xv Y2soJnN5bmNvYmotPnB0X2xvY2spOwo+ICAgCSpmZW5jZSA9IGRybV9zeW5jb2JqX2ZpbmRfc2ln bmFsX3B0X2Zvcl9wb2ludChzeW5jb2JqLCBwb2ludCk7Cj4gICAJaWYgKCEqZmVuY2UpCj4gICAJ CXJldCA9IC1FSU5WQUw7Cj4gLQlzcGluX3VubG9jaygmc3luY29iai0+cHRfbG9jayk7Cj4gICAJ cmV0dXJuIHJldDsKPiAgIH0KPiAgIAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vZHJpLWRldmVsCg==