Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 185B2C433F5 for ; Thu, 28 Oct 2021 09:17:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F382E610CB for ; Thu, 28 Oct 2021 09:17:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229992AbhJ1JUX (ORCPT ); Thu, 28 Oct 2021 05:20:23 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:51112 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229791AbhJ1JUW (ORCPT ); Thu, 28 Oct 2021 05:20:22 -0400 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1605521965; Thu, 28 Oct 2021 09:17:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1635412675; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2nwjrMJaLPLwolomJQlbq8enN6s5nVOPqsWK/uB9/g0=; b=p1OqQQVAF9Aw2H+SzAJybPl3uyeWExlGT3/0jwvgWaGRvzaK4uOZGA8RJIAbvXSWvKPqfq VkQucYcXXtbscLhJBD6ajoaGEEshiON4NHlL0RCZDKqX7tBRM0NR/EK0ckjpRGT8rK5DtC 6EuWs2zUN96ApJWafZTkvqfJZWmgKDY= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D3C7513A69; Thu, 28 Oct 2021 09:17:54 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id X+sJMcJqemGJWQAAMHmgww (envelope-from ); Thu, 28 Oct 2021 09:17:54 +0000 Subject: Re: [PATCH] btrfs: Test proper interaction between skip_balance and paused balance To: fdmanana@gmail.com Cc: fstests , linux-btrfs References: <20211027135754.20101-1-nborisov@suse.com> From: Nikolay Borisov Message-ID: <6f63dd3a-982f-6875-2e47-a091f8d8d96a@suse.com> Date: Thu, 28 Oct 2021 12:17:54 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org On 28.10.21 г. 12:01, Filipe Manana wrote: > On Wed, Oct 27, 2021 at 10:25 PM Nikolay Borisov wrote: >> +if [[ ! -e /sys/fs/btrfs/$uuid/exclusive_operation ]]; then >> + _notrun "Requires btrfs exclusive operation support" >> +fi > > Why is it required to have the sysfs export file for the exclusive operations? > The test doesn't use the file at all, and exclusive operations exist > for many years, unlike the sysfs file which is recent. Because the report mentioned the following error message being printed: ERROR: unable to start device add, another exclusive operation 'balance' in progress And this comes from check_running_fs_exclop which got added as part of the sysfs interface for exclusive ops. >