From: "cron2 (Code Review)" Date: Tue, 14 Jan 2025 15:58:40 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <6f6b964f5a5d8950f0495c09b7c11b16b3ab8f5a-EmailReplacePatchSet-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="z8rfnZbxrr4="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: Improve peer fingerprint documentation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos , flichtenheld Cc: openvpn-devel --z8rfnZbxrr4= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has uploaded a new patch set (#2) to the change originally created by= plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/859?usp=3Demail ) The following approvals got outdated and were removed: Code-Review+2 by flichtenheld Change subject: Improve peer fingerprint documentation ...................................................................... Improve peer fingerprint documentation - fix typo in peer-fingerprint - use ec_paramgen_curve instead of requiring a subshell Note: we still use -nodes instead of -noenc as it is more compatible. Github: closes OpenVPN/openvpn#666 Change-Id: I9a12a0c127908af9f09d88fb3a493df3763d0cc5 Signed-off-by: Arne Schwabe Acked-by: Frank Lichtenheld Message-Id: <20250114134909.31334-1-frank@...2641...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg30= 447.html Signed-off-by: Gert Doering --- M doc/man-sections/example-fingerprint.rst 1 file changed, 10 insertions(+), 4 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/59/859/2 diff --git a/doc/man-sections/example-fingerprint.rst b/doc/man-sections/ex= ample-fingerprint.rst index 7cdda19..31ca0c1 100644 --- a/doc/man-sections/example-fingerprint.rst +++ b/doc/man-sections/example-fingerprint.rst @@ -18,7 +18,7 @@ 2. Generate a self-signed certificate for the server: :: - openssl req -x509 -newkey ec:<(openssl ecparam -name secp384r1) -keyou= t server.key -out server.crt -nodes -sha256 -days 3650 -subj '/CN=3Dserver' + openssl req -x509 -newkey ec -pkeyopt ec_paramgen_curve:secp384r1 -key= out server.key -out server.crt -nodes -sha256 -days 3650 -subj '/CN=3Dserve= r' 3. Generate SHA256 fingerprint of the server certificate @@ -28,7 +28,7 @@ openssl x509 -fingerprint -sha256 -in server.crt -noout - This output something similar to: + This outputs something similar to: :: SHA256 Fingerprint=3D00:11:22:33:44:55:66:77:88:99:aa:bb:cc:dd:ee:ff:= 00:11:22:33:44:55:66:77:88:99:aa:bb:cc:dd:ee:ff @@ -64,6 +64,12 @@ # Ping every 60s, restart if no data received for 5 minutes keepalive 60 300 + # Uncomment the line below if you want to have persistent IP addresses + # ifconfig-pool-persist /etc/openvpn/server/ipp.txt + + # Uncomment the line below to push a DNS server to clients + # push "dhcp-option DNS 1.1.1.1" + 5. Add at least one client as described in the client section. 6. Start the server. @@ -85,7 +91,7 @@ different name for each client. :: - openssl req -x509 -newkey ec:<(openssl ecparam -name secp384r1) -nod= es -sha256 -days 3650 -subj '/CN=3Dalice' + openssl req -x509 -newkey ec -pkeyopt ec_paramgen_curve:secp384r1 -k= eyout - -nodes -sha256 -days 3650 -subj '/CN=3Dalice' This generate a certificate and a key for the client. The output of the= command will look something like this: @@ -162,7 +168,7 @@ ff:ee:dd:cc:bb:aa:99:88:77:66:55:44:33:22:11:00:ff:ee:dd:cc:bb:aa:99= :88:77:66:55:44:33:22:11:00 99:88:77:66:55:44:33:22:11:00:ff:ee:dd:cc:bb:aa:99:88:77:66:55:44:33= :22:11:00:88:77:66:55:44:33 - + 6. (optional) if the client is an older client that does not support the :code:`peer-fingerprint` (e.g. OpenVPN 2.5 and older, OpenVPN Connect 3= .3 -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/859?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I9a12a0c127908af9f09d88fb3a493df3763d0cc5 Gerrit-Change-Number: 859 Gerrit-PatchSet: 2 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-MessageType: newpatchset --z8rfnZbxrr4= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 uploaded patch set #2 to the change originally cr= eated by plaisthos.

View Change

The following approvals got outdated= and were removed: Code-Review+2 by flichtenheld

Improve peer fingerprint documentation
- fix typo in peer-fingerprint
- use ec_paramgen_curve instead of requi= ring a subshell

Note: we still use -nodes instead of -noenc as it is= more compatible.

Github: closes OpenVPN/openvpn#666

Change-I= d: I9a12a0c127908af9f09d88fb3a493df3763d0cc5
Signed-off-by: Arne Schwabe= <arne@...1227...>
Acked-by: Frank Lichtenheld <frank@...2723...= .>
Message-Id: <20250114134909.31334-1-frank@...2641...>
URL= : https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg30447= .html
Signed-off-by: Gert Doering <gert@...1296...>
---
M do= c/man-sections/example-fingerprint.rst
1 file changed, 10 insertions(+),= 4 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn r=
efs/changes/59/859/2
diff --git a/doc/man-sections/example-fingerpr=
int.rst b/doc/man-sections/example-fingerprint.rst
index 7c= dda19..31ca0c1 100644
--- a/doc/man-sections/example-finger= print.rst
+++ b/doc/man-sections/example-fingerprint.rst
@@ -18,7 +18,7 @@
2. Generate a self-signed = certificate for the server:
::
=
- openssl req -x509 -newke= y ec:<(openssl ecparam -name secp384r1) -keyout server.key -out server.c= rt -nodes -sha256 -days 3650 -subj '/CN=3Dserver'
+ openssl req -x509 -newkey ec -pke= yopt ec_paramgen_curve:secp384r1 -keyout server.key -out server.crt -nodes = -sha256 -days 3650 -subj '/CN=3Dserver'
3. Generate SHA256 fingerprint of the server certificate
=
@@ -28,7 +28,7 @@

openssl x509 -fingerprint -sha256 -in server.crt -noout


- This output so= mething similar to:
+= This outputs something similar to:
::

SHA256 Fingerprint=3D00:11:22:33:44:55:66:77:88:9= 9:aa:bb:cc:dd:ee:ff:00:11:22:33:44:55:66:77:88:99:aa:bb:cc:dd:ee:ff<= br>@@ -64,6 +64,12 @@
# Ping every 60s, restart = if no data received for 5 minutes
keepalive 60 300


+ #= Uncomment the line below if you want to have persistent IP addresses
+ # ifconfig-pool-persi= st /etc/openvpn/server/ipp.txt
+
+ # U= ncomment the line below to push a DNS server to clients
+ # push "dhcp-option DNS 1.1.1.= 1"
+
<= span> 5. Add at least one client as described in the client section.
=

6. Start the server.
@@ -85,7 = +91,7 @@
different name for each client.
::

- openssl req -x509 -newkey ec:<(openssl ecparam -name secp384r= 1) -nodes -sha256 -days 3650 -subj '/CN=3Dalice'
+ openssl req -x509 -newkey ec -pk= eyopt ec_paramgen_curve:secp384r1 -keyout - -nodes -sha256 -days 3650 -subj= '/CN=3Dalice'

This generate = a certificate and a key for the client. The output of the command will look=
something like this:
@@ -162,7 +168,7 = @@
<peer-fingerprint>
f= f:ee:dd:cc:bb:aa:99:88:77:66:55:44:33:22:11:00:ff:ee:dd:cc:bb:aa:99:88:77:6= 6:55:44:33:22:11:00
99:88:77:66:55:44:33:22:11:00:ff= :ee:dd:cc:bb:aa:99:88:77:66:55:44:33:22:11:00:88:77:66:55:44:33
<= span style=3D"color: hsl(0, 100%, 40%);">- </peer-fingperint>
+ </peer-finger= print>

6. (optional) if the client is= an older client that does not support the
:code:`peer-= fingerprint` (e.g. OpenVPN 2.5 and older, OpenVPN Connect 3.3

To view, visit change 859. To unsubscribe, or for help wr= iting mail filters, visit se= ttings.

<= div itemscope itemprop=3D"action" itemtype=3D"http://schema.org/ViewAction"= >
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I9a12a0c127908af9f09d88fb3a4= 93df3763d0cc5
Gerrit-Change-Number: 859
Gerrit-PatchSet: 2
Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-MessageType: newpatchset
--z8rfnZbxrr4=--