From: Rolf Eike Beer Subject: Re: [PATCH 08/12] parisc: use pgtable-nopXd instead of 4level-fixup Date: Wed, 23 Oct 2019 12:20:29 +0200 Message-ID: <70339cfc547e2fa0f6b98fefb1b1a9fa@sf-tec.de> References: <1571822941-29776-1-git-send-email-rppt@kernel.org> <1571822941-29776-9-git-send-email-rppt@kernel.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1571822941-29776-9-git-send-email-rppt@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Mike Rapoport Cc: linux-mm@kvack.org, Andrew Morton , Anton Ivanov , Arnd Bergmann , "David S. Miller" , Geert Uytterhoeven , Greentime Hu , Greg Ungerer , Helge Deller , "James E.J. Bottomley" , Jeff Dike , "Kirill A. Shutemov" , Linus Torvalds , Mark Salter , Matt Turner , Michal Simek , Richard Weinberger , Russell King , Sam Creasey , Vincent Chen > diff --git a/arch/parisc/include/asm/page.h > b/arch/parisc/include/asm/page.h > index 93caf17..1d339ee 100644 > --- a/arch/parisc/include/asm/page.h > +++ b/arch/parisc/include/asm/page.h > @@ -42,48 +42,54 @@ typedef struct { unsigned long pte; } pte_t; /* > either 32 or 64bit */ > > /* NOTE: even on 64 bits, these entries are __u32 because we allocate > * the pmd and pgd in ZONE_DMA (i.e. under 4GB) */ > -typedef struct { __u32 pmd; } pmd_t; > typedef struct { __u32 pgd; } pgd_t; > typedef struct { unsigned long pgprot; } pgprot_t; > > -#define pte_val(x) ((x).pte) > -/* These do not work lvalues, so make sure we don't use them as such. > */ > +#if CONFIG_PGTABLE_LEVELS == 3 > +typedef struct { __u32 pmd; } pmd_t; > +#define __pmd(x) ((pmd_t) { (x) } ) > +/* pXd_val() do not work lvalues, so make sure we don't use them as > such. */ For me it sounds like there is something missing, maybe an "as" before lvalues? And it was "These", so plural, and now it is singular, so do -> does? Eike