From: Tvrtko Ursulin Subject: Re: [PATCH v2 1/3] drm/i915: Add test for invalid flag bits in whitelist entries Date: Fri, 12 Jul 2019 09:47:28 +0100 Message-ID: <7046a820-a6d4-3e90-e995-30cfceb214d7@linux.intel.com> References: <20190712070745.35239-1-John.C.Harrison@Intel.com> <20190712070745.35239-2-John.C.Harrison@Intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id B6DFC6E316 for ; Fri, 12 Jul 2019 08:47:30 +0000 (UTC) In-Reply-To: <20190712070745.35239-2-John.C.Harrison@Intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: John.C.Harrison@Intel.com, Intel-GFX@Lists.FreeDesktop.Org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDEyLzA3LzIwMTkgMDg6MDcsIEpvaG4uQy5IYXJyaXNvbkBJbnRlbC5jb20gd3JvdGU6Cj4g RnJvbTogSm9obiBIYXJyaXNvbiA8Sm9obi5DLkhhcnJpc29uQEludGVsLmNvbT4KPiAKPiBBcyBw ZXIgcmV2aWV3IGZlZWRiYWNrIGJ5IFR2cnRrbywgYWRkZWQgYSBjaGVjayB0aGF0IG5vIGludmFs aWQgYml0cwo+IGFyZSBiZWluZyBzZXQgaW4gdGhlIHdoaXRlbGlzdCBmbGFncyBmaWVsZHMuCj4g Cj4gQWxzbyB1cGRhdGVkIHRoZSByZWFkL3dyaXRlIGFjY2VzcyBkZWZpbml0aW9ucyB0byBtYWtl IGl0IGNsZWFyZXIgdGhhdAo+IHRoZXkgYXJlIGFuIGVudW0gZmllbGQgbm90IGEgc2V0IG9mIHNp bmdsZSBiaXQgZmxhZ3MuCj4gCj4gU2lnbmVkLW9mZi1ieTogSm9obiBIYXJyaXNvbiA8Sm9obi5D LkhhcnJpc29uQEludGVsLmNvbT4KPiBDQzogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGlu QGludGVsLmNvbT4KCllvdSBsb3N0IGFsbCBteSByLWIncy4KClJldmlld2VkLWJ5OiBUdnJ0a28g VXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgoKUmVnYXJkcywKClR2cnRrbwoKPiAt LS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2d0L2ludGVsX3dvcmthcm91bmRzLmMgICB8IDI5 ICsrKysrKysrKysrKysrKy0tLS0KPiAgIC4uLi9ncHUvZHJtL2k5MTUvZ3Qvc2VsZnRlc3Rfd29y a2Fyb3VuZHMuYyAgICB8IDE0ICsrKysrKy0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9yZWcuaCAgICAgICAgICAgICAgIHwgMTIgKysrKysrLS0KPiAgIDMgZmlsZXMgY2hhbmdlZCwg NDIgaW5zZXJ0aW9ucygrKSwgMTMgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2d0L2ludGVsX3dvcmthcm91bmRzLmMgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9ndC9pbnRlbF93b3JrYXJvdW5kcy5jCj4gaW5kZXggOWUwNjkyODZkM2NlLi45NWJlMGYx MDhmMjYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3QvaW50ZWxfd29ya2Fy b3VuZHMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2d0L2ludGVsX3dvcmthcm91bmRz LmMKPiBAQCAtMTAxMSw2ICsxMDExLDIwIEBAIGJvb2wgaW50ZWxfZ3RfdmVyaWZ5X3dvcmthcm91 bmRzKHN0cnVjdCBpbnRlbF9ndCAqZ3QsIGNvbnN0IGNoYXIgKmZyb20pCj4gICAJcmV0dXJuIHdh X2xpc3RfdmVyaWZ5KGd0LT51bmNvcmUsICZndC0+aTkxNS0+Z3Rfd2FfbGlzdCwgZnJvbSk7Cj4g ICB9Cj4gICAKPiArc3RhdGljIGlubGluZSBib29sIGlzX25vbnByaXZfZmxhZ3NfdmFsaWQodTMy IGZsYWdzKQo+ICt7Cj4gKwkvKiBDaGVjayBvbmx5IHZhbGlkIGZsYWcgYml0cyBhcmUgc2V0ICov Cj4gKwlpZiAoZmxhZ3MgJiB+UklOR19GT1JDRV9UT19OT05QUklWX01BU0tfVkFMSUQpCj4gKwkJ cmV0dXJuIGZhbHNlOwo+ICsKPiArCS8qIE5COiBPbmx5IDMgb3V0IG9mIDQgZW51bSB2YWx1ZXMg YXJlIHZhbGlkIGZvciBhY2Nlc3MgZmllbGQgKi8KPiArCWlmICgoZmxhZ3MgJiBSSU5HX0ZPUkNF X1RPX05PTlBSSVZfQUNDRVNTX01BU0spID09Cj4gKwkgICAgUklOR19GT1JDRV9UT19OT05QUklW X0FDQ0VTU19JTlZBTElEKQo+ICsJCXJldHVybiBmYWxzZTsKPiArCj4gKwlyZXR1cm4gdHJ1ZTsK PiArfQo+ICsKPiAgIHN0YXRpYyB2b2lkCj4gICB3aGl0ZWxpc3RfcmVnX2V4dChzdHJ1Y3QgaTkx NV93YV9saXN0ICp3YWwsIGk5MTVfcmVnX3QgcmVnLCB1MzIgZmxhZ3MpCj4gICB7Cj4gQEAgLTEw MjEsNiArMTAzNSw5IEBAIHdoaXRlbGlzdF9yZWdfZXh0KHN0cnVjdCBpOTE1X3dhX2xpc3QgKndh bCwgaTkxNV9yZWdfdCByZWcsIHUzMiBmbGFncykKPiAgIAlpZiAoR0VNX0RFQlVHX1dBUk5fT04o d2FsLT5jb3VudCA+PSBSSU5HX01BWF9OT05QUklWX1NMT1RTKSkKPiAgIAkJcmV0dXJuOwo+ICAg Cj4gKwlpZiAoR0VNX0RFQlVHX1dBUk5fT04oIWlzX25vbnByaXZfZmxhZ3NfdmFsaWQoZmxhZ3Mp KSkKPiArCQlyZXR1cm47Cj4gKwo+ICAgCXdhLnJlZy5yZWcgfD0gZmxhZ3M7Cj4gICAJX3dhX2Fk ZCh3YWwsICZ3YSk7Cj4gICB9Cj4gQEAgLTEwMjgsNyArMTA0NSw3IEBAIHdoaXRlbGlzdF9yZWdf ZXh0KHN0cnVjdCBpOTE1X3dhX2xpc3QgKndhbCwgaTkxNV9yZWdfdCByZWcsIHUzMiBmbGFncykK PiAgIHN0YXRpYyB2b2lkCj4gICB3aGl0ZWxpc3RfcmVnKHN0cnVjdCBpOTE1X3dhX2xpc3QgKndh bCwgaTkxNV9yZWdfdCByZWcpCj4gICB7Cj4gLQl3aGl0ZWxpc3RfcmVnX2V4dCh3YWwsIHJlZywg UklOR19GT1JDRV9UT19OT05QUklWX1JXKTsKPiArCXdoaXRlbGlzdF9yZWdfZXh0KHdhbCwgcmVn LCBSSU5HX0ZPUkNFX1RPX05PTlBSSVZfQUNDRVNTX1JXKTsKPiAgIH0KPiAgIAo+ICAgc3RhdGlj IHZvaWQgZ2VuOV93aGl0ZWxpc3RfYnVpbGQoc3RydWN0IGk5MTVfd2FfbGlzdCAqdykKPiBAQCAt MTEwOSw3ICsxMTI2LDcgQEAgc3RhdGljIHZvaWQgY2ZsX3doaXRlbGlzdF9idWlsZChzdHJ1Y3Qg aW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4gICAJICogICAtIFBTX0RFUFRIX0NPVU5UX1VEVwo+ ICAgCSAqLwo+ICAgCXdoaXRlbGlzdF9yZWdfZXh0KHcsIFBTX0lOVk9DQVRJT05fQ09VTlQsCj4g LQkJCSAgUklOR19GT1JDRV9UT19OT05QUklWX1JEIHwKPiArCQkJICBSSU5HX0ZPUkNFX1RPX05P TlBSSVZfQUNDRVNTX1JEIHwKPiAgIAkJCSAgUklOR19GT1JDRV9UT19OT05QUklWX1JBTkdFXzQp Owo+ICAgfQo+ICAgCj4gQEAgLTExNDksMjAgKzExNjYsMjAgQEAgc3RhdGljIHZvaWQgaWNsX3do aXRlbGlzdF9idWlsZChzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4gICAJCSAqICAg LSBQU19ERVBUSF9DT1VOVF9VRFcKPiAgIAkJICovCj4gICAJCXdoaXRlbGlzdF9yZWdfZXh0KHcs IFBTX0lOVk9DQVRJT05fQ09VTlQsCj4gLQkJCQkgIFJJTkdfRk9SQ0VfVE9fTk9OUFJJVl9SRCB8 Cj4gKwkJCQkgIFJJTkdfRk9SQ0VfVE9fTk9OUFJJVl9BQ0NFU1NfUkQgfAo+ICAgCQkJCSAgUklO R19GT1JDRV9UT19OT05QUklWX1JBTkdFXzQpOwo+ICAgCQlicmVhazsKPiAgIAo+ICAgCWNhc2Ug VklERU9fREVDT0RFX0NMQVNTOgo+ICAgCQkvKiBodWNTdGF0dXNSZWdPZmZzZXQgKi8KPiAgIAkJ d2hpdGVsaXN0X3JlZ19leHQodywgX01NSU8oMHgyMDAwICsgZW5naW5lLT5tbWlvX2Jhc2UpLAo+ IC0JCQkJICBSSU5HX0ZPUkNFX1RPX05PTlBSSVZfUkQpOwo+ICsJCQkJICBSSU5HX0ZPUkNFX1RP X05PTlBSSVZfQUNDRVNTX1JEKTsKPiAgIAkJLyogaHVjVUtlcm5lbEhkckluZm9SZWdPZmZzZXQg Ki8KPiAgIAkJd2hpdGVsaXN0X3JlZ19leHQodywgX01NSU8oMHgyMDE0ICsgZW5naW5lLT5tbWlv X2Jhc2UpLAo+IC0JCQkJICBSSU5HX0ZPUkNFX1RPX05PTlBSSVZfUkQpOwo+ICsJCQkJICBSSU5H X0ZPUkNFX1RPX05PTlBSSVZfQUNDRVNTX1JEKTsKPiAgIAkJLyogaHVjU3RhdHVzMlJlZ09mZnNl dCAqLwo+ICAgCQl3aGl0ZWxpc3RfcmVnX2V4dCh3LCBfTU1JTygweDIzQjAgKyBlbmdpbmUtPm1t aW9fYmFzZSksCj4gLQkJCQkgIFJJTkdfRk9SQ0VfVE9fTk9OUFJJVl9SRCk7Cj4gKwkJCQkgIFJJ TkdfRk9SQ0VfVE9fTk9OUFJJVl9BQ0NFU1NfUkQpOwo+ICAgCQlicmVhazsKPiAgIAo+ICAgCWRl ZmF1bHQ6Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2d0L3NlbGZ0ZXN0X3dv cmthcm91bmRzLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9ndC9zZWxmdGVzdF93b3JrYXJvdW5k cy5jCj4gaW5kZXggZmEwMWVhNzg1NWRlLi40NjZkY2M4MjE0YzMgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvZ3Qvc2VsZnRlc3Rfd29ya2Fyb3VuZHMuYwo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2d0L3NlbGZ0ZXN0X3dvcmthcm91bmRzLmMKPiBAQCAtMzk3LDYgKzM5 NywxMCBAQCBzdGF0aWMgYm9vbCB3b19yZWdpc3RlcihzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICpl bmdpbmUsIHUzMiByZWcpCj4gICAJZW51bSBpbnRlbF9wbGF0Zm9ybSBwbGF0Zm9ybSA9IElOVEVM X0lORk8oZW5naW5lLT5pOTE1KS0+cGxhdGZvcm07Cj4gICAJaW50IGk7Cj4gICAKPiArCWlmICgo cmVnICYgUklOR19GT1JDRV9UT19OT05QUklWX0FDQ0VTU19NQVNLKSA9PQo+ICsJICAgICBSSU5H X0ZPUkNFX1RPX05PTlBSSVZfQUNDRVNTX1dSKQo+ICsJCXJldHVybiB0cnVlOwo+ICsKPiAgIAlm b3IgKGkgPSAwOyBpIDwgQVJSQVlfU0laRSh3b19yZWdpc3RlcnMpOyBpKyspIHsKPiAgIAkJaWYg KHdvX3JlZ2lzdGVyc1tpXS5wbGF0Zm9ybSA9PSBwbGF0Zm9ybSAmJgo+ICAgCQkgICAgd29fcmVn aXN0ZXJzW2ldLnJlZyA9PSByZWcpCj4gQEAgLTQwOCw3ICs0MTIsOCBAQCBzdGF0aWMgYm9vbCB3 b19yZWdpc3RlcihzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUsIHUzMiByZWcpCj4gICAK PiAgIHN0YXRpYyBib29sIHJvX3JlZ2lzdGVyKHUzMiByZWcpCj4gICB7Cj4gLQlpZiAocmVnICYg UklOR19GT1JDRV9UT19OT05QUklWX1JEKQo+ICsJaWYgKChyZWcgJiBSSU5HX0ZPUkNFX1RPX05P TlBSSVZfQUNDRVNTX01BU0spID09Cj4gKwkgICAgIFJJTkdfRk9SQ0VfVE9fTk9OUFJJVl9BQ0NF U1NfUkQpCj4gICAJCXJldHVybiB0cnVlOwo+ICAgCj4gICAJcmV0dXJuIGZhbHNlOwo+IEBAIC03 NjAsOCArNzY1LDggQEAgc3RhdGljIGludCByZWFkX3doaXRlbGlzdGVkX3JlZ2lzdGVycyhzdHJ1 Y3QgaTkxNV9nZW1fY29udGV4dCAqY3R4LAo+ICAgCQl1NjQgb2Zmc2V0ID0gcmVzdWx0cy0+bm9k ZS5zdGFydCArIHNpemVvZih1MzIpICogaTsKPiAgIAkJdTMyIHJlZyA9IGk5MTVfbW1pb19yZWdf b2Zmc2V0KGVuZ2luZS0+d2hpdGVsaXN0Lmxpc3RbaV0ucmVnKTsKPiAgIAo+IC0JCS8qIENsZWFy IFJEIG9ubHkgYW5kIFdSIG9ubHkgZmxhZ3MgKi8KPiAtCQlyZWcgJj0gfihSSU5HX0ZPUkNFX1RP X05PTlBSSVZfUkQgfCBSSU5HX0ZPUkNFX1RPX05PTlBSSVZfV1IpOwo+ICsJCS8qIENsZWFyIGFj Y2VzcyBwZXJtaXNzaW9uIGZpZWxkICovCj4gKwkJcmVnICY9IH5SSU5HX0ZPUkNFX1RPX05PTlBS SVZfQUNDRVNTX01BU0s7Cj4gICAKPiAgIAkJKmNzKysgPSBzcm07Cj4gICAJCSpjcysrID0gcmVn Owo+IEBAIC05MzEsNyArOTM2LDggQEAgY2hlY2tfd2hpdGVsaXN0ZWRfcmVnaXN0ZXJzKHN0cnVj dCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSwKPiAgIAlmb3IgKGkgPSAwOyBpIDwgZW5naW5lLT53 aGl0ZWxpc3QuY291bnQ7IGkrKykgewo+ICAgCQljb25zdCBzdHJ1Y3QgaTkxNV93YSAqd2EgPSAm ZW5naW5lLT53aGl0ZWxpc3QubGlzdFtpXTsKPiAgIAo+IC0JCWlmIChpOTE1X21taW9fcmVnX29m ZnNldCh3YS0+cmVnKSAmIFJJTkdfRk9SQ0VfVE9fTk9OUFJJVl9SRCkKPiArCQlpZiAoaTkxNV9t bWlvX3JlZ19vZmZzZXQod2EtPnJlZykgJgo+ICsJCSAgICBSSU5HX0ZPUkNFX1RPX05PTlBSSVZf QUNDRVNTX1JEKQo+ICAgCQkJY29udGludWU7Cj4gICAKPiAgIAkJaWYgKCFmbihlbmdpbmUsIGFb aV0sIGJbaV0sIHdhLT5yZWcpKQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X3JlZy5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaAo+IGluZGV4IDNmZjY1 OWExODBlNi4uZTE0YzliNzZjMmQwIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfcmVnLmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oCj4gQEAg LTI1MjIsMTMgKzI1MjIsMTkgQEAgZW51bSBpOTE1X3Bvd2VyX3dlbGxfaWQgewo+ICAgI2RlZmlu ZSAgIFJJTkdfV0FJVF9TRU1BUEhPUkUJKDEgPDwgMTApIC8qIGdlbjYrICovCj4gICAKPiAgICNk ZWZpbmUgUklOR19GT1JDRV9UT19OT05QUklWKGJhc2UsIGkpIF9NTUlPKCgoYmFzZSkgKyAweDRE MCkgKyAoaSkgKiA0KQo+IC0jZGVmaW5lICAgUklOR19GT1JDRV9UT19OT05QUklWX1JXCQkoMCA8 PCAyOCkgICAgLyogQ0ZMKyAmIEdlbjExKyAqLwo+IC0jZGVmaW5lICAgUklOR19GT1JDRV9UT19O T05QUklWX1JECQkoMSA8PCAyOCkKPiAtI2RlZmluZSAgIFJJTkdfRk9SQ0VfVE9fTk9OUFJJVl9X UgkJKDIgPDwgMjgpCj4gKyNkZWZpbmUgICBSSU5HX0ZPUkNFX1RPX05PTlBSSVZfQUNDRVNTX1JX CSgwIDw8IDI4KSAgICAvKiBDRkwrICYgR2VuMTErICovCj4gKyNkZWZpbmUgICBSSU5HX0ZPUkNF X1RPX05PTlBSSVZfQUNDRVNTX1JECSgxIDw8IDI4KQo+ICsjZGVmaW5lICAgUklOR19GT1JDRV9U T19OT05QUklWX0FDQ0VTU19XUgkoMiA8PCAyOCkKPiArI2RlZmluZSAgIFJJTkdfRk9SQ0VfVE9f Tk9OUFJJVl9BQ0NFU1NfSU5WQUxJRAkoMyA8PCAyOCkKPiArI2RlZmluZSAgIFJJTkdfRk9SQ0Vf VE9fTk9OUFJJVl9BQ0NFU1NfTUFTSwkoMyA8PCAyOCkKPiAgICNkZWZpbmUgICBSSU5HX0ZPUkNF X1RPX05PTlBSSVZfUkFOR0VfMQkJKDAgPDwgMCkgICAgIC8qIENGTCsgJiBHZW4xMSsgKi8KPiAg ICNkZWZpbmUgICBSSU5HX0ZPUkNFX1RPX05PTlBSSVZfUkFOR0VfNAkJKDEgPDwgMCkKPiAgICNk ZWZpbmUgICBSSU5HX0ZPUkNFX1RPX05PTlBSSVZfUkFOR0VfMTYJKDIgPDwgMCkKPiAgICNkZWZp bmUgICBSSU5HX0ZPUkNFX1RPX05PTlBSSVZfUkFOR0VfNjQJKDMgPDwgMCkKPiArI2RlZmluZSAg IFJJTkdfRk9SQ0VfVE9fTk9OUFJJVl9SQU5HRV9NQVNLCSgzIDw8IDApCj4gKyNkZWZpbmUgICBS SU5HX0ZPUkNFX1RPX05PTlBSSVZfTUFTS19WQUxJRAlcCj4gKwkJCQkJKFJJTkdfRk9SQ0VfVE9f Tk9OUFJJVl9SQU5HRV9NQVNLIFwKPiArCQkJCQl8IFJJTkdfRk9SQ0VfVE9fTk9OUFJJVl9BQ0NF U1NfTUFTSykKPiAgICNkZWZpbmUgICBSSU5HX01BWF9OT05QUklWX1NMT1RTICAxMgo+ICAgCj4g ICAjZGVmaW5lIEdFTjdfVExCX1JEX0FERFIJX01NSU8oMHg0NzAwKQo+IApfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0 CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=