Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BA65C2D0DB for ; Thu, 23 Jan 2020 14:41:28 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EB42D20704 for ; Thu, 23 Jan 2020 14:41:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="N3gbl1vq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EB42D20704 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58284 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iudfi-0006FN-Kd for qemu-devel@archiver.kernel.org; Thu, 23 Jan 2020 09:41:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50107) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iubcl-0007Fa-IO for qemu-devel@nongnu.org; Thu, 23 Jan 2020 07:30:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iubck-0000MI-0G for qemu-devel@nongnu.org; Thu, 23 Jan 2020 07:30:15 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:27565 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iubcj-0000LZ-TE for qemu-devel@nongnu.org; Thu, 23 Jan 2020 07:30:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579782613; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6yrraR8C7IeHS3I7NQKMgH6g3S12t8aTAComhJ72ZTw=; b=N3gbl1vq05BuAB25UZuZZa1eYMlBWcda1flcwIBKYmAdr5X6XcBCnuWeRKSuBTskGDU4/b av1RE5pFzRrRBgAN7iJSyBAjopN63/dRG0MzjdO2VRk6Ay3dcIsjCF35oqZVBVX29GnPBs j866uP9J+91hnelsHITndakDKCP0NAg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-165-qsNE_EVlNCyMd6E1lTkYYw-1; Thu, 23 Jan 2020 07:30:09 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BF6721902EA8; Thu, 23 Jan 2020 12:30:08 +0000 (UTC) Received: from [10.3.117.16] (ovpn-117-16.phx2.redhat.com [10.3.117.16]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E3CAA8575F; Thu, 23 Jan 2020 12:30:05 +0000 (UTC) Subject: Re: [PATCH] qemu-nbd: Removed deprecated --partition option To: Max Reitz , qemu-devel@nongnu.org References: <20200122214328.1413664-1-eblake@redhat.com> From: Eric Blake Organization: Red Hat, Inc. Message-ID: <7084da4a-fa6a-e4ab-868d-2ad397dd5cb3@redhat.com> Date: Thu, 23 Jan 2020 06:30:05 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: qsNE_EVlNCyMd6E1lTkYYw-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "reviewer:Incompatible changes" , qemu-block@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 1/23/20 6:10 AM, Max Reitz wrote: > On 22.01.20 22:43, Eric Blake wrote: >> The option was deprecated in 4.0.0 (commit 0ae2d546); it's now been >> long enough with no complaints to follow through with that process. >> >> Signed-off-by: Eric Blake >> --- >> -@code{qemu-nbd -t -P 1 -f qcow2 file.qcow2} >> - >> -can be rewritten as: >> - >> -@code{qemu-nbd -t --image-opts driver=3Draw,offset=3D1M,size=3D100M,fil= e.driver=3Dqcow2,file.backing.driver=3Dfile,file.backing.filename=3Dfile.qc= ow2} >> - >> +can be rewritten as: >> + >> +@code{qemu-nbd -t --image-opts driver=3Draw,offset=3D1M,size=3D100M,fil= e.driver=3Dqcow2,file.backing.driver=3Dfile,file.backing.filename=3Dfile.qc= ow2} >=20 > I know you just moved it from above, but isn=E2=80=99t this wrong? Shoul= dn=E2=80=99t it > be s/backing/file/g? Indeed; file.file.driver=3Dfile,file.file.filename=3Dfile.qcow2 is required= =20 for it to work, rather than fail with qemu-nbd: Failed to blk_new_open=20 'driver=3Draw,offset=3D1m,size=3D100m,file.driver=3Dqcow2,file.backing.driv= er=3Dfile,file.backing.filename=3Dfile4':=20 A block device must be specified for "file" I'll repost with the bug-fix as a separate commit (and it's a shame that=20 we've gone nearly a year with no one noticing the typo in the original). --=20 Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org