From: Akio Takebe Subject: [Patch] Re: [RFC] Is grant_read() runnable? Date: Thu, 26 Jan 2006 09:01:17 +0900 Message-ID: <70C6220BA19717takebe_akio@jp.fujitsu.com> References: <6DC621873B343Dtakebe_akio@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="Boundary-NokLc1LWt1T75rTX4no5o" Return-path: In-Reply-To: <6DC621873B343Dtakebe_akio@jp.fujitsu.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Akio Takebe , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org --Boundary-NokLc1LWt1T75rTX4no5o Content-Type: text/plain; charset=iso-2022-jp Content-Transfer-Encoding: 7bit Content-Description: Mail message body Hi, all I'm sorry for poor English. I rewrite my mail. Even if/proc/xen/grant is read, nothing is displayed probably. I comment to the following sources. So I make patch. Is my patch correct? ---------------------- static int grant_read(char *page, char **start, off_t off, int count, int *eof, void *data) { int len; unsigned int i; grant_entry_t *gt; gt = (grant_entry_t *)shared; len = 0; for (i = 0; i < NR_GRANT_ENTRIES; i++) { if (len > (PAGE_SIZE - 200)) { <---- always FAIL len += sprintf( page + len, "Truncated.\n"); break; } } if (gt[i].flags) { <--- always gt[NR_GRANT_ENTRIES].flags len += sprintf(page + len, "Grant: ref (0x%x) flags (0x%hx) " "dom (0x%hx) frame (0x%x)\n", i, gt[i].flags, gt[i].domid, gt[i].frame ); <--- So This sprintf doesn't make sence almost. } *eof = 1; return len; } Best Regards, Akio Takebe >Hi, all > >I think grant_read() is not runnable. >" (len > (PAGE_SIZE - 200)) " is not entered into if sentence >becase of len=0. >So i always equal NR_GRANT_ENTRIES. > >Is the below patch correct? >Please comment. > >Best Regards, > >Akio Takebe > --Boundary-NokLc1LWt1T75rTX4no5o Content-Type: application/octet-stream; name="grant_read.patch" Content-Disposition: attachment; filename="grant_read.patch" Content-Transfer-Encoding: base64 VGhpcyBpcyBwYXRjaCBmb3IgYmVpbmcgYWJsZSB0byByZWFkIC9wcm9jL3hlbi9ncmFudC4N Cg0KU2lnbmVkLW9mZi1ieTogQWtpbyBUYWtlYmUgPHRha2ViZV9ha2lvQGpwLmZ1aml0c3Uu Y29tPg0KDQpkaWZmIC1yIGEzOGMyOTJlODM5MCBsaW51eC0yLjYteGVuLXNwYXJzZS9hcmNo L3hlbi9rZXJuZWwvZ250dGFiLmMNCi0tLSBhL2xpbnV4LTIuNi14ZW4tc3BhcnNlL2FyY2gv eGVuL2tlcm5lbC9nbnR0YWIuYyAgICAgVHVlIEphbiAyNCAxNjo1NDozNCAyMDA2DQorKysg Yi9saW51eC0yLjYteGVuLXNwYXJzZS9hcmNoL3hlbi9rZXJuZWwvZ250dGFiLmMgICAgIFdl ZCBKYW4gMjUgMTc6MDE6MDMgMjAwNg0KQEAgLTM2MSwyMiArMzYxLDIyIEBADQogICAgICAg IGxlbiA9IDA7DQogDQogICAgICAgIGZvciAoaSA9IDA7IGkgPCBOUl9HUkFOVF9FTlRSSUVT OyBpKyspIHsNCi0gICAgICAgICAgICAgICBpZiAobGVuID4gKFBBR0VfU0laRSAtIDIwMCkp IHsNCisgICAgICAgICAgICAgICBpZiAobGVuIDwgKFBBR0VfU0laRSAtIDIwMCkpIHsNCiAg ICAgICAgICAgICAgICAgICAgICAgIGxlbiArPSBzcHJpbnRmKCBwYWdlICsgbGVuLCAiVHJ1 bmNhdGVkLlxuIik7DQogICAgICAgICAgICAgICAgICAgICAgICBicmVhazsNCiAgICAgICAg ICAgICAgICB9DQotICAgICAgIH0NCi0NCi0gICAgICAgaWYgKGd0W2ldLmZsYWdzKSB7DQot ICAgICAgICAgICAgICAgbGVuICs9IHNwcmludGYocGFnZSArIGxlbiwNCi0gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAiR3JhbnQ6IHJlZiAoMHgleCkgZmxhZ3MgKDB4JWh4KSAi DQotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgImRvbSAoMHglaHgpIGZyYW1lICgw eCV4KVxuIiwgDQotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaSwNCi0gICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBndFtpXS5mbGFncywNCi0gICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBndFtpXS5kb21pZCwNCi0gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBndFtpXS5mcmFtZSApOw0KLSAgICAgICB9DQotDQorDQorICAgICAgICAgICAgICAg aWYgKGd0W2ldLmZsYWdzKSB7DQorICAgICAgICAgICAgICAgICAgICAgICBsZW4gKz0gc3By aW50ZihwYWdlICsgbGVuLA0KKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIkdyYW50OiByZWYgKDB4JXgpIGZsYWdzICgweCVoeCkgIg0KKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgImRvbSAoMHglaHgpIGZyYW1lICgweCV4KVxuIiwg DQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpLA0KKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZ3RbaV0uZmxhZ3MsDQorICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBndFtpXS5kb21pZCwNCisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGd0W2ldLmZyYW1lICk7DQorICAgICAgICAg ICAgICAgfQ0KKw0KKyAgICAgICB9DQogICAgICAgICplb2YgPSAxOw0KICAgICAgICByZXR1 cm4gbGVuOw0KIH0= --Boundary-NokLc1LWt1T75rTX4no5o Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --Boundary-NokLc1LWt1T75rTX4no5o--