Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7BEBC10F0E for ; Wed, 10 Apr 2019 00:43:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7BEB621741 for ; Wed, 10 Apr 2019 00:43:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XzcgQNcc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726798AbfDJAnq (ORCPT ); Tue, 9 Apr 2019 20:43:46 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:43357 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726730AbfDJAnp (ORCPT ); Tue, 9 Apr 2019 20:43:45 -0400 Received: by mail-pg1-f193.google.com with SMTP id z9so397624pgu.10 for ; Tue, 09 Apr 2019 17:43:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=jxJxR7PHoFk9i7vvOTE7LQT5MSO/qVLQ7j0N4lR39Bc=; b=XzcgQNccwyTl+SnfIXvstzalq1TBWvGvhMFIARr7AiSKTNwraR4i/MDySTG2Q3JFxq Y1phV9nnLdp3wTUrnsSeFMYCbGWBqwL3tSndOPZqbRXLGwm8nFXiFn90dRaFcDOH11wP lcS1ejMu30x8ehTJtj0L2ZLQCOTdsbmHLTbtsqegvZj3rlh6t72LknK5Owbpv2nxtfRI SC/Xj/nkXy83z8ePAOlvTe3Yk6N/hEwHt5BhYlb1Iuy0Tprw+3+/3uBOHE1RqJU+ZLm1 jCN6VRtxlNzk1pbunRJypL1uTVgwrXL8+D7vL2pcrrlFncA+KNAxxf90dz+9iE1OnWrr OojA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jxJxR7PHoFk9i7vvOTE7LQT5MSO/qVLQ7j0N4lR39Bc=; b=NZvGNGckkEstCZ1QTkbU+EEDOyR4Vau4MQ4mcCBqtJM6G7yegr54hcnGXlEQk9Arll u0EfqOgVhNZayv/g9AVq9DmbalT/WsjEqzT7BhBjwPaeM44Vg9G6VXytIfcx9yJjut8b AQeCOjf5fBH9u7yEwY2VDB5TH/0ZK4bq2g5HF66u+4XJa8kAszfwBpv2SMRu4H9Il+VR M1HSH1+feEuOVLmLwJMVY+lYwIDGZ159RrAsQV6ZI7xkRInNOEmahJVMBbJOoMGLGfJY sbj7XuBPRerbc1osVjN2UJga1K8/rJ61Hhb9icaALvVZ+MXj3Lb2DYoF7sdo5c4K6Qkg Rffg== X-Gm-Message-State: APjAAAW90NqwRG1pIxczEFcrCgu1y/cZYTerBQXQQbmsT3CZyn07xFd/ qkSnsEh+892IYcQfx/fXn2g= X-Google-Smtp-Source: APXvYqycLWNs7m44n4IGDuN5bkHZ66T92uiEtrfHgfbLX1Q32FUDvAUOmGL/hpOIOOiiV2143pO4Kg== X-Received: by 2002:aa7:8615:: with SMTP id p21mr40306791pfn.98.1554857025148; Tue, 09 Apr 2019 17:43:45 -0700 (PDT) Received: from [10.40.10.243] (fw.cumulusnetworks.com. [216.129.126.126]) by smtp.googlemail.com with ESMTPSA id a3sm55756887pfn.182.2019.04.09.17.43.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Apr 2019 17:43:43 -0700 (PDT) Subject: Re: [PATCH v2 net-next 08/18] ipv4: Refactor fib_check_nh To: Govindarajulu Varadarajan , David Ahern Cc: davem@davemloft.net, netdev@vger.kernel.org, idosch@mellanox.com, jiri@mellanox.com, benve@cisco.com References: <20190405233041.30775-1-dsahern@kernel.org> <20190405233041.30775-9-dsahern@kernel.org> From: David Ahern Message-ID: <70a46492-5d87-59fd-fa67-29c6d276c8a0@gmail.com> Date: Tue, 9 Apr 2019 17:43:42 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 4/9/19 5:08 PM, Govindarajulu Varadarajan wrote: > On Fri, Apr 5, 2019 at 4:32 PM David Ahern wrote: >> >> From: David Ahern >> >> fib_check_nh is currently huge covering multiple uses cases - device only, >> device + gateway, and device + gateway with ONLINK. The next patch adds >> validation checks for IPv6 which only further complicates it. So, break >> fib_check_nh into 2 helpers - one for gateway validation and one for device >> only. >> >> Signed-off-by: David Ahern >> Reviewed-by: Ido Schimmel > > With the latest net-next I am having issue with network traffic. > git bisect points to this commit as the first bad commit. > (448d7248191706cbbd7761e3bc72c2985c4d38a7 ipv4: Refactor fib_check_nh) > Thanks for the report. I'll take a look tonight.