From: "cron2 (Code Review)" Date: Thu, 25 Jul 2024 15:55:19 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <70bdb715ad5b61abf2d6bd5e50866f61d7d43009-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="cR7wcNwVR3E="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: console_systemd: rename query_user_exec to query_user_systemd List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld Cc: plaisthos , openvpn-devel --cR7wcNwVR3E= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/670?usp=3Demail ) Change subject: console_systemd: rename query_user_exec to query_user_syste= md ...................................................................... Patch Set 3: Code-Review+1 (2 comments) Patchset: PS3: I think this is a good change. I had one comment about the code-in-header = and making them inline, though... what do you think? File src/openvpn/console.h: http://gerrit.openvpn.net/c/openvpn/+/670/comment/a68c3cbb_5ae4e68e : PS3, Line 94: static bool our normal convention seems to be "if there is code in .h files, it's tagge= d as inline". I can see that this is not true for the existing query_user_= exec() wrapper, but maybe we want to fix this as well here? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/670?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I379e1eb6dc57b9fe4bbdaefbd947a14326e7117a Gerrit-Change-Number: 670 Gerrit-PatchSet: 3 Gerrit-Owner: flichtenheld Gerrit-Reviewer: cron2 Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Thu, 25 Jul 2024 15:55:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --cR7wcNwVR3E= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, plaisthos.

Patch set 3:Code-Review +1=

Vi= ew Change

2 comments:

  • Patchset:

    • Patch Set #3:

      I think this is a good change. I had one com= ment about the code-in-header and making them inline, though... what do you= think?

  • File src/= openvpn/console.h:

    • = Patch Set #3, Line 94: = static bool

      our normal convention seems to be "if there is code in .h files,= it's tagged as inline". I can see that this is not true for the = existing query_user_exec() wrapper, but maybe we want to fix this as well h= ere?

To view, visit change 670. To unsubscribe, or for= help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I379e1eb6dc57b9fe4bbdaefbd94= 7a14326e7117a
Gerrit-Change-Number: 670
Gerrit-PatchSet: 3
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Comment-Date: Thu, 25 Jul 2024 15:55:19= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--cR7wcNwVR3E=--