From: Sagar Arun Kamble Subject: Re: [PATCH v2 01/15] drm/i915/guc: Tidy guc_log_control Date: Fri, 9 Mar 2018 11:16:27 +0530 Message-ID: <70cfee37-b1c0-ef98-b692-b77d1bd0e06f@intel.com> References: <20180308154707.21716-1-michal.winiarski@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id ECF806E2F3 for ; Fri, 9 Mar 2018 05:46:30 +0000 (UTC) In-Reply-To: <20180308154707.21716-1-michal.winiarski@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?UTF-8?Q?Micha=c5=82_Winiarski?= , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org CgpPbiAzLzgvMjAxOCA5OjE2IFBNLCBNaWNoYcWCIFdpbmlhcnNraSB3cm90ZToKPiBXZSBwbGFu IHRvIGRlY291cGxlIGxvZyBydW50aW1lIChtYXBwaW5nICsgcmVsYXkpIGZyb20gdmVyYm9zaXR5 IGNvbnRyb2wuCj4gTGV0J3MgdGlkeSB0aGUgY29kZSBub3cgdG8gcmVkdWNlIHRoZSBjaHVybiBp biB0aGUgZm9sbG93aW5nIHBhdGNoZXMuCj4KPiB2MjogVGlkeSBtYWNyb3MsIGtlZXAgZGVidWcg bWVzc2FnZXMsIHVzZSBoZWxwZXIgdmFyIGZvciBlbmFibGUsCj4gICAgICBjb3JyZWN0IHR5cG8g KE1pY2hhxYIpCj4gICAgICBGaXggaW5jb3JyZWN0IGlucHV0IHZhbGlkYWN0aW9uIChTYWdhcikK Pgo+IFNpZ25lZC1vZmYtYnk6IE1pY2hhxYIgV2luaWFyc2tpIDxtaWNoYWwud2luaWFyc2tpQGlu dGVsLmNvbT4KPiBDYzogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4g Q2M6IERhbmllbGUgQ2VyYW9sbyBTcHVyaW8gPGRhbmllbGUuY2VyYW9sb3NwdXJpb0BpbnRlbC5j b20+Cj4gQ2M6IE1pY2hhbCBXYWpkZWN6a28gPG1pY2hhbC53YWpkZWN6a29AaW50ZWwuY29tPgo+ IENjOiBTYWdhciBBcnVuIEthbWJsZSA8c2FnYXIuYS5rYW1ibGVAaW50ZWwuY29tPgpSZXZpZXdl ZC1ieTogU2FnYXIgQXJ1biBLYW1ibGUgPHNhZ2FyLmEua2FtYmxlQGludGVsLmNvbT4KPiAtLS0K PiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jICB8IDExICsrLS0tCj4gICBk cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWNfbG9nLmMgfCA4MCArKysrKysrKysrKysrKysr KysrKystLS0tLS0tLS0tLS0tLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19s b2cuaCB8ICAzICstCj4gICAzIGZpbGVzIGNoYW5nZWQsIDUzIGluc2VydGlvbnMoKyksIDQxIGRl bGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVi dWdmcy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMKPiBpbmRleCA4OWY3 ZmYyYzY1MmUuLmZhMDc1NWZlMTBkMCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pOTE1X2RlYnVnZnMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVidWdm cy5jCj4gQEAgLTI1MDAsMTMgKzI1MDAsMTAgQEAgc3RhdGljIGludCBpOTE1X2d1Y19sb2dfY29u dHJvbF9nZXQodm9pZCAqZGF0YSwgdTY0ICp2YWwpCj4gICB7Cj4gICAJc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUgKmRldl9wcml2ID0gZGF0YTsKPiAgIAo+IC0JaWYgKCFIQVNfR1VDKGRldl9wcml2 KSkKPiArCWlmICghVVNFU19HVUMoZGV2X3ByaXYpKQo+ICAgCQlyZXR1cm4gLUVOT0RFVjsKPiAg IAo+IC0JaWYgKCFkZXZfcHJpdi0+Z3VjLmxvZy52bWEpCj4gLQkJcmV0dXJuIC1FSU5WQUw7Cj4g LQo+IC0JKnZhbCA9IGk5MTVfbW9kcGFyYW1zLmd1Y19sb2dfbGV2ZWw7Cj4gKwkqdmFsID0gaW50 ZWxfZ3VjX2xvZ19jb250cm9sX2dldCgmZGV2X3ByaXYtPmd1Yyk7Cj4gICAKPiAgIAlyZXR1cm4g MDsKPiAgIH0KPiBAQCAtMjUxNSwxMCArMjUxMiwxMCBAQCBzdGF0aWMgaW50IGk5MTVfZ3VjX2xv Z19jb250cm9sX3NldCh2b2lkICpkYXRhLCB1NjQgdmFsKQo+ICAgewo+ICAgCXN0cnVjdCBkcm1f aTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGRhdGE7Cj4gICAKPiAtCWlmICghSEFTX0dVQyhkZXZf cHJpdikpCj4gKwlpZiAoIVVTRVNfR1VDKGRldl9wcml2KSkKPiAgIAkJcmV0dXJuIC1FTk9ERVY7 Cj4gICAKPiAtCXJldHVybiBpbnRlbF9ndWNfbG9nX2NvbnRyb2woJmRldl9wcml2LT5ndWMsIHZh bCk7Cj4gKwlyZXR1cm4gaW50ZWxfZ3VjX2xvZ19jb250cm9sX3NldCgmZGV2X3ByaXYtPmd1Yywg dmFsKTsKPiAgIH0KPiAgIAo+ICAgREVGSU5FX1NJTVBMRV9BVFRSSUJVVEUoaTkxNV9ndWNfbG9n X2NvbnRyb2xfZm9wcywKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf Z3VjX2xvZy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX2xvZy5jCj4gaW5kZXgg YzBjMmU3ZDFjN2Q3Li43ZTU5ZmIwN2IwNmIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZ3VjX2xvZy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf Z3VjX2xvZy5jCj4gQEAgLTY1OSw1MSArNjU5LDYzIEBAIHZvaWQgaW50ZWxfZ3VjX2xvZ19kZXN0 cm95KHN0cnVjdCBpbnRlbF9ndWMgKmd1YykKPiAgIAlpOTE1X3ZtYV91bnBpbl9hbmRfcmVsZWFz ZSgmZ3VjLT5sb2cudm1hKTsKPiAgIH0KPiAgIAo+IC1pbnQgaW50ZWxfZ3VjX2xvZ19jb250cm9s KHN0cnVjdCBpbnRlbF9ndWMgKmd1YywgdTY0IGNvbnRyb2xfdmFsKQo+ICtpbnQgaW50ZWxfZ3Vj X2xvZ19jb250cm9sX2dldChzdHJ1Y3QgaW50ZWxfZ3VjICpndWMpCj4gK3sKPiArCUdFTV9CVUdf T04oIWd1Yy0+bG9nLnZtYSk7Cj4gKwlHRU1fQlVHX09OKGk5MTVfbW9kcGFyYW1zLmd1Y19sb2df bGV2ZWwgPCAwKTsKPiArCj4gKwlyZXR1cm4gaTkxNV9tb2RwYXJhbXMuZ3VjX2xvZ19sZXZlbDsK PiArfQo+ICsKPiArI2RlZmluZSBHVUNfTE9HX0xFVkVMX0RJU0FCTEVECQkwCj4gKyNkZWZpbmUg TE9HX0xFVkVMX1RPX0VOQUJMRUQoeCkJCSgoeCkgPiAwKQo+ICsjZGVmaW5lIExPR19MRVZFTF9U T19WRVJCT1NJVFkoeCkgKHsJCVwKPiArCXR5cGVvZih4KSBfeCA9ICh4KTsJCQlcCj4gKwlMT0df TEVWRUxfVE9fRU5BQkxFRChfeCkgPyBfeCAtIDEgOiAwOwlcCj4gK30pCj4gKyNkZWZpbmUgVkVS Qk9TSVRZX1RPX0xPR19MRVZFTCh4KSAgKCh4KSArIDEpCj4gK2ludCBpbnRlbF9ndWNfbG9nX2Nv bnRyb2xfc2V0KHN0cnVjdCBpbnRlbF9ndWMgKmd1YywgdTY0IHZhbCkKPiAgIHsKPiAgIAlzdHJ1 Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBndWNfdG9faTkxNShndWMpOwo+IC0JYm9v bCBlbmFibGVfbG9nZ2luZyA9IGNvbnRyb2xfdmFsID4gMDsKPiAtCXUzMiB2ZXJib3NpdHk7Cj4g Kwlib29sIGVuYWJsZWQgPSBMT0dfTEVWRUxfVE9fRU5BQkxFRCh2YWwpOwo+ICAgCWludCByZXQ7 Cj4gICAKPiAtCWlmICghZ3VjLT5sb2cudm1hKQo+IC0JCXJldHVybiAtRU5PREVWOwo+ICsJQlVJ TERfQlVHX09OKEdVQ19MT0dfVkVSQk9TSVRZX01JTiAhPSAwKTsKPiArCUdFTV9CVUdfT04oIWd1 Yy0+bG9nLnZtYSk7Cj4gKwlHRU1fQlVHX09OKGk5MTVfbW9kcGFyYW1zLmd1Y19sb2dfbGV2ZWwg PCAwKTsKPiAgIAo+IC0JQlVJTERfQlVHX09OKEdVQ19MT0dfVkVSQk9TSVRZX01JTik7Cj4gLQlp ZiAoY29udHJvbF92YWwgPiAxICsgR1VDX0xPR19WRVJCT1NJVFlfTUFYKQo+ICsJLyoKPiArCSAq IEd1QyBpcyByZWNvZ25pemluZyBsb2cgbGV2ZWxzIHN0YXJ0aW5nIGZyb20gMCB0byBtYXgsIHdl J3JlIHVzaW5nIDAKPiArCSAqIGFzIGluZGljYXRpb24gdGhhdCBsb2dnaW5nIHNob3VsZCBiZSBk aXNhYmxlZC4KPiArCSAqLwo+ICsJaWYgKHZhbCA8IEdVQ19MT0dfTEVWRUxfRElTQUJMRUQgfHwK PiArCSAgICB2YWwgPiBWRVJCT1NJVFlfVE9fTE9HX0xFVkVMKEdVQ19MT0dfVkVSQk9TSVRZX01B WCkpCj4gICAJCXJldHVybiAtRUlOVkFMOwo+ICAgCj4gLQkvKiBUaGlzIGNvbWJpbmF0aW9uIGRv ZXNuJ3QgbWFrZSBzZW5zZSAmIHdvbid0IGhhdmUgYW55IGVmZmVjdCAqLwo+IC0JaWYgKCFlbmFi bGVfbG9nZ2luZyAmJiAhaTkxNV9tb2RwYXJhbXMuZ3VjX2xvZ19sZXZlbCkKPiAtCQlyZXR1cm4g MDsKPiArCW11dGV4X2xvY2soJmRldl9wcml2LT5kcm0uc3RydWN0X211dGV4KTsKPiAgIAo+IC0J dmVyYm9zaXR5ID0gZW5hYmxlX2xvZ2dpbmcgPyBjb250cm9sX3ZhbCAtIDEgOiAwOwo+ICsJaWYg KGk5MTVfbW9kcGFyYW1zLmd1Y19sb2dfbGV2ZWwgPT0gdmFsKSB7Cj4gKwkJcmV0ID0gMDsKPiAr CQlnb3RvIG91dF91bmxvY2s7Cj4gKwl9Cj4gICAKPiAtCXJldCA9IG11dGV4X2xvY2tfaW50ZXJy dXB0aWJsZSgmZGV2X3ByaXYtPmRybS5zdHJ1Y3RfbXV0ZXgpOwo+IC0JaWYgKHJldCkKPiAtCQly ZXR1cm4gcmV0Owo+ICAgCWludGVsX3J1bnRpbWVfcG1fZ2V0KGRldl9wcml2KTsKPiAtCXJldCA9 IGd1Y19sb2dfY29udHJvbChndWMsIGVuYWJsZV9sb2dnaW5nLCB2ZXJib3NpdHkpOwo+ICsJcmV0 ID0gZ3VjX2xvZ19jb250cm9sKGd1YywgZW5hYmxlZCwgTE9HX0xFVkVMX1RPX1ZFUkJPU0lUWSh2 YWwpKTsKPiAgIAlpbnRlbF9ydW50aW1lX3BtX3B1dChkZXZfcHJpdik7Cj4gLQltdXRleF91bmxv Y2soJmRldl9wcml2LT5kcm0uc3RydWN0X211dGV4KTsKPiAtCj4gLQlpZiAocmV0IDwgMCkgewo+ IC0JCURSTV9ERUJVR19EUklWRVIoImd1Y19sb2dnaW5nX2NvbnRyb2wgYWN0aW9uIGZhaWxlZCAl ZFxuIiwgcmV0KTsKPiAtCQlyZXR1cm4gcmV0Owo+ICsJaWYgKHJldCkgewo+ICsJCURSTV9ERUJV R19EUklWRVIoImd1Y19sb2dfY29udHJvbCBhY3Rpb24gZmFpbGVkICVkXG4iLCByZXQpOwo+ICsJ CWdvdG8gb3V0X3VubG9jazsKPiAgIAl9Cj4gICAKPiAtCWlmIChlbmFibGVfbG9nZ2luZykgewo+ IC0JCWk5MTVfbW9kcGFyYW1zLmd1Y19sb2dfbGV2ZWwgPSAxICsgdmVyYm9zaXR5Owo+ICsJaTkx NV9tb2RwYXJhbXMuZ3VjX2xvZ19sZXZlbCA9IHZhbDsKPiAgIAo+IC0JCS8qCj4gLQkJICogSWYg bG9nIHdhcyBkaXNhYmxlZCBhdCBib290IHRpbWUsIHRoZW4gdGhlIHJlbGF5IGNoYW5uZWwgZmls ZQo+IC0JCSAqIHdvdWxkbid0IGhhdmUgYmVlbiBjcmVhdGVkIGJ5IG5vdyBhbmQgaW50ZXJydXB0 cyBhbHNvIHdvdWxkCj4gLQkJICogbm90IGhhdmUgYmVlbiBlbmFibGVkLiBUcnkgYWdhaW4gbm93 LCBqdXN0IGluIGNhc2UuCj4gLQkJICovCj4gKwltdXRleF91bmxvY2soJmRldl9wcml2LT5kcm0u c3RydWN0X211dGV4KTsKPiArCj4gKwlpZiAoZW5hYmxlZCAmJiAhZ3VjX2xvZ19oYXNfcnVudGlt ZShndWMpKSB7Cj4gICAJCXJldCA9IGd1Y19sb2dfbGF0ZV9zZXR1cChndWMpOwo+IC0JCWlmIChy ZXQgPCAwKSB7Cj4gKwkJaWYgKHJldCkgewo+ICAgCQkJRFJNX0RFQlVHX0RSSVZFUigiR3VDIGxv ZyBsYXRlIHNldHVwIGZhaWxlZCAlZFxuIiwgcmV0KTsKPiAtCQkJcmV0dXJuIHJldDsKPiArCQkJ Z290byBvdXQ7Cj4gICAJCX0KPiAgIAo+ICAgCQkvKiBHdUMgbG9nZ2luZyBpcyBjdXJyZW50bHkg dGhlIG9ubHkgdXNlciBvZiBHdWMySG9zdCBpbnRlcnJ1cHRzICovCj4gQEAgLTcxMiw3ICs3MjQs NyBAQCBpbnQgaW50ZWxfZ3VjX2xvZ19jb250cm9sKHN0cnVjdCBpbnRlbF9ndWMgKmd1YywgdTY0 IGNvbnRyb2xfdmFsKQo+ICAgCQlnZW45X2VuYWJsZV9ndWNfaW50ZXJydXB0cyhkZXZfcHJpdik7 Cj4gICAJCWludGVsX3J1bnRpbWVfcG1fcHV0KGRldl9wcml2KTsKPiAgIAkJbXV0ZXhfdW5sb2Nr KCZkZXZfcHJpdi0+ZHJtLnN0cnVjdF9tdXRleCk7Cj4gLQl9IGVsc2Ugewo+ICsJfSBlbHNlIGlm ICghZW5hYmxlZCAmJiBndWNfbG9nX2hhc19ydW50aW1lKGd1YykpIHsKPiAgIAkJLyoKPiAgIAkJ ICogT25jZSBsb2dnaW5nIGlzIGRpc2FibGVkLCBHdUMgd29uJ3QgZ2VuZXJhdGUgbG9ncyAmIHNl bmQgYW4KPiAgIAkJICogaW50ZXJydXB0LiBCdXQgdGhlcmUgY291bGQgYmUgc29tZSBkYXRhIGlu IHRoZSBsb2cgYnVmZmVyCj4gQEAgLTcyMCwxMSArNzMyLDEzIEBAIGludCBpbnRlbF9ndWNfbG9n X2NvbnRyb2woc3RydWN0IGludGVsX2d1YyAqZ3VjLCB1NjQgY29udHJvbF92YWwpCj4gICAJCSAq IGJ1ZmZlciBzdGF0ZSBhbmQgdGhlbiBjb2xsZWN0IHRoZSBsZWZ0IG92ZXIgbG9ncy4KPiAgIAkJ ICovCj4gICAJCWd1Y19mbHVzaF9sb2dzKGd1Yyk7Cj4gLQo+IC0JCS8qIEFzIGxvZ2dpbmcgaXMg ZGlzYWJsZWQsIHVwZGF0ZSBsb2cgbGV2ZWwgdG8gcmVmbGVjdCB0aGF0ICovCj4gLQkJaTkxNV9t b2RwYXJhbXMuZ3VjX2xvZ19sZXZlbCA9IDA7Cj4gICAJfQo+ICAgCj4gKwlyZXR1cm4gMDsKPiAr Cj4gK291dF91bmxvY2s6Cj4gKwltdXRleF91bmxvY2soJmRldl9wcml2LT5kcm0uc3RydWN0X211 dGV4KTsKPiArb3V0Ogo+ICAgCXJldHVybiByZXQ7Cj4gICB9Cj4gICAKPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX2xvZy5oIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZ3VjX2xvZy5oCj4gaW5kZXggZGFiMGU5NDk1NjdhLi4xNDFjZTljYTIyY2UgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX2xvZy5oCj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX2xvZy5oCj4gQEAgLTY0LDcgKzY0LDggQEAg dm9pZCBpbnRlbF9ndWNfbG9nX2Rlc3Ryb3koc3RydWN0IGludGVsX2d1YyAqZ3VjKTsKPiAgIHZv aWQgaW50ZWxfZ3VjX2xvZ19pbml0X2Vhcmx5KHN0cnVjdCBpbnRlbF9ndWMgKmd1Yyk7Cj4gICBp bnQgaW50ZWxfZ3VjX2xvZ19yZWxheV9jcmVhdGUoc3RydWN0IGludGVsX2d1YyAqZ3VjKTsKPiAg IHZvaWQgaW50ZWxfZ3VjX2xvZ19yZWxheV9kZXN0cm95KHN0cnVjdCBpbnRlbF9ndWMgKmd1Yyk7 Cj4gLWludCBpbnRlbF9ndWNfbG9nX2NvbnRyb2woc3RydWN0IGludGVsX2d1YyAqZ3VjLCB1NjQg Y29udHJvbF92YWwpOwo+ICtpbnQgaW50ZWxfZ3VjX2xvZ19jb250cm9sX2dldChzdHJ1Y3QgaW50 ZWxfZ3VjICpndWMpOwo+ICtpbnQgaW50ZWxfZ3VjX2xvZ19jb250cm9sX3NldChzdHJ1Y3QgaW50 ZWxfZ3VjICpndWMsIHU2NCBjb250cm9sX3ZhbCk7Cj4gICB2b2lkIGk5MTVfZ3VjX2xvZ19yZWdp c3RlcihzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpOwo+ICAgdm9pZCBpOTE1X2d1 Y19sb2dfdW5yZWdpc3RlcihzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpOwo+ICAg CgotLSAKVGhhbmtzLApTYWdhcgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v aW50ZWwtZ2Z4Cg==