From: Felix Kuehling Subject: Re: [PATCH 7/7] drm/amdgpu: map VM BOs for CPU based updates only once Date: Wed, 12 Jul 2017 16:33:40 -0400 Message-ID: <70e9df44-7110-4099-d667-21ee70b982af@amd.com> References: <1499848308-1441-1-git-send-email-deathsimple@vodafone.de> <1499848308-1441-7-git-send-email-deathsimple@vodafone.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1499848308-1441-7-git-send-email-deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org> Content-Language: en-CA List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org CgpPbiAxNy0wNy0xMiAwNDozMSBBTSwgQ2hyaXN0aWFuIEvDtm5pZyB3cm90ZToKPiBGcm9tOiBD aHJpc3RpYW4gS8O2bmlnIDxjaHJpc3RpYW4ua29lbmlnQGFtZC5jb20+Cj4KPiBObyBuZWVkIHRv IHRyeSB0byBtYXAgdGhlbSB2ZXJ5IHRpbWUuCgpzL3ZlcnkvZXZlcnkvCgpPdGhlciB0aGFuIHRo YXQgdGhpcyBpcyBSZXZpZXdlZC1ieTogRmVsaXggS3VlaGxpbmcKPEZlbGl4Lkt1ZWhsaW5nQGFt ZC5jb20+LgoKUmVnYXJkcywKICBGZWxpeAoKPgo+IFNpZ25lZC1vZmYtYnk6IENocmlzdGlhbiBL w7ZuaWcgPGNocmlzdGlhbi5rb2VuaWdAYW1kLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJt L2FtZC9hbWRncHUvYW1kZ3B1X3ZtLmMgfCA4NyArKysrKysrKysrKysrKysrKysrKy0tLS0tLS0t LS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA1MSBpbnNlcnRpb25zKCspLCAzNiBkZWxldGlvbnMo LSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdm0u YyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV92bS5jCj4gaW5kZXggMWM2MDE4 Yi4uNTVkMWM3ZiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRn cHVfdm0uYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV92bS5jCj4g QEAgLTE1OSwxMSArMTU5LDE3IEBAIHZvaWQgYW1kZ3B1X3ZtX2dldF9wZF9ibyhzdHJ1Y3QgYW1k Z3B1X3ZtICp2bSwKPiAgICovCj4gIHN0YXRpYyBpbnQgYW1kZ3B1X3ZtX3ZhbGlkYXRlX2xldmVs KHN0cnVjdCBhbWRncHVfdm1fcHQgKnBhcmVudCwKPiAgCQkJCSAgICBpbnQgKCp2YWxpZGF0ZSko dm9pZCAqLCBzdHJ1Y3QgYW1kZ3B1X2JvICopLAo+IC0JCQkJICAgIHZvaWQgKnBhcmFtKQo+ICsJ CQkJICAgIHZvaWQgKnBhcmFtLCBib29sIHVzZV9jcHVfZm9yX3VwZGF0ZSkKPiAgewo+ICAJdW5z aWduZWQgaTsKPiAgCWludCByOwo+ICAKPiArCWlmICh1c2VfY3B1X2Zvcl91cGRhdGUpIHsKPiAr CQlyID0gYW1kZ3B1X2JvX2ttYXAocGFyZW50LT5ibywgTlVMTCk7Cj4gKwkJaWYgKHIpCj4gKwkJ CXJldHVybiByOwo+ICsJfQo+ICsKPiAgCWlmICghcGFyZW50LT5lbnRyaWVzKQo+ICAJCXJldHVy biAwOwo+ICAKPiBAQCAtMTgxLDcgKzE4Nyw4IEBAIHN0YXRpYyBpbnQgYW1kZ3B1X3ZtX3ZhbGlk YXRlX2xldmVsKHN0cnVjdCBhbWRncHVfdm1fcHQgKnBhcmVudCwKPiAgCQkgKiBSZWN1cnNlIGlu dG8gdGhlIHN1YiBkaXJlY3RvcnkuIFRoaXMgaXMgaGFybWxlc3MgYmVjYXVzZSB3ZQo+ICAJCSAq IGhhdmUgb25seSBhIG1heGltdW0gb2YgNSBsYXllcnMuCj4gIAkJICovCj4gLQkJciA9IGFtZGdw dV92bV92YWxpZGF0ZV9sZXZlbChlbnRyeSwgdmFsaWRhdGUsIHBhcmFtKTsKPiArCQlyID0gYW1k Z3B1X3ZtX3ZhbGlkYXRlX2xldmVsKGVudHJ5LCB2YWxpZGF0ZSwgcGFyYW0sCj4gKwkJCQkJICAg ICB1c2VfY3B1X2Zvcl91cGRhdGUpOwo+ICAJCWlmIChyKQo+ICAJCQlyZXR1cm4gcjsKPiAgCX0K PiBAQCAtMjEyLDcgKzIxOSw4IEBAIGludCBhbWRncHVfdm1fdmFsaWRhdGVfcHRfYm9zKHN0cnVj dCBhbWRncHVfZGV2aWNlICphZGV2LCBzdHJ1Y3QgYW1kZ3B1X3ZtICp2bSwKPiAgCWlmIChudW1f ZXZpY3Rpb25zID09IHZtLT5sYXN0X2V2aWN0aW9uX2NvdW50ZXIpCj4gIAkJcmV0dXJuIDA7Cj4g IAo+IC0JcmV0dXJuIGFtZGdwdV92bV92YWxpZGF0ZV9sZXZlbCgmdm0tPnJvb3QsIHZhbGlkYXRl LCBwYXJhbSk7Cj4gKwlyZXR1cm4gYW1kZ3B1X3ZtX3ZhbGlkYXRlX2xldmVsKCZ2bS0+cm9vdCwg dmFsaWRhdGUsIHBhcmFtLAo+ICsJCQkJCXZtLT51c2VfY3B1X2Zvcl91cGRhdGUpOwo+ICB9Cj4g IAo+ICAvKioKPiBAQCAtMzI4LDYgKzMzNiwxNCBAQCBzdGF0aWMgaW50IGFtZGdwdV92bV9hbGxv Y19sZXZlbHMoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYsCj4gIAkJCWlmIChyKQo+ICAJCQkJ cmV0dXJuIHI7Cj4gIAo+ICsJCQlpZiAodm0tPnVzZV9jcHVfZm9yX3VwZGF0ZSkgewo+ICsJCQkJ ciA9IGFtZGdwdV9ib19rbWFwKHB0LCBOVUxMKTsKPiArCQkJCWlmIChyKSB7Cj4gKwkJCQkJYW1k Z3B1X2JvX3VucmVmKCZwdCk7Cj4gKwkJCQkJcmV0dXJuIHI7Cj4gKwkJCQl9Cj4gKwkJCX0KPiAr Cj4gIAkJCS8qIEtlZXAgYSByZWZlcmVuY2UgdG8gdGhlIHJvb3QgZGlyZWN0b3J5IHRvIGF2b2lk Cj4gIAkJCSogZnJlZWluZyB0aGVtIHVwIGluIHRoZSB3cm9uZyBvcmRlci4KPiAgCQkJKi8KPiBA QCAtMTA0MiwxNCArMTA1OCwxMSBAQCBzdGF0aWMgaW50IGFtZGdwdV92bV91cGRhdGVfbGV2ZWwo c3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYsCj4gIAlzaGFkb3cgPSBwYXJlbnQtPmJvLT5zaGFk b3c7Cj4gIAo+ICAJaWYgKHZtLT51c2VfY3B1X2Zvcl91cGRhdGUpIHsKPiAtCQlyID0gYW1kZ3B1 X2JvX2ttYXAocGFyZW50LT5ibywgKHZvaWQgKiopJnBkX2FkZHIpOwo+IC0JCWlmIChyKQo+IC0J CQlyZXR1cm4gcjsKPiArCQlwZF9hZGRyID0gKHVuc2lnbmVkIGxvbmcpcGFyZW50LT5iby0+a3B0 cjsKPiAgCQlyID0gYW1kZ3B1X3ZtX3dhaXRfcGQoYWRldiwgdm0sIEFNREdQVV9GRU5DRV9PV05F Ul9WTSk7Cj4gLQkJaWYgKHVubGlrZWx5KHIpKSB7Cj4gLQkJCWFtZGdwdV9ib19rdW5tYXAocGFy ZW50LT5ibyk7Cj4gKwkJaWYgKHVubGlrZWx5KHIpKQo+ICAJCQlyZXR1cm4gcjsKPiAtCQl9Cj4g Kwo+ICAJCXBhcmFtcy5mdW5jID0gYW1kZ3B1X3ZtX2NwdV9zZXRfcHRlczsKPiAgCX0gZWxzZSB7 Cj4gIAkJaWYgKHNoYWRvdykgewo+IEBAIC0xMTQ0LDI4ICsxMTU3LDI5IEBAIHN0YXRpYyBpbnQg YW1kZ3B1X3ZtX3VwZGF0ZV9sZXZlbChzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiwKPiAgCQkJ ICAgIGNvdW50LCBpbmNyLCBBTURHUFVfUFRFX1ZBTElEKTsKPiAgCX0KPiAgCj4gLQlpZiAocGFy YW1zLmZ1bmMgPT0gYW1kZ3B1X3ZtX2NwdV9zZXRfcHRlcykKPiAtCQlhbWRncHVfYm9fa3VubWFw KHBhcmVudC0+Ym8pOwo+IC0JZWxzZSBpZiAocGFyYW1zLmliLT5sZW5ndGhfZHcgPT0gMCkgewo+ IC0JCWFtZGdwdV9qb2JfZnJlZShqb2IpOwo+IC0JfSBlbHNlIHsKPiAtCQlhbWRncHVfcmluZ19w YWRfaWIocmluZywgcGFyYW1zLmliKTsKPiAtCQlhbWRncHVfc3luY19yZXN2KGFkZXYsICZqb2It PnN5bmMsIHBhcmVudC0+Ym8tPnRiby5yZXN2LAo+IC0JCQkJIEFNREdQVV9GRU5DRV9PV05FUl9W TSk7Cj4gLQkJaWYgKHNoYWRvdykKPiAtCQkJYW1kZ3B1X3N5bmNfcmVzdihhZGV2LCAmam9iLT5z eW5jLCBzaGFkb3ctPnRiby5yZXN2LAo+ICsJaWYgKCF2bS0+dXNlX2NwdV9mb3JfdXBkYXRlKSB7 Cj4gKwkJaWYgKHBhcmFtcy5pYi0+bGVuZ3RoX2R3ID09IDApIHsKPiArCQkJYW1kZ3B1X2pvYl9m cmVlKGpvYik7Cj4gKwkJfSBlbHNlIHsKPiArCQkJYW1kZ3B1X3JpbmdfcGFkX2liKHJpbmcsIHBh cmFtcy5pYik7Cj4gKwkJCWFtZGdwdV9zeW5jX3Jlc3YoYWRldiwgJmpvYi0+c3luYywgcGFyZW50 LT5iby0+dGJvLnJlc3YsCj4gIAkJCQkJIEFNREdQVV9GRU5DRV9PV05FUl9WTSk7Cj4gKwkJCWlm IChzaGFkb3cpCj4gKwkJCQlhbWRncHVfc3luY19yZXN2KGFkZXYsICZqb2ItPnN5bmMsCj4gKwkJ CQkJCSBzaGFkb3ctPnRiby5yZXN2LAo+ICsJCQkJCQkgQU1ER1BVX0ZFTkNFX09XTkVSX1ZNKTsK PiArCj4gKwkJCVdBUk5fT04ocGFyYW1zLmliLT5sZW5ndGhfZHcgPiBuZHcpOwo+ICsJCQlyID0g YW1kZ3B1X2pvYl9zdWJtaXQoam9iLCByaW5nLCAmdm0tPmVudGl0eSwKPiArCQkJCQlBTURHUFVf RkVOQ0VfT1dORVJfVk0sICZmZW5jZSk7Cj4gKwkJCWlmIChyKQo+ICsJCQkJZ290byBlcnJvcl9m cmVlOwo+ICAKPiAtCQlXQVJOX09OKHBhcmFtcy5pYi0+bGVuZ3RoX2R3ID4gbmR3KTsKPiAtCQly ID0gYW1kZ3B1X2pvYl9zdWJtaXQoam9iLCByaW5nLCAmdm0tPmVudGl0eSwKPiAtCQkJCUFNREdQ VV9GRU5DRV9PV05FUl9WTSwgJmZlbmNlKTsKPiAtCQlpZiAocikKPiAtCQkJZ290byBlcnJvcl9m cmVlOwo+IC0KPiAtCQlhbWRncHVfYm9fZmVuY2UocGFyZW50LT5ibywgZmVuY2UsIHRydWUpOwo+ IC0JCWRtYV9mZW5jZV9wdXQodm0tPmxhc3RfZGlyX3VwZGF0ZSk7Cj4gLQkJdm0tPmxhc3RfZGly X3VwZGF0ZSA9IGRtYV9mZW5jZV9nZXQoZmVuY2UpOwo+IC0JCWRtYV9mZW5jZV9wdXQoZmVuY2Up Owo+ICsJCQlhbWRncHVfYm9fZmVuY2UocGFyZW50LT5ibywgZmVuY2UsIHRydWUpOwo+ICsJCQlk bWFfZmVuY2VfcHV0KHZtLT5sYXN0X2Rpcl91cGRhdGUpOwo+ICsJCQl2bS0+bGFzdF9kaXJfdXBk YXRlID0gZG1hX2ZlbmNlX2dldChmZW5jZSk7Cj4gKwkJCWRtYV9mZW5jZV9wdXQoZmVuY2UpOwo+ ICsJCX0KPiAgCX0KPiAgCS8qCj4gIAkgKiBSZWN1cnNlIGludG8gdGhlIHN1YmRpcmVjdG9yaWVz LiBUaGlzIHJlY3Vyc2lvbiBpcyBoYXJtbGVzcyBiZWNhdXNlCj4gQEAgLTEyOTEsNyArMTMwNSw2 IEBAIHN0YXRpYyBpbnQgYW1kZ3B1X3ZtX3VwZGF0ZV9wdGVzKHN0cnVjdCBhbWRncHVfcHRlX3Vw ZGF0ZV9wYXJhbXMgKnBhcmFtcywKPiAgCXVpbnQ2NF90IGFkZHIsIHBlX3N0YXJ0Owo+ICAJc3Ry dWN0IGFtZGdwdV9ibyAqcHQ7Cj4gIAl1bnNpZ25lZCBucHRlczsKPiAtCWludCByOwo+ICAJYm9v bCB1c2VfY3B1X3VwZGF0ZSA9IChwYXJhbXMtPmZ1bmMgPT0gYW1kZ3B1X3ZtX2NwdV9zZXRfcHRl cyk7Cj4gIAo+ICAKPiBAQCAtMTMxMCw5ICsxMzIzLDcgQEAgc3RhdGljIGludCBhbWRncHVfdm1f dXBkYXRlX3B0ZXMoc3RydWN0IGFtZGdwdV9wdGVfdXBkYXRlX3BhcmFtcyAqcGFyYW1zLAo+ICAK PiAgCj4gIAkJaWYgKHVzZV9jcHVfdXBkYXRlKSB7Cj4gLQkJCXIgPSBhbWRncHVfYm9fa21hcChw dCwgKHZvaWQgKikmcGVfc3RhcnQpOwo+IC0JCQlpZiAocikKPiAtCQkJCXJldHVybiByOwo+ICsJ CQlwZV9zdGFydCA9ICh1bnNpZ25lZCBsb25nKXB0LT5rcHRyOwo+ICAJCX0gZWxzZSB7Cj4gIAkJ CWlmIChwdC0+c2hhZG93KSB7Cj4gIAkJCQlwZV9zdGFydCA9IGFtZGdwdV9ib19ncHVfb2Zmc2V0 KHB0LT5zaGFkb3cpOwo+IEBAIC0xMzI4LDkgKzEzMzksNiBAQCBzdGF0aWMgaW50IGFtZGdwdV92 bV91cGRhdGVfcHRlcyhzdHJ1Y3QgYW1kZ3B1X3B0ZV91cGRhdGVfcGFyYW1zICpwYXJhbXMsCj4g IAkJCSAgICAgQU1ER1BVX0dQVV9QQUdFX1NJWkUsIGZsYWdzKTsKPiAgCj4gIAkJZHN0ICs9IG5w dGVzICogQU1ER1BVX0dQVV9QQUdFX1NJWkU7Cj4gLQo+IC0JCWlmICh1c2VfY3B1X3VwZGF0ZSkK PiAtCQkJYW1kZ3B1X2JvX2t1bm1hcChwdCk7Cj4gIAl9Cj4gIAo+ICAJcmV0dXJuIDA7Cj4gQEAg LTI0NTgsNiArMjQ2NiwxMyBAQCBpbnQgYW1kZ3B1X3ZtX2luaXQoc3RydWN0IGFtZGdwdV9kZXZp Y2UgKmFkZXYsIHN0cnVjdCBhbWRncHVfdm0gKnZtLAo+ICAJCWdvdG8gZXJyb3JfZnJlZV9yb290 Owo+ICAKPiAgCXZtLT5sYXN0X2V2aWN0aW9uX2NvdW50ZXIgPSBhdG9taWM2NF9yZWFkKCZhZGV2 LT5udW1fZXZpY3Rpb25zKTsKPiArCj4gKwlpZiAodm0tPnVzZV9jcHVfZm9yX3VwZGF0ZSkgewo+ ICsJCXIgPSBhbWRncHVfYm9fa21hcCh2bS0+cm9vdC5ibywgTlVMTCk7Cj4gKwkJaWYgKHIpCj4g KwkJCWdvdG8gZXJyb3JfZnJlZV9yb290Owo+ICsJfQo+ICsKPiAgCWFtZGdwdV9ib191bnJlc2Vy dmUodm0tPnJvb3QuYm8pOwo+ICAKPiAgCXJldHVybiAwOwoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBtYWlsaW5nIGxpc3QKYW1kLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9hbWQtZ2Z4Cg==