From: Keir Fraser Subject: Re: [PATCH] x86-64 linux: another adjustment to vmalloc fault handling Date: Fri, 17 Feb 2006 11:05:13 +0000 Message-ID: <70f7092ddafe4fa9a96ebfd770ad2ed1@cl.cam.ac.uk> References: <43F5B5CB.76F0.0078.0@novell.com> Mime-Version: 1.0 (Apple Message framework v623) Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <43F5B5CB.76F0.0078.0@novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 17 Feb 2006, at 10:38, Jan Beulich wrote: > Changeset 8847 improved things, but doesn't generally work. We namely > experienced problems (when we originally tried the > same change) with accesses to machine_to_phys_mapping, which (in > mfn_to_pfn) is specifically allowed to fault. Hence > there should not be attempts to fix up faults within the hypervisor > range (as for any page table entries obtained there > no m2p translation exists for the guest, resulting in bogus physical > addresses getting used for further fault > processing, frequently leading to nested faults). But machine_to_phys_mapping == 0xffff800000000000 while PAGE_OFFSET == HYPERVISOR_VIRT_END == 0xffff880000000000. So the patch doesn't really change anything, and machine_to_phys_mapping lives below both PAGE_OFFSET and HYPERVISOR_VIRT_END anyway. -- Keir