Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6DF2C433E0 for ; Tue, 2 Jun 2020 12:19:31 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9674A20663 for ; Tue, 2 Jun 2020 12:19:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9674A20663 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jg5sy-0006Zz-GN; Tue, 02 Jun 2020 12:19:16 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jg5sx-0006Zu-2v for xen-devel@lists.xenproject.org; Tue, 02 Jun 2020 12:19:15 +0000 X-Inumbo-ID: 458b0cda-a4cb-11ea-9947-bc764e2007e4 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 458b0cda-a4cb-11ea-9947-bc764e2007e4; Tue, 02 Jun 2020 12:19:14 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 6EEADACF1; Tue, 2 Jun 2020 12:19:15 +0000 (UTC) Subject: Re: [PATCH-for-4.14 1/2] xen: fix build with CONFIG_HYPFS_CONFIG enabled To: Wei Liu , Jan Beulich References: <20200602114050.5964-1-jgross@suse.com> <20200602114050.5964-2-jgross@suse.com> <20200602120726.vm3br27ygbvbs2bx@liuwe-devbox-debian-v2.j3c5onc20sse1dnehy4noqpfcg.zx.internal.cloudapp.net> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <7157b762-014b-802a-ea85-ae7bf89a5d73@suse.com> Date: Tue, 2 Jun 2020 14:19:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200602120726.vm3br27ygbvbs2bx@liuwe-devbox-debian-v2.j3c5onc20sse1dnehy4noqpfcg.zx.internal.cloudapp.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , paul@xen.org, Andrew Cooper , Ian Jackson , George Dunlap , xen-devel@lists.xenproject.org Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 02.06.20 14:07, Wei Liu wrote: > On Tue, Jun 02, 2020 at 01:55:14PM +0200, Jan Beulich wrote: >> On 02.06.2020 13:40, Juergen Gross wrote: >>> --- a/xen/common/Makefile >>> +++ b/xen/common/Makefile >>> @@ -75,7 +75,7 @@ obj-$(CONFIG_UBSAN) += ubsan/ >>> obj-$(CONFIG_NEEDS_LIBELF) += libelf/ >>> obj-$(CONFIG_HAS_DEVICE_TREE) += libfdt/ >>> >>> -config.gz: ../.config >>> +config.gz: $(XEN_ROOT)/xen/$(KCONFIG_CONFIG) >> >> Looking at all pre-existing uses of KCONFIG_CONFIG this is the >> first one assuming it holds a relative path. The doc also doesn't >> indicate it can't be an absolute one. > > This is not an objection to this patch right? I can see his point. In case KCONFIG_CONFIG is set to an absolute path the result won't build. The proper solution would be to test KCONFIG_CONFIG for being an absolute path and do the prefixing of $(XEN_ROOT)/xen/ only if this isn't the case. I'll send V2 of this patch. Juergen