From: "cron2 (Code Review)" Date: Sat, 6 Jan 2024 15:31:06 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <71d3e97fb31adf54ab7b9642bc8aec6b4468e8c1-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="ZmePAH5/j9o="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: Implement the --tls-export-cert feature List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: flichtenheld , openvpn-devel --ZmePAH5/j9o= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/466?usp=3Demail ) Change subject: Implement the --tls-export-cert feature ...................................................................... Patch Set 10: Code-Review+2 (1 comment) Patchset: PS10: OK, this seems to be doing what the (old) manpage leads me to expect - for each level of certificates, --tls-verify is called once (so "1x for l= evel 0, 1x for level 1" if no intermediate CAs are used) - this was not cle= ar to me initially, that it's indeed called multiple times. - depending on the level of call, exactly one `$peer_cert_` env variable= is set, and that certificate file exists - on level 0, `$peer_cert` is set as well - indeed, different certs show up in these files The old code only ever sets `peer_cert`, though, independent of the level, = so I'm not sure having a (single) `$peer_cert_` variable is that useful = - if it's only one, `peer_cert` is maybe good enough? So we could move onward, or move to "always `$peer_cert`, no `_`... -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/466?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia9b3f1813d2d0d492d17c87348b4cebd0bf19ce2 Gerrit-Change-Number: 466 Gerrit-PatchSet: 10 Gerrit-Owner: plaisthos Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Sat, 06 Jan 2024 15:31:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --ZmePAH5/j9o= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, plaisthos.

Patch set 10:Code-Review +2

V= iew Change

1 comment:

  • Patchset:

    • Patch Set #10:

      OK, this seems to be doing what the (old) ma= npage leads me to expect

      • for each level of certificates, --tls-v= erify is called once (so "1x for level 0, 1x for level 1" if no i= ntermediate CAs are used) - this was not clear to me initially, that it'= ;s indeed called multiple times.
      • depending on the level of call, ex= actly one `$peer_cert_<n>` env variable is set, and that certificate = file exists
      • on level 0, `$peer_cert` is set as well
      • indeed,= different certs show up in these files

      The old code only ever sets `peer_cert`, t= hough, independent of the level, so I'm not sure having a (single) `$pe= er_cert_<n>` variable is that useful - if it's only one, `peer_ce= rt` is maybe good enough?

      So we could move onward, or move to "always `$peer_cert`,= no `_<n>`...

To view, visit change 466. To unsu= bscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ia9b3f1813d2d0d492d17c87348b= 4cebd0bf19ce2
Gerrit-Change-Number: 466
Gerrit-PatchSet: 10
Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Comment-Date: Sat, 06 Jan 2024 15:31:06= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--ZmePAH5/j9o=--