From: "flichtenheld (Code Review)" Date: Wed, 16 Oct 2024 14:06:07 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., gianmarco@...2726..., openvpn-devel@lists.sourceforge.net, a@...2181... Message-ID: <7260010127fceb9d9977977bc88eebe3ebe5b0e5-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="6EFAd4d1Q2M="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: allow user to specify 'local' multiple times in config files List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: its_Giaan Cc: plaisthos , openvpn-devel --6EFAd4d1Q2M= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: its_Giaan, ordex, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne= t/c/openvpn/+/436?usp=3Demail ) Change subject: allow user to specify 'local' multiple times in config files ...................................................................... Patch Set 5: Code-Review-1 (7 comments) File doc/man-sections/link-options.rst: http://gerrit.openvpn.net/c/openvpn/+/436/comment/82b9206f_257c5965 : PS5, Line 114: 0.0.0.0 or :: can be used to specifically open a socket. Sentence does end in the middle? http://gerrit.openvpn.net/c/openvpn/+/436/comment/729f1acd_879715ca : PS5, Line 117: or name Should probably say "default TCP/UDP port number" or something like that an= d mention that this can be overridden by individual --local entries. File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/436/comment/e215e510_be593b03 : PS5, Line 2400: * Sanity check on daemon mode Not sure what daemon is supposed to mean in this context? http://gerrit.openvpn.net/c/openvpn/+/436/comment/7f064a0d_b60cd452 : PS5, Line 3198: if (ce->proto =3D=3D PROTO_UDP && ce->socks_proxy_serve= r && !ce->local_list && !ce->local_port_defined && !ce->bind_defined) Should use need_bind to simplify the condition. http://gerrit.openvpn.net/c/openvpn/+/436/comment/09c9c53d_d50c5988 : PS5, Line 3327: options_postprocess_mutate_le(struct options *o, struct loc= al_entry *le) should maybe take o->ce as input and not o, just to make clear that it does= n't need the rest? http://gerrit.openvpn.net/c/openvpn/+/436/comment/5052e26b_a665c5df : PS5, Line 6247: if (strcmp(p[1], "*") !=3D 0) should we issue a warning if someone specifies "--local *" without port num= ber that this is a NOOP? File src/openvpn/socket.c: http://gerrit.openvpn.net/c/openvpn/+/436/comment/c0b1d821_0f10076d : PS5, Line 358: options either this should use "l" or the definition of "l" should be removed compl= etely. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/436?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I4d1c96662c5a8c750d883e3b20adde09529e2764 Gerrit-Change-Number: 436 Gerrit-PatchSet: 5 Gerrit-Owner: ordex Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: its_Giaan Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: its_Giaan Gerrit-Attention: ordex Gerrit-Comment-Date: Wed, 16 Oct 2024 14:06:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --6EFAd4d1Q2M= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: its_Giaan, ordex, plaisthos.

Patch set 5:Code-Review -1=

Vi= ew Change

7 comments:

  • File doc/man-sections/link-opti= ons.rst:

    • Patch Set = #5, Line 114: 0.0.0.0= or :: can be used to specifically open a socket.

      Sentence does end in the middle= ?

    • Patch Set #5, Line 117: or name

      Should probably say "default TCP/UDP port number= " or something like that and mention that this can be overridden by in= dividual --local entries.

  • File src/openvpn/options.c:

    • Patch Set #5, Line 2400: * Sanity check on daemon mode

      Not sure what daemon is = supposed to mean in this context?

    • Patch Set #5, Line 3198:= if (ce->proto = =3D=3D PROTO_UDP && ce->socks_proxy_server && !ce->lo= cal_list && !ce->local_port_defined && !ce->bind_defi= ned)

      S= hould use need_bind to simplify the condition.

    • Patch Set #= 5, Line 3327: options_p= ostprocess_mutate_le(struct options *o, struct local_entry *le)

      <= p style=3D"white-space: pre-wrap; word-wrap: break-word;">should maybe take= o->ce as input and not o, just to make clear that it doesn't need t= he rest?

    • Patch Set #5, Line 6247: if (strcmp(p[1], "*") !=3D 0)=

      shoul= d we issue a warning if someone specifies "--local *" without por= t number that this is a NOOP?

  • File src/openvpn/socket.c:

<= p>To view, visit change 436. To unsubscribe, or for help writing mail filters,= visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I4d1c96662c5a8c750d883e3b20a= dde09529e2764
Gerrit-Change-Number: 436
Gerrit-PatchSet: 5
Gerrit-Owner: ordex <a@...2181...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: its_Giaan <gianmarco@...2726...&= gt;
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: its_Giaan <gianmarco@...1665...= 726...>
Gerrit-Attention: ordex <a@...2181...> <= /div>
Gerrit-Comment-Date: Wed, 16 Oct 2024 14:06:07= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--6EFAd4d1Q2M=--